From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension Date: Wed, 06 Nov 2013 11:29:47 -0800 Message-ID: <86fvr9qqfo.fsf@miki.keithp.com> References: <1383618208-21310-1-git-send-email-keithp@keithp.com> <1383618208-21310-8-git-send-email-keithp@keithp.com> <20131106062554.GA12984@tokamak.local> <86ob5x4m28.fsf@miki.keithp.com> <868ux1s8qe.fsf@miki.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0153704179==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id EDB63112A5B for ; Wed, 6 Nov 2013 11:29:51 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Kristian =?utf-8?Q?H=C3=B8gsberg?= Cc: mesa3d-dev@lists.freedesktop.org, dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0153704179== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kristian H=C3=B8gsberg writes: > I'm OK with either approach. It does seem like cleaning up the DRI > driver interface is orthogonal to enabling the __DRIimage based > getBuffer callout though. We should probably not merge what we don't want to maintain though; let's decide over lunch. I don't think it matters very much to the current code, it'll only bug us in small ways in the future. > I think that's fine. I was going to say that if we expect the > requested and the returned set of buffers to differ, we might as well > just memset the struct and let non-NULL images indicate returned > images. But in case of a driver with a newer interface that extends > the struct (stereoscopic buffers), the loader can't memset the entire > struct (it only knows the smaller, previous version), and the driver > will think the non-NULL garbage fields are valid images. So the > image_mask makes sense. That's what I was thinking. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIVAwUBUnqYrNsiGmkAAAARAQiV6Q/+MfisKnvl+Me4LeHl/U8mI7nHZHqfl0yq QspkTfMbJvHWAnn6PJLMLqcQ6PO7cKNl9GFHKInYnZ/Rhie+htA/akI+OeYHPemN gHzqK+A+DKRmibbWaRlqcKThUmOaSYSFbd5RtLi8JaxLs95z0NAfaH2DqpTu0CLc 261XQydLtKagKKc7QzjzRxWvKOK/2Jaa+eq4WCbc5FIZxSB81mE3a8LP2UhgzbeA PrHMweAUJKtkGJpvX9I+Pitj3PE0PJH93yOLsSj/akEW/Kl9naFma2uMTJ7h9MbR ZXt3Kv8CBp68Yd52hZuGiH13r8lHw/KNPLLNlzNNsgc77favdv7Atj3DvTEO7Ksi yeHpL/qujIbxG69N1kUV87ze4B56cz2QD70hn7XBK8VR2RohhyMCXD7rrEuvP74t WPWMjPq3l6gmrG66tWh5z8Ts4FM557sp8FUn95wadGXiBxJdn1xfriUE7OqFsfgn znZhvP4JMRi9H9l7reSvsbYIuxsw/CZQLgs/LEe+FdUZWLIyxR0rt0Yp8WgrMFPY zCRC1vtpHsG3BS/0hWz83TWdoRJHAB/6tvdCNTcU13orVp8JaKnVymNojGXQff8K 1Sf3J1XchbURykyV80yFz5GjF6fZ54kDu19hzkGMpLClmpEz5RYkscY32N9mrAas w5/QQgUeuPQ= =vw3m -----END PGP SIGNATURE----- --=-=-=-- --===============0153704179== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0153704179==--