From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 651F127477 for ; Thu, 19 Oct 2023 14:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q+IPTom2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA561C433C7; Thu, 19 Oct 2023 14:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697724472; bh=cwYxbU4uV9qhjaZqQV147ceVMlmQJtz8w9Ywna095cw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q+IPTom2FPEiR0CZOXFr3hpsQMqHhZzSOfLuZ4fMGMzkkSPKthZCqwsjdryEL38wI EYAFnimwk7YdRuLJgSdmc5r9H9T8bRXGen40+CloRUQh22n2QkZ5NXTTw/96DvgsN5 kra9MsUIjAP/3HEJmQPF3BdgTGFN13EIXt8s5k2eaFZ1XxllTK9SJzcPY/FDr8N09M hxAKwYCqOo1FfX3gjdBRRQJWK2Z+4nwOZZoFTTuav/9ou2GZrJZ0Flea0bVczYbNIf RjJWhKGQbsbxTPl6zAK3dlnwaohLFrBuHiRVf/kjqOiblmbv3FF+J/eXQ7ydnTpkFD EWUbgOYWu8Daw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtTgk-005nGE-3v; Thu, 19 Oct 2023 15:07:50 +0100 Date: Thu, 19 Oct 2023 15:07:48 +0100 Message-ID: <86h6mmn1sb.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Eric Auger , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" Subject: Re: [PATCH v4 2/3] arm64: Add missing _EL2 encodings In-Reply-To: <21F82E44-6D93-4F4C-8991-F14948673F54@oracle.com> References: <20231016111743.30331-1-miguel.luis@oracle.com> <20231016111743.30331-3-miguel.luis@oracle.com> <86jzrin8nq.wl-maz@kernel.org> <21F82E44-6D93-4F4C-8991-F14948673F54@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 19 Oct 2023 14:23:09 +0100, Miguel Luis wrote: >=20 > Hi Marc, >=20 > > On 19 Oct 2023, at 11:39, Marc Zyngier wrote: > >=20 > > On Mon, 16 Oct 2023 12:17:41 +0100, > > Miguel Luis wrote: > >>=20 > >> Some _EL2 encodings are missing. Add them. > >>=20 > >> Signed-off-by: Miguel Luis > >> --- > >> arch/arm64/include/asm/sysreg.h | 39 +++++++++++++++++++++++++++++++++ > >> 1 file changed, 39 insertions(+) > >>=20 > >> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/= sysreg.h > >> index ba5db50effec..8653fb67a339 100644 > >> --- a/arch/arm64/include/asm/sysreg.h > >> +++ b/arch/arm64/include/asm/sysreg.h > >=20 > > [...] > >=20 > >> +#define SYS_SDER32_EL2 sys_reg(3, 4, 1, 3, 1) > >=20 > > [...] > >=20 > >> +#define SYS_VSTTBR_EL2 sys_reg(3, 4, 2, 6, 0) > >> +#define SYS_VSTCR_EL2 sys_reg(3, 4, 2, 6, 2) > >=20 > > [...] > >=20 > >> +#define SYS_CNTHVS_TVAL_EL2 sys_reg(3, 4, 14, 4, 0) > >> +#define SYS_CNTHVS_CTL_EL2 sys_reg(3, 4, 14, 4, 1) > >> +#define SYS_CNTHVS_CVAL_EL2 sys_reg(3, 4, 14, 4, 2) > >> +#define SYS_CNTHPS_TVAL_EL2 sys_reg(3, 4, 14, 5, 0) > >> +#define SYS_CNTHPS_CTL_EL2 sys_reg(3, 4, 14, 5, 1) > >> +#define SYS_CNTHPS_CVAL_EL2 sys_reg(3, 4, 14, 5, 2) > >=20 > > While the secure definitions seem correct, what is the rationale > > behind their presence here? They cannot be trapped from non-secure, > > and the pseudocode is pretty explicit: > >=20 > > if !IsCurrentSecurityState(SS_Secure) then > > UNDEFINED; > >=20 > > Given that, they cannot be trapped, handled or accessed from a KVM > > guest, as Linux on arm64 *always* runs non-secure. > >=20 >=20 > Thank you for clarifying. >=20 > Those definitions were needed for the refinement on patch 3 which clearly > didn=E2=80=99t considered that statement beforehand. >=20 > Yet, should we keep them here so they could be used? But that's the whole point: they *cannot* be used. You can't use a secure system register in non-secure, and we *always* run in non-secure, no ifs no buts. If a guest ever uses one of those, it will get an UNDEF exception directly, without any SW intervention, because that's just illegal. KVM will never see it. As far as Linux is concerned, this is purely dead code. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EF5BCDB465 for ; Thu, 19 Oct 2023 14:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cC/6SRRWoZNbX0BK/BxzAsKDE+OGNO46njFO+MPrntA=; b=PsbmGyA+TbWyV3 sEw4y+CVB1AjOiDtJhzDI8CBr8OlmkEKSNmONX+EIS3mYDZuM0NjHxsODGLrPlIBmdCGGp+RhTOYY 4XA6EKIfZrQ/7WLDRsoGwgBFSoUMJWUxnz/opXu7Z6zNCwtWGU8tvNKzwZtO6EeXM1inUtUwMeZy2 OCxJo/MXYGyHe3HyM+Q22NRDiSrsl4jcMOjG/Rzj7jQP+7kK39kObTiWwhXVc9i4TxdrnHL6QrMgm 1qs9HdyXtdi+BtOKVBUyAzGkHS0p5pqZjdr2hKdUHHnzYpp+XcFS5vwXwnHgLfTqNM0VgRNOeejKY isjKbIprfqShCQPfGVVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtTgs-0001oD-0K; Thu, 19 Oct 2023 14:07:58 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtTgp-0001mw-0P for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 14:07:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7ACCBB826AA; Thu, 19 Oct 2023 14:07:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA561C433C7; Thu, 19 Oct 2023 14:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697724472; bh=cwYxbU4uV9qhjaZqQV147ceVMlmQJtz8w9Ywna095cw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q+IPTom2FPEiR0CZOXFr3hpsQMqHhZzSOfLuZ4fMGMzkkSPKthZCqwsjdryEL38wI EYAFnimwk7YdRuLJgSdmc5r9H9T8bRXGen40+CloRUQh22n2QkZ5NXTTw/96DvgsN5 kra9MsUIjAP/3HEJmQPF3BdgTGFN13EIXt8s5k2eaFZ1XxllTK9SJzcPY/FDr8N09M hxAKwYCqOo1FfX3gjdBRRQJWK2Z+4nwOZZoFTTuav/9ou2GZrJZ0Flea0bVczYbNIf RjJWhKGQbsbxTPl6zAK3dlnwaohLFrBuHiRVf/kjqOiblmbv3FF+J/eXQ7ydnTpkFD EWUbgOYWu8Daw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtTgk-005nGE-3v; Thu, 19 Oct 2023 15:07:50 +0100 Date: Thu, 19 Oct 2023 15:07:48 +0100 Message-ID: <86h6mmn1sb.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Eric Auger , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" Subject: Re: [PATCH v4 2/3] arm64: Add missing _EL2 encodings In-Reply-To: <21F82E44-6D93-4F4C-8991-F14948673F54@oracle.com> References: <20231016111743.30331-1-miguel.luis@oracle.com> <20231016111743.30331-3-miguel.luis@oracle.com> <86jzrin8nq.wl-maz@kernel.org> <21F82E44-6D93-4F4C-8991-F14948673F54@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_070755_467143_AA5E3262 X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxOSBPY3QgMjAyMyAxNDoyMzowOSArMDEwMCwKTWlndWVsIEx1aXMgPG1pZ3VlbC5s dWlzQG9yYWNsZS5jb20+IHdyb3RlOgo+IAo+IEhpIE1hcmMsCj4gCj4gPiBPbiAxOSBPY3QgMjAy MywgYXQgMTE6MzksIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gCj4g PiBPbiBNb24sIDE2IE9jdCAyMDIzIDEyOjE3OjQxICswMTAwLAo+ID4gTWlndWVsIEx1aXMgPG1p Z3VlbC5sdWlzQG9yYWNsZS5jb20+IHdyb3RlOgo+ID4+IAo+ID4+IFNvbWUgX0VMMiBlbmNvZGlu Z3MgYXJlIG1pc3NpbmcuIEFkZCB0aGVtLgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IE1pZ3Vl bCBMdWlzIDxtaWd1ZWwubHVpc0BvcmFjbGUuY29tPgo+ID4+IC0tLQo+ID4+IGFyY2gvYXJtNjQv aW5jbHVkZS9hc20vc3lzcmVnLmggfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPiA+PiAxIGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKQo+ID4+IAo+ID4+IGRpZmYg LS1naXQgYS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oIGIvYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9zeXNyZWcuaAo+ID4+IGluZGV4IGJhNWRiNTBlZmZlYy4uODY1M2ZiNjdhMzM5IDEw MDY0NAo+ID4+IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPiA+PiArKysg Yi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+ PiArI2RlZmluZSBTWVNfU0RFUjMyX0VMMiBzeXNfcmVnKDMsIDQsIDEsIDMsIDEpCj4gPiAKPiA+ IFsuLi5dCj4gPiAKPiA+PiArI2RlZmluZSBTWVNfVlNUVEJSX0VMMiBzeXNfcmVnKDMsIDQsIDIs IDYsIDApCj4gPj4gKyNkZWZpbmUgU1lTX1ZTVENSX0VMMiBzeXNfcmVnKDMsIDQsIDIsIDYsIDIp Cj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+PiArI2RlZmluZSBTWVNfQ05USFZTX1RWQUxfRUwyIHN5 c19yZWcoMywgNCwgMTQsIDQsIDApCj4gPj4gKyNkZWZpbmUgU1lTX0NOVEhWU19DVExfRUwyIHN5 c19yZWcoMywgNCwgMTQsIDQsIDEpCj4gPj4gKyNkZWZpbmUgU1lTX0NOVEhWU19DVkFMX0VMMiBz eXNfcmVnKDMsIDQsIDE0LCA0LCAyKQo+ID4+ICsjZGVmaW5lIFNZU19DTlRIUFNfVFZBTF9FTDIg c3lzX3JlZygzLCA0LCAxNCwgNSwgMCkKPiA+PiArI2RlZmluZSBTWVNfQ05USFBTX0NUTF9FTDIg c3lzX3JlZygzLCA0LCAxNCwgNSwgMSkKPiA+PiArI2RlZmluZSBTWVNfQ05USFBTX0NWQUxfRUwy IHN5c19yZWcoMywgNCwgMTQsIDUsIDIpCj4gPiAKPiA+IFdoaWxlIHRoZSBzZWN1cmUgZGVmaW5p dGlvbnMgc2VlbSBjb3JyZWN0LCB3aGF0IGlzIHRoZSByYXRpb25hbGUKPiA+IGJlaGluZCB0aGVp ciBwcmVzZW5jZSBoZXJlPyBUaGV5IGNhbm5vdCBiZSB0cmFwcGVkIGZyb20gbm9uLXNlY3VyZSwK PiA+IGFuZCB0aGUgcHNldWRvY29kZSBpcyBwcmV0dHkgZXhwbGljaXQ6Cj4gPiAKPiA+IGlmICFJ c0N1cnJlbnRTZWN1cml0eVN0YXRlKFNTX1NlY3VyZSkgdGhlbgo+ID4gVU5ERUZJTkVEOwo+ID4g Cj4gPiBHaXZlbiB0aGF0LCB0aGV5IGNhbm5vdCBiZSB0cmFwcGVkLCBoYW5kbGVkIG9yIGFjY2Vz c2VkIGZyb20gYSBLVk0KPiA+IGd1ZXN0LCBhcyBMaW51eCBvbiBhcm02NCAqYWx3YXlzKiBydW5z IG5vbi1zZWN1cmUuCj4gPiAKPiAKPiBUaGFuayB5b3UgZm9yIGNsYXJpZnlpbmcuCj4gCj4gVGhv c2UgZGVmaW5pdGlvbnMgd2VyZSBuZWVkZWQgZm9yIHRoZSByZWZpbmVtZW50IG9uIHBhdGNoIDMg d2hpY2ggY2xlYXJseQo+IGRpZG7igJl0IGNvbnNpZGVyZWQgdGhhdCBzdGF0ZW1lbnQgYmVmb3Jl aGFuZC4KPiAKPiBZZXQsIHNob3VsZCB3ZSBrZWVwIHRoZW0gaGVyZSBzbyB0aGV5IGNvdWxkIGJl IHVzZWQ/CgpCdXQgdGhhdCdzIHRoZSB3aG9sZSBwb2ludDogdGhleSAqY2Fubm90KiBiZSB1c2Vk LiBZb3UgY2FuJ3QgdXNlIGEKc2VjdXJlIHN5c3RlbSByZWdpc3RlciBpbiBub24tc2VjdXJlLCBh bmQgd2UgKmFsd2F5cyogcnVuIGluCm5vbi1zZWN1cmUsIG5vIGlmcyBubyBidXRzLgoKSWYgYSBn dWVzdCBldmVyIHVzZXMgb25lIG9mIHRob3NlLCBpdCB3aWxsIGdldCBhbiBVTkRFRiBleGNlcHRp b24KZGlyZWN0bHksIHdpdGhvdXQgYW55IFNXIGludGVydmVudGlvbiwgYmVjYXVzZSB0aGF0J3Mg anVzdCBpbGxlZ2FsLgpLVk0gd2lsbCBuZXZlciBzZWUgaXQuCgpBcyBmYXIgYXMgTGludXggaXMg Y29uY2VybmVkLCB0aGlzIGlzIHB1cmVseSBkZWFkIGNvZGUuCgoJTS4KCi0tIApXaXRob3V0IGRl dmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==