From: Joachim Wiberg <troglobit@gmail.com>
To: Christian Stewart via buildroot <buildroot@buildroot.org>,
buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tian Yuanhao <tianyuanhao3@163.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Christian Stewart <christian@aperture.us>
Subject: Re: [Buildroot] [PATCH v2 2/2] package/podman: new package
Date: Wed, 17 May 2023 07:18:03 +0200 [thread overview]
Message-ID: <86h6sbtu2c.fsf@gmail.com> (raw)
In-Reply-To: <20230512002511.1356447-2-christian@aperture.us>
Hi,
even quicker review from minor things I noticed:
On Thu, May 11, 2023 at 17:25, Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> [snip]
> package/Config.in | 1 +
> package/podman/Config.in | 55 +++++++++++++++++++
> package/podman/containers-policy.json | 14 +++++
> package/podman/podman.hash | 3 ++
> package/podman/podman.mk | 77 +++++++++++++++++++++++++++
You forgot to update the DEVELOPERS file with your new package.
> [snip]
> diff --git a/package/podman/Config.in b/package/podman/Config.in
> new file mode 100644
> index 0000000000..f23435621a
> --- /dev/null
> +++ b/package/podman/Config.in
> @@ -0,0 +1,55 @@
> +config BR2_PACKAGE_PODMAN
> + bool "podman"
> + depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> + depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
> + depends on BR2_USE_MMU # libgpgme
> + select BR2_PACKAGE_CATATONIT
Noob question, is CATATONIT really a dependency? I thought it was only
needed/recommended when composing a new container.
> + select BR2_PACKAGE_CNI_PLUGINS
> + select BR2_PACKAGE_CONMON
> + select BR2_PACKAGE_CNI_PLUGINS
Duplicate
> + select BR2_PACKAGE_CRUN
> + select BR2_PACKAGE_IPTABLES
Not sure, but for container networking we also need BRIDGE_UTILS, right?
> + select BR2_PACKAGE_LIBGPGME
For rootless support, isn't SHADOW + SHADOW_SUBORDINATE_IDS and
SLIRP4NETNS required?
CGROUPFS_MOUNT is probably needed for non-systemd builds.
CA_CERTIFICATES is needed for https pull.
Best regards
/Joachim
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-05-17 5:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 0:25 [Buildroot] [PATCH v2 1/2] package/conmon: new package Christian Stewart via buildroot
2023-05-12 0:25 ` [Buildroot] [PATCH v2 2/2] package/podman: " Christian Stewart via buildroot
2023-05-17 5:18 ` Joachim Wiberg [this message]
2023-05-22 20:17 ` Christian Stewart via buildroot
2023-05-17 5:08 ` [Buildroot] [PATCH v2 1/2] package/conmon: " Joachim Wiberg
2023-05-21 15:50 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6sbtu2c.fsf@gmail.com \
--to=troglobit@gmail.com \
--cc=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=thomas.petazzoni@bootlin.com \
--cc=tianyuanhao3@163.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.