From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3981339A4 for ; Tue, 14 Apr 2026 14:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178352; cv=none; b=Z0kcANcns40fpmwf1mlCnCYfurxMzQageeyrF5InYH94gYiTBmuO6VPlGmSvxhtI7zmbT0PoIIBdK450l+kd//bU4ttJ00gieu3bvbIidHXmX3ErZXyyYsvvEZNWV9z1pR+M/LIOiiSWWq4vTXIhXI3caMlZvIa3MBPX4lJ5cmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178352; c=relaxed/simple; bh=5bQ2lHVEbUt1BbmpoYLYzkIihN+c2/TvvPh6i/WsRss=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=PoBgNG9WpoIVh8kzWZpjfbyyvUxM1e50y+8LjUAYYSdDZVzb+mv/1keX7GVk393XoMWcyatlX9gufWWfieujUbv5RY5rJxuFTZWsYyOPa3FeqZS1ahQy38E1bwX1N8g7IEJ0IMajy/qdq2WFrcLBXPTB2hDlVwLhVWpoYKdBoVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lN9MxfEQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lN9MxfEQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B96E0C19425; Tue, 14 Apr 2026 14:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776178351; bh=5bQ2lHVEbUt1BbmpoYLYzkIihN+c2/TvvPh6i/WsRss=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lN9MxfEQYQZjnYDLumSvHszeXtdk7K/FCPHAcHUC3Rq8vBripPpT2YKSjVIbRAUE0 l0nqm8USYO8dcqev/v5ES6GrsiyxubUNd3Qutw+H934GyrAHZaGBUMyORbGGz2G/Na cqcfvT/+HPB1Eqk3Ajzi/DMtxqdKCZ+AwBje9ec5ZkqKnfkZ3mjXDdnujWr+Xcorw4 i93cZs+4EMRBLPTKYKgwUjCf4RgUcRnPWO2BPETG56kl3eSLWJ6RpwTYfu6CqMTJ1L X+L3OZD8FMyHP4ZVo3b+D+ARjCpsi52HxQP8nKSC+i8jYlLgJ96PcY+G/y1DrQegUm x35w32OJLH+JQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCf7t-0000000Bbzt-1riT; Tue, 14 Apr 2026 14:52:29 +0000 Date: Tue, 14 Apr 2026 15:52:29 +0100 Message-ID: <86ik9t387m.wl-maz@kernel.org> From: Marc Zyngier To: Vincent Donnefort Cc: oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE In-Reply-To: <20260414100231.1859687-1-vdonnefort@google.com> References: <20260414100231.1859687-1-vdonnefort@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vdonnefort@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 14 Apr 2026 11:02:31 +0100, Vincent Donnefort wrote: > > The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp > tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them. > > Signed-off-by: Vincent Donnefort > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index 37414440cee7..11dcdf434971 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -72,6 +72,14 @@ enum __kvm_host_smccc_func { > __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_range, > __KVM_HOST_SMCCC_FUNC___kvm_flush_cpu_context, > __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff, > + __KVM_HOST_SMCCC_FUNC___tracing_load, > + __KVM_HOST_SMCCC_FUNC___tracing_unload, > + __KVM_HOST_SMCCC_FUNC___tracing_enable, > + __KVM_HOST_SMCCC_FUNC___tracing_swap_reader, > + __KVM_HOST_SMCCC_FUNC___tracing_update_clock, > + __KVM_HOST_SMCCC_FUNC___tracing_reset, > + __KVM_HOST_SMCCC_FUNC___tracing_enable_event, > + __KVM_HOST_SMCCC_FUNC___tracing_write_event, > __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs, > __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_vmcr_aprs, > __KVM_HOST_SMCCC_FUNC___vgic_v5_save_apr, > @@ -100,14 +108,6 @@ enum __kvm_host_smccc_func { > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_load, > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_put, > __KVM_HOST_SMCCC_FUNC___pkvm_tlb_flush_vmid, > - __KVM_HOST_SMCCC_FUNC___tracing_load, > - __KVM_HOST_SMCCC_FUNC___tracing_unload, > - __KVM_HOST_SMCCC_FUNC___tracing_enable, > - __KVM_HOST_SMCCC_FUNC___tracing_swap_reader, > - __KVM_HOST_SMCCC_FUNC___tracing_update_clock, > - __KVM_HOST_SMCCC_FUNC___tracing_reset, > - __KVM_HOST_SMCCC_FUNC___tracing_enable_event, > - __KVM_HOST_SMCCC_FUNC___tracing_write_event, > }; > > #define DECLARE_KVM_VHE_SYM(sym) extern char sym[] > diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > index 73f2e0221e70..8f7582d57ab5 100644 > --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c > +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > @@ -709,6 +709,14 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__kvm_tlb_flush_vmid_range), > HANDLE_FUNC(__kvm_flush_cpu_context), > HANDLE_FUNC(__kvm_timer_set_cntvoff), > + HANDLE_FUNC(__tracing_load), > + HANDLE_FUNC(__tracing_unload), > + HANDLE_FUNC(__tracing_enable), > + HANDLE_FUNC(__tracing_swap_reader), > + HANDLE_FUNC(__tracing_update_clock), > + HANDLE_FUNC(__tracing_reset), > + HANDLE_FUNC(__tracing_enable_event), > + HANDLE_FUNC(__tracing_write_event), > HANDLE_FUNC(__vgic_v3_save_aprs), > HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs), > HANDLE_FUNC(__vgic_v5_save_apr), > @@ -735,14 +743,6 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__pkvm_vcpu_load), > HANDLE_FUNC(__pkvm_vcpu_put), > HANDLE_FUNC(__pkvm_tlb_flush_vmid), > - HANDLE_FUNC(__tracing_load), > - HANDLE_FUNC(__tracing_unload), > - HANDLE_FUNC(__tracing_enable), > - HANDLE_FUNC(__tracing_swap_reader), > - HANDLE_FUNC(__tracing_update_clock), > - HANDLE_FUNC(__tracing_reset), > - HANDLE_FUNC(__tracing_enable_event), > - HANDLE_FUNC(__tracing_write_event), > }; Why isn't it sufficient to reorder the enum? Thanks, M. -- Without deviation from the norm, progress is not possible.