From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9456B289340 for ; Thu, 10 Jul 2025 08:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752135018; cv=none; b=M+MZzRM2iGemmUkqkSRRN4wgmwnWlHDBUHGfOwn1OMBw56VUouNgPuMQ78LKbxr2/Z3EP/YGkPCT0lXfYnCSIi6W+s4ih8KJ1dF9a/n2tpiP16+wOpoOlIK2qTMSL+1xQ56Gi4bExX4U15PpU+2csW2pbUh7vLaFxgiqORHxEkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752135018; c=relaxed/simple; bh=hNiCLR/9Bi1BlmUfdE7rYZFbDwUrR2MgeU/x77j9E/E=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=aFmKVkopu+8J4kZCduibPavBVkMeyq3GK6xTJLI+bag7SNgefORktnjy8WTy65mOUl9ru4WsM/b3Q/AVwh+nmtgT/U5OhYMjG2tVqv0lpQ/7a2E0FX8EOeR46LygQfWrePmAAZxvsMZZzWwtEoJzFA+aFT1MT0NYA7D/R1TFMtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fcJULciX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fcJULciX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17AA3C4CEE3; Thu, 10 Jul 2025 08:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752135018; bh=hNiCLR/9Bi1BlmUfdE7rYZFbDwUrR2MgeU/x77j9E/E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fcJULciXT3toou1HazHEtjMCYG5kGpdICpbwfRVJ9RTvJ3LaiEXQcqHXZ/bJDJ4hO qy6dULTVKv8ef0amzGbybb0BAdxFgqk3CB5NaAZyf1UWmzlRg9FsIYNocTUc9rJafS 3P4ZrJpQK7DiGdb35vm3dETYjOL2WBCzhgNbySqLtrxfjnj5xYv5aDS4/wrdFbfDcv wol2OYGmtXiT4PVwR+tNYTRLT8GxxeJ5944EMbm9CNc6Ehue6hjhCfllNZJRhSYzQl FOYMnRV+cZttKIzul0ghx0J2VVYGoTCpRwXGu0rWblRMWJvyltEfngyxDdyr/hARp7 82gap/iOJb2cw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uZmMB-00EQed-MP; Thu, 10 Jul 2025 09:10:15 +0100 Date: Thu, 10 Jul 2025 09:10:15 +0100 Message-ID: <86ikk0a2l4.wl-maz@kernel.org> From: Marc Zyngier To: Arnd Bergmann Cc: Thomas Gleixner , Arnd Bergmann , Anna-Maria Behnsen , Shivamurthy Shastri , linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: irq-msi-lib: fix build with PCI disabled In-Reply-To: <20250710080021.2303640-1-arnd@kernel.org> References: <20250710080021.2303640-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: arnd@kernel.org, tglx@linutronix.de, arnd@arndb.de, anna-maria@linutronix.de, shivamurthy.shastri@linutronix.de, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 10 Jul 2025 09:00:12 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > The armada-370-xp irqchip fails in some randconfig builds because > of a missing declaration: > > In file included from drivers/irqchip/irq-armada-370-xp.c:23: > include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > Add a forward declaration for the msi_domain_info structure. > > Fixes: e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available") > Signed-off-by: Arnd Bergmann > --- > include/linux/irqchip/irq-msi-lib.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/irqchip/irq-msi-lib.h b/include/linux/irqchip/irq-msi-lib.h > index dd8d1d138544..224ac28e88d7 100644 > --- a/include/linux/irqchip/irq-msi-lib.h > +++ b/include/linux/irqchip/irq-msi-lib.h > @@ -17,6 +17,7 @@ > > #define MATCH_PLATFORM_MSI BIT(DOMAIN_BUS_PLATFORM_MSI) > > +struct msi_domain_info; > int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec, > enum irq_domain_bus_token bus_token); > Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.