From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 754F3E7B5E5 for ; Wed, 4 Oct 2023 10:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=89NiKDqzKQArB4mto89YqZYWGW9ri1F4jaYUJfw+cwU=; b=kinENBVpRGi4xD J2GZJcYp/9irwHkuSIfaG5PHYEvOU3l63ZLiCm2tBuVpOE/YqaW4NcHYrWq9BQAqzha3bzwUGPWxO pPEy4BMc/huQnrueGP8U+u/zlif9KuCcYEWvSRbh9DjHo9EQ99lyH2tOQTur5z1vT7wOmkK4/PXTm alI8/Dg+91Low1EBgBYjK9BCPcR4D/0hFc0dw6lZcaq7drwjWDGP5faHTtfNYi/qsDJ//pUuw5IXz 9WCigA3H9f9/3uYRE1nH7WDrWoaLoRb5Mr/pVnS2xGk12KIiEc3QAmhBy49LmOUnYZZocBEf4ASjs FofrZ6O9o8ECpohRuBsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnyxN-00HEqd-2G; Wed, 04 Oct 2023 10:18:17 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnyxJ-00HEnL-37 for linux-riscv@lists.infradead.org; Wed, 04 Oct 2023 10:18:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 64BB2B81D09; Wed, 4 Oct 2023 10:18:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD9FC433C7; Wed, 4 Oct 2023 10:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696414691; bh=zgBcifi1XWcmTTAkPgJMMB7DWNo/I8zGzCMzHMTkoRc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PbWcIAYMkiDYXvKTy/GcFQJLRpFGZMJceaBYbf/lbOCou/Y3UCR7QtAllmB1kZvZi C8GNw9wwYGSWToJoj81qf/hOBDRTY7y/wf4AjTl28h7U2s0pO174/tIHN9GJKvf17o F36MFMgdayGluDL8bfUw0L146+t3sUlmRLRlydpcrPY2JdTlftM0gP+lPgAD/nY/R9 reU5aalmfkgv/P/TUX/H9XtDbWd9aTPTiq9aB9JIEc+0539u9fEm2o+zPvfyuz70Ms cKMA3LMO8TYwu/iZdhoQhmU+YTgfuxW+KV/KYNUD20UCRmwo32M/2xQ/vV8aVXM3Cq pWfSvBAZK5lNQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qnyxF-00112H-BP; Wed, 04 Oct 2023 11:18:09 +0100 Date: Wed, 04 Oct 2023 11:18:09 +0100 Message-ID: <86il7mofmm.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Dmitry Dunaev , dunaich@mail.ru, Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized. In-Reply-To: References: <20230926102801.1591126-1-dunaev@tecon.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, dunaev@tecon.ru, dunaich@mail.ru, tglx@linutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_031814_270410_DA06A86F X-CRM114-Status: GOOD ( 29.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNiBTZXAgMjAyMyAxMTozNjozMSArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFR1ZSwgU2VwIDI2LCAyMDIzIGF0IDM6NTni gK9QTSBEbWl0cnkgRHVuYWV2IDxkdW5hZXZAdGVjb24ucnU+IHdyb3RlOgo+ID4KPiA+IFRoZSBj dXJyZW50IExpbnV4IGRyaXZlciBpcnEtcmlzY3YtaW50YyBpbml0aWFsaXplIElSUSBkb21haW4g b25seSBvbmNlLAo+ID4gd2hlbiBpbml0IGZ1bmN0aW9uIGNhbGxlZCBvbiBwcmltYXJ5IGhhcnQu IEluIG90aGVyIGNhc2VzIG5vIElSUSBkb21haW4gaXMKPiA+IGNyZWF0ZWQgYW5kIG5vIG9wZXJh dGlvbiBvbiBpbnRlcnJ1cHQtY29udHJvbGxlciBub2RlIGlzIHBlcmZvcm1lZC4KPiA+IFRoaXMg aXMgY2F1c2Ugb2YgdGhhdCBubyBjb21tb24gTGludXggZHJpdmVyIGNhbiB1c2UgcGVyLWNwdSBp bnRlcnJ1cHRzCj4gPiBtYXBwZWQgdG8gc2V2ZXJhbCBDUFVzIGJlY2F1c2UgZndub2RlIG9mIHNl Y29uZGFyeSBjb3JlcyBJTlRDIGlzIG5vdAo+ID4gbWFya2VkIGFzIGluaXRpYWxpemVkLiBUaGlz IGRldmljZSBpcyBhbHdheXMgd2lsbCBiZSBtYXJrZWQgYXMgZGVmZXJyZWQuCj4gPiBGb3IgZXhh bXBsZSB0aGUgc3lzdGVtIHdpdGggZGV2aWNldHJlZQo+ID4KPiA+ICAgICBjcHUwOiBjcHVAMCB7 Cj4gPiAgICAgICAgIGNwdTBfaW50YzogaW50ZXJydXB0LWNvbnRyb2xsZXIgewo+ID4gICAgICAg ICAgICAgaW50ZXJydXB0LWNvbnRyb2xsZXI7Cj4gPiAgICAgICAgICAgICBjb21wYXRpYmxlID0g cmlzY3YsY3B1LWludGM7Cj4gPiAgICAgICAgIH07Cj4gPiAgICAgfTsKPiA+Cj4gPiAgICAgY3B1 MTogY3B1QDEgewo+ID4gICAgICAgICBjcHUxX2ludGM6IGludGVycnVwdC1jb250cm9sbGVyIHsK PiA+ICAgICAgICAgICAgIGludGVycnVwdC1jb250cm9sbGVyOwo+ID4gICAgICAgICAgICAgY29t cGF0aWJsZSA9IHJpc2N2LGNwdS1pbnRjOwo+ID4gICAgICAgICB9Owo+ID4gICAgIH07Cj4gPgo+ ID4gICAgIGJ1c2VyciB7Cj4gPiAgICAgICAgIGNvbXBhdGlibGUgPSByaXNjdixidXNlcnI7Cj4g PiAgICAgICAgIGludGVycnVwdHMtZXh0ZW5kZWQgPSA8JmNwdTBfaW50YyAxNiAmY3B1MV9pbnRj IDE2PjsKPiA+ICAgICB9Owo+ID4KPiA+IHdpbGwgYWx3YXlzIHJlcG9ydCAnYnVzZXJyJyBub2Rl IGFzIGRlZmVycmVkIHdpdGhvdXQgY2FsbGluZyBhbnkKPiA+IGJ1cyBwcm9iZSBmdW5jdGlvbi4K PiA+Cj4gPiBUaGlzIHBhdGNoIHdpbGwgbWFyayBhbGwgc2Vjb25kYXJ5IG5vZGVzIHBhc3NlZCB0 byBpcnEtcmlzY3YtaW50Ywo+ID4gZHJpdmVyIGluaXQgZnVuY3Rpb24gYXMgaW5pdGlhbGl6ZWQg dG8gYmUgYWJsZSB0byBhY3QgYXMgY29ycmVjdAo+ID4gSVJRIHBoYW5kbGUgbm9kZS4KPiA+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgRHVuYWV2IDxkdW5hZXZAdGVjb24ucnU+Cj4gPiAtLS0K PiA+ICBkcml2ZXJzL2lycWNoaXAvaXJxLXJpc2N2LWludGMuYyB8IDggKysrKysrLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2lycWNoaXAvaXJxLXJpc2N2LWludGMuYyBiL2RyaXZlcnMvaXJx Y2hpcC9pcnEtcmlzY3YtaW50Yy5jCj4gPiBpbmRleCA0YWRlZWUxYmMzOTEuLmMwMWE0ZThkNDk4 MyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtcmlzY3YtaW50Yy5jCj4gPiAr KysgYi9kcml2ZXJzL2lycWNoaXAvaXJxLXJpc2N2LWludGMuYwo+ID4gQEAgLTE1NSw4ICsxNTUs MTAgQEAgc3RhdGljIGludCBfX2luaXQgcmlzY3ZfaW50Y19pbml0KHN0cnVjdCBkZXZpY2Vfbm9k ZSAqbm9kZSwKPiA+ICAgICAgICAgICogZm9yIGVhY2ggSU5UQyBEVCBub2RlLiBXZSBvbmx5IG5l ZWQgdG8gZG8gSU5UQyBpbml0aWFsaXphdGlvbgo+ID4gICAgICAgICAgKiBmb3IgdGhlIElOVEMg RFQgbm9kZSBiZWxvbmdpbmcgdG8gYm9vdCBDUFUgKG9yIGJvb3QgSEFSVCkuCj4gPiAgICAgICAg ICAqLwo+ID4gLSAgICAgICBpZiAocmlzY3ZfaGFydGlkX3RvX2NwdWlkKGhhcnRpZCkgIT0gc21w X3Byb2Nlc3Nvcl9pZCgpKQo+ID4gKyAgICAgICBpZiAocmlzY3ZfaGFydGlkX3RvX2NwdWlkKGhh cnRpZCkgIT0gc21wX3Byb2Nlc3Nvcl9pZCgpKSB7Cj4gPiArICAgICAgICAgICAgICAgZndub2Rl X2Rldl9pbml0aWFsaXplZChvZl9ub2RlX3RvX2Z3bm9kZShub2RlKSwgdHJ1ZSk7Cj4gCj4gVGhl cmUgaXMgYWxyZWFkeSBhIHBhdGNoIG9uIExLTUwgdG8gYWRkcmVzcyB0aGlzLgo+IGh0dHBzOi8v d3d3LnNwaW5pY3MubmV0L2xpc3RzL2tlcm5lbC9tc2c0OTI5ODg2Lmh0bWwKCklmIHRoaXMgaXMg YSBmaXgsIHdoeSBpcyBpdCBidXJpZWQgaW4gYSBodWdlIHNlcmllcyBhbmQgbm90IGJyb3VnaHQK Zm9yd2FyZCBhcyBhbiBpbmRlcGVuZGVudCBmaXggdGhhdCBuZWVkcyB0byBiZSBwaWNrZWQgZWFy bHk/CgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBp cyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541E5E7B5E5 for ; Wed, 4 Oct 2023 10:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233184AbjJDKcd (ORCPT ); Wed, 4 Oct 2023 06:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242149AbjJDKSQ (ORCPT ); Wed, 4 Oct 2023 06:18:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED29AF for ; Wed, 4 Oct 2023 03:18:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD9FC433C7; Wed, 4 Oct 2023 10:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696414691; bh=zgBcifi1XWcmTTAkPgJMMB7DWNo/I8zGzCMzHMTkoRc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PbWcIAYMkiDYXvKTy/GcFQJLRpFGZMJceaBYbf/lbOCou/Y3UCR7QtAllmB1kZvZi C8GNw9wwYGSWToJoj81qf/hOBDRTY7y/wf4AjTl28h7U2s0pO174/tIHN9GJKvf17o F36MFMgdayGluDL8bfUw0L146+t3sUlmRLRlydpcrPY2JdTlftM0gP+lPgAD/nY/R9 reU5aalmfkgv/P/TUX/H9XtDbWd9aTPTiq9aB9JIEc+0539u9fEm2o+zPvfyuz70Ms cKMA3LMO8TYwu/iZdhoQhmU+YTgfuxW+KV/KYNUD20UCRmwo32M/2xQ/vV8aVXM3Cq pWfSvBAZK5lNQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qnyxF-00112H-BP; Wed, 04 Oct 2023 11:18:09 +0100 Date: Wed, 04 Oct 2023 11:18:09 +0100 Message-ID: <86il7mofmm.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Dmitry Dunaev , dunaich@mail.ru, Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] irqchip/riscv-intc: Mark INTC nodes for secondary CPUs as initialized. In-Reply-To: References: <20230926102801.1591126-1-dunaev@tecon.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, dunaev@tecon.ru, dunaich@mail.ru, tglx@linutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Sep 2023 11:36:31 +0100, Anup Patel wrote: >=20 > On Tue, Sep 26, 2023 at 3:59=E2=80=AFPM Dmitry Dunaev w= rote: > > > > The current Linux driver irq-riscv-intc initialize IRQ domain only once, > > when init function called on primary hart. In other cases no IRQ domain= is > > created and no operation on interrupt-controller node is performed. > > This is cause of that no common Linux driver can use per-cpu interrupts > > mapped to several CPUs because fwnode of secondary cores INTC is not > > marked as initialized. This device is always will be marked as deferred. > > For example the system with devicetree > > > > cpu0: cpu@0 { > > cpu0_intc: interrupt-controller { > > interrupt-controller; > > compatible =3D riscv,cpu-intc; > > }; > > }; > > > > cpu1: cpu@1 { > > cpu1_intc: interrupt-controller { > > interrupt-controller; > > compatible =3D riscv,cpu-intc; > > }; > > }; > > > > buserr { > > compatible =3D riscv,buserr; > > interrupts-extended =3D <&cpu0_intc 16 &cpu1_intc 16>; > > }; > > > > will always report 'buserr' node as deferred without calling any > > bus probe function. > > > > This patch will mark all secondary nodes passed to irq-riscv-intc > > driver init function as initialized to be able to act as correct > > IRQ phandle node. > > > > Signed-off-by: Dmitry Dunaev > > --- > > drivers/irqchip/irq-riscv-intc.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-ris= cv-intc.c > > index 4adeee1bc391..c01a4e8d4983 100644 > > --- a/drivers/irqchip/irq-riscv-intc.c > > +++ b/drivers/irqchip/irq-riscv-intc.c > > @@ -155,8 +155,10 @@ static int __init riscv_intc_init(struct device_no= de *node, > > * for each INTC DT node. We only need to do INTC initialization > > * for the INTC DT node belonging to boot CPU (or boot HART). > > */ > > - if (riscv_hartid_to_cpuid(hartid) !=3D smp_processor_id()) > > + if (riscv_hartid_to_cpuid(hartid) !=3D smp_processor_id()) { > > + fwnode_dev_initialized(of_node_to_fwnode(node), true); >=20 > There is already a patch on LKML to address this. > https://www.spinics.net/lists/kernel/msg4929886.html If this is a fix, why is it buried in a huge series and not brought forward as an independent fix that needs to be picked early? M. --=20 Without deviation from the norm, progress is not possible.