From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14B45CBC for ; Tue, 11 Jul 2023 07:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BC6C433C7; Tue, 11 Jul 2023 07:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689060444; bh=dg3uI16o/xr6hbyyKCfpUYdVkNKqguRHuKxyHGNZXmw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i2vZKsGiUJbo7RtmXQvlvSc2r54mZne4cir+y92QS8A3vDWxoTYeIQOIZ6P2+wGRn QCIueNZC025fJppOiXPTKgL6gD/RLSRCrj9wATvIE9kxVPTc5nLhQ/pxphvSm7159z XaTr6eqZZSbF1SA2XaO90pRkNsdSv4bigBEnBt/yiffaAJMe3wRxrMRRxHBY7mswd8 wQcodlYUQxDSdlqiMnWnZhulOaC+zJJoBAqQ97RoNiPJWno/U9Z+AGVinzcVGPlBL+ A/K9EzcSlCAWR/xChxpCpnGiIfReiqT37i3brzs3mmdnbwHQCfs54ocXPMrNiU3DsL 60qweGTxg4pXA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qJ7mM-00C2VP-A1; Tue, 11 Jul 2023 08:27:22 +0100 Date: Tue, 11 Jul 2023 08:27:22 +0100 Message-ID: <86ilaqx605.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v2 0/4] KVM: arm64: Use 'generic' vCPU target across all uarches In-Reply-To: <20230710193140.1706399-1-oliver.upton@linux.dev> References: <20230710193140.1706399-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 10 Jul 2023 20:31:36 +0100, Oliver Upton wrote: > > kvm_vcpu_init::target is quite useless at this point. We don't do any > uarch-specific emulation in the first place, and require userspace > select the 'generic' vCPU target on all but a few implementations. > > Small series to (1) clean up usage of the target value in the kernel and > (2) switch to the 'generic' target on implementations that previously > had their own target values. The implementation-specific values are > still tolerated, though, to avoid UAPI breakage. > > v1: https://lore.kernel.org/kvmarm/20230623194258.2648987-1-oliver.upton@linux.dev/ > > v1 -> v2: > - Set the generic v8 target in the kvm_vcpu_init struct initializer > (Marc) > - Use the kvm_vcpu_initialized() helper (Zenghui) > - Collect Zenghui's ack/reviews (Thanks!) > > Oliver Upton (4): > KVM: arm64: Delete pointless switch statement in kvm_reset_vcpu() > KVM: arm64: Remove pointless check for changed init target > KVM: arm64: Replace vCPU target with a configuration flag > KVM: arm64: Always return generic v8 as the preferred target > > arch/arm64/include/asm/kvm_host.h | 6 +++--- > arch/arm64/kvm/arm.c | 24 +++++++++++------------- > arch/arm64/kvm/guest.c | 15 --------------- > arch/arm64/kvm/hyp/nvhe/switch.c | 2 +- > arch/arm64/kvm/reset.c | 25 ++++++++++--------------- > 5 files changed, 25 insertions(+), 47 deletions(-) > > > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 Looks great to me. This is 6.6 material, right? If so, I'll earmark it as such. Thanks, M. -- Without deviation from the norm, progress is not possible.