Re: [PATCH kvmtool 1/1] riscv: pci: Add --force-pci option for riscv VMs.

[Marc Zyngier <maz@kernel.org>]

On Thu, 19 Jan 2023 18:16:15 +0000,
Will Deacon <will@kernel.org> wrote:
> 
> On Thu, Jan 19, 2023 at 01:39:32PM +0000, Alexandru Elisei wrote:
> > Hi,
> > 
> > CC'ing the kvmtool maintainers and other people that might be interested in this
> > thread. Sorry for hijacking your patch!
> > 
> > On Wed, Jan 18, 2023 at 05:20:07PM +0000, Rajnesh Kanwal wrote:
> > > Adding force-pci option to allow forcing virtio
> > > devices to use pci as the default transport.
> > 
> > arm is in the same situation, MMIO is the default virtio transport. I was bitten
> > by that in the past. It also cought other people unaware, and I remember maz
> > complaining about it on the list.
> > 
> > So I was thinking about adding a new command line parameter, --virtio-transport,
> > with the possible values mmio-legacy, mmio, pci-legacy and pci. Then each
> > architecture can define the default value for the transport. For arm, that would
> > be pci.
> > 
> > What do you guys think?
> 
> That sounds good to me. Then we can remove --force-pci altogether and maybe
> have PCI as the default for everybody? Should make the tool a little easier
> to use across architectures.

I'd rather keep --force-pci in order no to break existing scripting.
It just won't do anything once we make PCI the default (which we
definitely should).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.