From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CE1C004D4 for ; Sat, 21 Jan 2023 12:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbjAUMS6 (ORCPT ); Sat, 21 Jan 2023 07:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjAUMS5 (ORCPT ); Sat, 21 Jan 2023 07:18:57 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2AD14B4A8 for ; Sat, 21 Jan 2023 04:18:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 569B7B8077D for ; Sat, 21 Jan 2023 12:18:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1D19C433D2; Sat, 21 Jan 2023 12:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674303534; bh=rMaMi8Q82h99m/w7B389xf0EUF3m0I/O2EU9rORRLe0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ohFbracxy9aIEtDW3hAI2XZON/WJEyMAdI7XXqGMLlqkUp4LHs+T8rMKaxz1GMyI/ XvS8I3pGa+3dTtGdzF1Otty/hK+TPP0eRH3RlA3bwFHHu0thVbVG5UEWEvfLSuBgKL J4TUSpacQI185zMKp9YOHqsm1cHw8ABfVkYtNcZgwFFmP7BceBrk9JYFpAJ7+3ISe3 jIirNNuwE/w1brRuk54LPNXoK/0BK7SWp486EMIi2lr20tww1XEAgnwgxZzfhYFnaK X8mj4fwpMl4gFSZ/lXMnSe4Dq6q6u/nY2df4NVv1iKnXmCUdACscE+vwXeY/D7WKRh zQQqrlH52x6Xg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJCpf-003dCi-F5; Sat, 21 Jan 2023 12:18:51 +0000 Date: Sat, 21 Jan 2023 12:18:51 +0000 Message-ID: <86ilh0m66s.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: Alexandru Elisei , Rajnesh Kanwal , apatel@ventanamicro.com, atishp@rivosinc.com, kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, andre.przywara@arm.com Subject: Re: [PATCH kvmtool 1/1] riscv: pci: Add --force-pci option for riscv VMs. In-Reply-To: <20230119181615.GB20563@willie-the-truck> References: <20230118172007.408667-1-rkanwal@rivosinc.com> <20230119181615.GB20563@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, alexandru.elisei@arm.com, rkanwal@rivosinc.com, apatel@ventanamicro.com, atishp@rivosinc.com, kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, andre.przywara@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 19 Jan 2023 18:16:15 +0000, Will Deacon wrote: > > On Thu, Jan 19, 2023 at 01:39:32PM +0000, Alexandru Elisei wrote: > > Hi, > > > > CC'ing the kvmtool maintainers and other people that might be interested in this > > thread. Sorry for hijacking your patch! > > > > On Wed, Jan 18, 2023 at 05:20:07PM +0000, Rajnesh Kanwal wrote: > > > Adding force-pci option to allow forcing virtio > > > devices to use pci as the default transport. > > > > arm is in the same situation, MMIO is the default virtio transport. I was bitten > > by that in the past. It also cought other people unaware, and I remember maz > > complaining about it on the list. > > > > So I was thinking about adding a new command line parameter, --virtio-transport, > > with the possible values mmio-legacy, mmio, pci-legacy and pci. Then each > > architecture can define the default value for the transport. For arm, that would > > be pci. > > > > What do you guys think? > > That sounds good to me. Then we can remove --force-pci altogether and maybe > have PCI as the default for everybody? Should make the tool a little easier > to use across architectures. I'd rather keep --force-pci in order no to break existing scripting. It just won't do anything once we make PCI the default (which we definitely should). Thanks, M. -- Without deviation from the norm, progress is not possible.