From: Marc Zyngier <maz@kernel.org>
To: Haofeng Li <920484857@qq.com>
Cc: tglx@kernel.org, linux-kernel@vger.kernel.org,
Haofeng Li <13266079573@163.com>,
Haofeng Li <lihaofeng@kylinos.cn>,
Sudeep Holla <sudeep.holla@kernel.org>,
Vikram Sethi <vsethi@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/16] irqchip/gic-v3: fail T241 quirk if alias ioremap fails
Date: Tue, 14 Jul 2026 15:53:34 +0100 [thread overview]
Message-ID: <86jyqxoc5t.wl-maz@kernel.org> (raw)
In-Reply-To: <tencent_92BBEC9E50E005DB0B52D2C055EF9EEC5506@qq.com>
On Tue, 14 Jul 2026 14:24:51 +0100,
Haofeng Li <920484857@qq.com> wrote:
>
> From: Haofeng Li <lihaofeng@kylinos.cn>
>
> NVIDIA T241 GICD alias setup only warns about a failed ioremap, then
> enables gic_nvidia_t241_erratum. Later accesses through the missing
> alias can dereference NULL.
There won't be any later accesses, the machine is *dead*, short of
reliably handle interrupts. The only thing this patch is doing is
giving a false sense of having fixed something, while it is far worse
than the existing situation.
Please tell that to your LLM.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2026-07-14 14:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:23 [PATCH 00/16] irqchip: harden initialization error paths Haofeng Li
2026-07-14 12:23 ` Haofeng Li
2026-07-14 12:23 ` [PATCH 01/16] irqchip/riscv-imsic: fix MMIO lookup OOB and NULL cleanup Haofeng Li
2026-07-14 12:23 ` Haofeng Li
2026-07-14 13:15 ` Anup Patel
2026-07-14 13:15 ` Anup Patel
2026-07-14 12:23 ` [PATCH 02/16] irqchip/loongarch-ir: fix redirect free and alloc leaks Haofeng Li
2026-07-14 13:24 ` [PATCH 03/16] irqchip/sifive-plic: do not iounmap devm mappings Haofeng Li
2026-07-14 13:24 ` Haofeng Li
2026-07-14 15:05 ` Anup Patel
2026-07-14 15:05 ` Anup Patel
[not found] ` <20260714132453.3302672-1-920484857@qq.com>
2026-07-14 13:24 ` [PATCH 04/16] irqchip/crossbar: fix allocation and init cleanup Haofeng Li
2026-07-14 13:24 ` [PATCH 05/16] irqchip/bcm7038-l1: clean up init failure paths Haofeng Li
2026-07-14 13:24 ` [PATCH 06/16] irqchip/loongson-liointc: unmap per-core iomaps on error Haofeng Li
2026-07-14 13:24 ` [PATCH 07/16] irqchip/mips-gic: clean up IRQ domain creation failure Haofeng Li
2026-07-14 13:24 ` [PATCH 08/16] irqchip/mips-gic: clean up if IPI domain registration fails Haofeng Li
2026-07-14 13:24 ` [PATCH 09/16] irqchip/econet: clean up VEIC initialization Haofeng Li
2026-07-14 13:24 ` [PATCH 10/16] irqchip/aspeed-vic: publish handler only after domain creation Haofeng Li
2026-07-14 13:24 ` [PATCH 11/16] irqchip/loongson-eiointc: preserve live state on cascade failure Haofeng Li
2026-07-14 13:24 ` [PATCH 12/16] irqchip/realtek-rtl: unmap per-CPU bases on init failure Haofeng Li
2026-07-14 13:24 ` [PATCH 13/16] irqchip/realtek-rtl: dispose parent mapping on domain failure Haofeng Li
2026-07-14 13:24 ` [PATCH 14/16] irqchip/renesas-rzg2l: fix wrong errno in reset error log Haofeng Li
2026-07-14 13:24 ` [PATCH 15/16] irqchip/gic-v3: fail T241 quirk if alias ioremap fails Haofeng Li
2026-07-14 14:53 ` Marc Zyngier [this message]
2026-07-14 13:24 ` [PATCH 16/16] irqchip/bcm7120-l2: fix parent IRQ count error handling Haofeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jyqxoc5t.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=13266079573@163.com \
--cc=920484857@qq.com \
--cc=lihaofeng@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=sudeep.holla@kernel.org \
--cc=tglx@kernel.org \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.