From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2986F1DE2C8 for ; Thu, 17 Oct 2024 13:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729172601; cv=none; b=fWXU/VRImBRI+Hantstm7tBDLEyaV6eL0fvX/7MIxzn88kusQ+cXIB7SGTf0hiWJ2RfEHXiZwPj8GAKOoz8mYBhVgN/9VSx1ejGy77HHqLE+Oi6rfMO0Vte+4d70/8WtQlI7tmfZouQQMNSxxqUJX49pKKefDD7M9z+8cuH6L00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729172601; c=relaxed/simple; bh=vGy/MFH2kmcnIumhn7RSlmUxkNblJEGrePq4xBLoSY0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Q1pfS6hCoRAPZHRyatCSpyDp3KCBKanbkuLsEjHkcUx24kHF6P5UP20Ih0U+ats+AoZMKO6Ukj29CAnxnyXzOOikis6sSOvjOr6PxV8GkM9Uus+H3vO+p1+me9zb5gugGKmufgUfu64Ij4irWcwiCvf155tv3khvCORDko1fH3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VlrZjrjS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VlrZjrjS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD304C4CEC3; Thu, 17 Oct 2024 13:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729172600; bh=vGy/MFH2kmcnIumhn7RSlmUxkNblJEGrePq4xBLoSY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VlrZjrjS1LPbSZ2Lsn2bzxOTwZpdshi9x6/3osNAeH1g9Y5gs3KBjrE8V4rZtyUVx DwHi3nTLpC/HTdQKXGR7f2fKSKERzHLtUnjaq20bCYLDDzseRthRw5IyTPKaWVgbsT nVsDMGURZ+LY+CzoRtbJVgP+dVuY0CJF7Q8hLNgV5wp16bhqe3cp38mD2gpgUyG8v1 OI6vSZQ/uJb8ScsU10APVSx0dK5Uv4bmmy6ERCHBylXMIbMc52SbFf0jW8k4iIRcfq vtQbhL5sx+LR18FcEjWPV8Ois6KT9rDNnMYPNcq/sBHoC80OqkolXROSWnvdgGhW3i tdtTuRsPMWYFQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t1Qmc-004T0Z-HC; Thu, 17 Oct 2024 14:43:18 +0100 Date: Thu, 17 Oct 2024 14:43:17 +0100 Message-ID: <86jze64zgq.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, anshuman.khandual@arm.com, james.morse@arm.com, Oliver Upton , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Shameerali Kolothum Thodi , Catalin Marinas , Will Deacon Subject: Re: [PATCH v5 4/7] KVM: arm64: Fix missing traps of guest accesses to the MPAM registers In-Reply-To: <20241015133923.3910916-5-joey.gouly@arm.com> References: <20241015133923.3910916-1-joey.gouly@arm.com> <20241015133923.3910916-5-joey.gouly@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, anshuman.khandual@arm.com, james.morse@arm.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, shameerali.kolothum.thodi@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 15 Oct 2024 14:39:20 +0100, Joey Gouly wrote: > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index dad88e31f953..c21840042785 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2517,8 +2517,11 @@ static const struct sys_reg_desc sys_reg_descs[] = { > { SYS_DESC(SYS_LOREA_EL1), trap_loregion }, > { SYS_DESC(SYS_LORN_EL1), trap_loregion }, > { SYS_DESC(SYS_LORC_EL1), trap_loregion }, > + { SYS_DESC(SYS_MPAMIDR_EL1), undef_access }, > { SYS_DESC(SYS_LORID_EL1), trap_loregion }, > > + { SYS_DESC(SYS_MPAM1_EL1), undef_access }, > + { SYS_DESC(SYS_MPAM0_EL1), undef_access }, > { SYS_DESC(SYS_VBAR_EL1), access_rw, reset_val, VBAR_EL1, 0 }, > { SYS_DESC(SYS_DISR_EL1), NULL, reset_val, DISR_EL1, 0 }, For completeness, can you please add the EL2 MPAM registers to that list, making them equally UNDEF? Thanks, M. -- Without deviation from the norm, progress is not possible.