From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D6315B130 for ; Wed, 24 Apr 2024 13:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713963738; cv=none; b=j7IVIrVLtLtudPuaUgTHKwEdRWOafI49eaviPtT8Tr0JzdrS5CuM50Qzkb04JQA57nUoBj0xWzbxU2dLhmBcdON7JGTEEKtr8uVVFYxYnvtCmS3pJhF7qRW+uNgnPHuUe1LU5O+gw49bsB3TJQh+l9DmZ3Li/oWPUqxhBIJKSJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713963738; c=relaxed/simple; bh=aUkWBZiRzbp30B4f9YNTL4xQHjBg31CcNj8PpSXCzKY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Zk/v+eJymEgoBTxZmQketszYEogW/CqsMNCiyknYeY8hdWTPOqktXCcjN/pJSEwJznqSwGJE8seHAbLwpHZXWPwlnaRV5/8Feh5yPeZyWDWIZQgdsCzcoID+rRFqHKoTpw5zcRncojbj82rUoAOP1afWIy+vd1Cw58143L1Qmmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p0U8kSkw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p0U8kSkw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E49C113CE; Wed, 24 Apr 2024 13:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713963738; bh=aUkWBZiRzbp30B4f9YNTL4xQHjBg31CcNj8PpSXCzKY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p0U8kSkwbH2uB6riNVb2A7IM8tkpXg6N5CY7SHzKeGFi+gRMGKAxEBVxEWBZ6Cuc6 kveUIxWP7HDfJUbBewy6TYcducuH2yMV0cfTnMUqAWulBDYtkpBf78NK4MEAL5/TAg tip5mZn+rTv663yN6Tg4MZAGknbgdT5xs2dGNZjjRKLRw8XR2Lo+JGI32H3MAWqgkh LCBICsm02fycnJjS5oxCAmGZoQfkmklYdIEdpsvePPCFt0eVGkEa8X8x3LSDVjnXfn FdLTf+rbOT4D1mI2cMnTW7rVeLz4yO56fuHFlzKJjbBx5SIwTUCMzu7YQ90O5s6J/T RrWNd8NnPU9Ig== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rzcGN-007XRB-PV; Wed, 24 Apr 2024 14:02:15 +0100 Date: Wed, 24 Apr 2024 14:02:14 +0100 Message-ID: <86jzkmrk15.wl-maz@kernel.org> From: Marc Zyngier To: Dan Carpenter Cc: kvmarm@lists.linux.dev Subject: Re: [bug report] KVM: arm64: nv: Handle ERETA[AB] instructions In-Reply-To: References: <87mspjt05u.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dan.carpenter@linaro.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 24 Apr 2024 13:47:11 +0100, Dan Carpenter wrote: > > Crud. I should have seen that. That's my bad. Certainly don't change > the code to silence the warning. > > The issue for Smatch is that it doesn't parse bitwise tests or pure > functions properly... I know *how* to fix it and it's not *complicated* > but it's quite a bit of code and I haven't gotten around to doing it > yet. No worries. I prefer getting the odd report for a false positive and look into it rather than turn a blind eye. At least you have a path for the tool to be improved, which is what matters. Thanks, M. -- Without deviation from the norm, progress is not possible.