From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 503D8EB64DC for ; Fri, 14 Jul 2023 09:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pgrY4/L12v8rhd4If0sfAZ8nv0rVCxhMtbQUdRoTj7w=; b=mk52O5FlWevUrT Y8l6KsWCSFG++YhYeN6c05dq6BRp18YpWjHHJxBY48YBy8wFNNBECkGDOiS9sysAVXdPg+5TJ2x4F RM0iDpnHc6HLTzO44EJR73vRx4nRybZwZeU11Rx8k09XNaQwniw7AV1rFXsGsFp1SvdjMJY08lFiN sNJGo+Ye5lBKCI6JcH0WONjqE/ZegFz1PD+lYSkDWEwToox52pzvPYUpKE1Xb+vJIeiUNEE7+kOqv fK9AWvws4iDQMQrZ8J9m7ohcugMRSlxRdRkBAyHktxRYzf/CeS5AdDOdLXEhbvCGPSLB0G7XLUGtW VANoh0+d/XTBNaXbGTPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKEfn-005c95-0B; Fri, 14 Jul 2023 09:01:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKEfk-005c8N-0R for linux-riscv@lists.infradead.org; Fri, 14 Jul 2023 09:01:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 972CF61BE9; Fri, 14 Jul 2023 09:01:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9B80C433C9; Fri, 14 Jul 2023 09:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689325267; bh=9aSAz0aIfqYogVI+EirWrWSKc2FYSWjc3BKCTzLQWpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USKyd0GvPzCSuQlVqgFlqHoATTWs5ikOi6rE7AXKALSgoXtE3VPNdPqYy94D3yDUY wWBkyRkDAt8o0FrdbciWzvFotlESKSoAYEV3zr2EwzfcGO4vHQbox4mutEeiyDZGc7 qRRMdWboihnBZcXxFTTmyauK1x2CRoCGBCv5HTfoBZkm3jtzTp3mtQ2329P/CCsI29 6iTEcTpouaNbGIz2cd0hhrYl7Nn36JvcIfOT3XvcpVvY9QKgo8erOeGEbLY10lDA4D 2ipw50FfytpZXl0yaha690JCFzMEEIsNTYXcIwUgCxcTq915okX0P29MSqFHN61k+D 2MXZQmZbQpjVg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qKEfg-00D3IW-EV; Fri, 14 Jul 2023 10:01:04 +0100 Date: Fri, 14 Jul 2023 10:01:04 +0100 Message-ID: <86jzv2vpdb.wl-maz@kernel.org> From: Marc Zyngier To: Saravana Kannan , Anup Patel Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: saravanak@google.com, apatel@ventanamicro.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_020108_252920_630B6A4C X-CRM114-Status: GOOD ( 29.09 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Anup Patel , Paul Walmsley , linux-kernel@vger.kernel.org, Conor Dooley , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Atish Patra , Thomas Gleixner , linux-riscv@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org QW51cCwKCk9uIEZyaSwgMTQgSnVsIDIwMjMgMDA6NTY6MjIgKzAxMDAsClNhcmF2YW5hIEthbm5h biA8c2FyYXZhbmFrQGdvb2dsZS5jb20+IHdyb3RlOgo+IAo+IE9uIE1vbiwgSnVsIDEwLCAyMDIz IGF0IDI6NDTigK9BTSBBbnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4gd3JvdGU6 Cj4gPgo+ID4gVGhlIFJJU0MtViBhZHZhbmNlZCBpbnRlcnJ1cHQgYXJjaGl0ZWN0dXJlIChBSUEp IHNwZWNpZmljYXRpb24gZGVmaW5lcwo+ID4gYSBuZXcgaW50ZXJydXB0IGNvbnRyb2xsZXIgZm9y IG1hbmFnaW5nIHdpcmVkIGludGVycnVwdHMgb24gYSBSSVNDLVYKPiA+IHBsYXRmb3JtLiBUaGlz IG5ldyBpbnRlcnJ1cHQgY29udHJvbGxlciBpcyByZWZlcnJlZCB0byBhcyBhZHZhbmNlZAo+ID4g cGxhdGZvcm0tbGV2ZWwgaW50ZXJydXB0IGNvbnRyb2xsZXIgKEFQTElDKSB3aGljaCBjYW4gZm9y d2FyZCB3aXJlZAo+ID4gaW50ZXJydXB0cyB0byBDUFVzIChvciBIQVJUcykgYXMgbG9jYWwgaW50 ZXJydXB0cyBPUiBhcyBtZXNzYWdlCj4gPiBzaWduYWxlZCBpbnRlcnJ1cHRzLgo+ID4gKEZvciBt b3JlIGRldGFpbHMgcmVmZXIgaHR0cHM6Ly9naXRodWIuY29tL3Jpc2N2L3Jpc2N2LWFpYSkKPiA+ Cj4gPiBUaGlzIHBhdGNoIGFkZHMgYW4gaXJxY2hpcCBkcml2ZXIgZm9yIFJJU0MtViBBUExJQyBm b3VuZCBvbiBSSVNDLVYKPiA+IHBsYXRmb3Jtcy4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBbnVw IFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KClsuLi5dCgo+ID4gK3N0YXRpYyBpbnQg X19pbml0IGFwbGljX2R0X2luaXQoc3RydWN0IGRldmljZV9ub2RlICpub2RlLAo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcmVudCkKPiA+ ICt7Cj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIFRoZSBBUExJQyBwbGF0Zm9ybSBkcml2 ZXIgbmVlZHMgdG8gYmUgcHJvYmVkIGVhcmx5Cj4gPiArICAgICAgICAqIHNvIGZvciBkZXZpY2Ug dHJlZToKPiA+ICsgICAgICAgICoKPiA+ICsgICAgICAgICogMSkgU2V0IHRoZSBGV05PREVfRkxB R19CRVNUX0VGRk9SVCBmbGFnIGluIGZ3bm9kZSB3aGljaAo+ID4gKyAgICAgICAgKiAgICBwcm92 aWRlcyBhIGhpbnQgdG8gdGhlIGRldmljZSBkcml2ZXIgY29yZSB0byBwcm9iZSB0aGUKPiA+ICsg ICAgICAgICogICAgcGxhdGZvcm0gZHJpdmVyIGVhcmx5Lgo+ID4gKyAgICAgICAgKiAyKSBDbGVh ciB0aGUgT0ZfUE9QVUxBVEVEIGZsYWcgaW4gZGV2aWNlX25vZGUgYmVjYXVzZQo+ID4gKyAgICAg ICAgKiAgICBvZl9pcnFfaW5pdCgpIHNldHMgaXQgd2hpY2ggcHJldmVudHMgY3JlYXRpb24gb2YK PiA+ICsgICAgICAgICogICAgcGxhdGZvcm0gZGV2aWNlLgo+ID4gKyAgICAgICAgKi8KPiA+ICsg ICAgICAgbm9kZS0+Zndub2RlLmZsYWdzIHw9IEZXTk9ERV9GTEFHX0JFU1RfRUZGT1JUOwo+IAo+ IFBsZWFzZSBzdG9wIHNwYW1taW5nIHVzIHdpdGggYnJva2VuIHBhdGNoZXMuIEFscmVhZHkgdG9s ZCB5b3UgdGhpcyBpcwo+IG5vdCBhbiBvcHRpb24uCj4gCj4gTmFjay4KCldoYXQgcHV6emxlcyBt ZSBoZXJlIGlzIHRoYXQgKm5vIG90aGVyIGFyY2gqIHJlcXVpcmVzIHRoaXMgc29ydCBvZgpoYWNr LiBXaGF0IGlzIHNvIHNwZWNpYWwgYWJvdXQgdGhlIEFQTElDIHRoYXQgaXQgcmVxdWlyZXMgaXQ/ IEkgc2VlCm5vdGhpbmcgaW4gdGhpcyBwYXRjaCB0aGF0IGV2ZW4gaGludHMgYXQgaXQsIGRlc3Bp dGUgdGhlICJkaXNjdXNzaW9uIgppbiB0aGUgbGFzdCByb3VuZC4KClRoZSBydWxlcyBhcmUgc2lt cGxlOgoKLSBlaXRoZXIgdGhlIEFQTElDIGlzIHNvIGZ1bmRhbWVudGFsIHRvIHRoZSBzeXN0ZW0g dGhhdCBpdCBoYXMgdG8gYmUKICBpbml0aWFsaXNlZCBzdXBlciBlYXJseSwgbXVjaCBsaWtlIHRo ZSBHSUMgb24gYXJtNjQsIGF0IHdoaWNoIHBvaW50CiAgaXQgY2Fubm90IGJlIGEgcGxhdGZvcm0g ZGV2aWNlLCBhbmQgdGhlIHN0b3J5IGlzIHByZXR0eSBzaW1wbGUuCgotIG9yIGl0IGlzbid0IHRo YXQgZnVuZGFtZW50YWwsIGFuZCBpdCBjYW4gYmUgcHJvYmVkIGFzIGEgcGxhdGZvcm0KICBkZXZp Y2UgdXNpbmcgdGhlIGRlcGVuZGVuY3kgaW5mcmFzdHJ1Y3R1cmUgdGhhdCBpcyBhbHJlYWR5IHVz ZWQgYnkKICBtdWx0aXBsZSBvdGhlciBpbnRlcnJ1cHQgY29udHJvbGxlciBkcml2ZXJzLCB3aXRo b3V0IGFueSBuZWVkIHRvCiAgbWVzcyB3aXRoIGludGVybmFsIGZsYWdzLiBBZ2FpbiwgdGhpcyBz aG91bGQgYmUgc2ltcGxlIGVub3VnaC4KCklmIHRoZXNlIHJ1bGVzIGRvbid0IGFwcGx5IHRvIHlv dXIgc3R1ZmYsIHBsZWFzZSBleHBsYWluIHdoYXQgaXMgc28KZGlmZmVyZW50LiBBbmQgSSBtZWFu IGFjdHVhbGx5IGV4cGxhaW4gdGhlIGlzc3VlLiBXaGljaCBpc24ndCB0ZWxsaW5nCnVzICJpdCBk b2Vzbid0IHdvcmsgd2l0aG91dCBpdCIuIEJlY2F1c2UgYXMgdGhpbmdzIHN0YW5kLCB0aGVyZSBp cyBubwp3YXkgSSB3aWxsIGV2ZW4gY29uc2lkZXIgdGFraW5nIHRoaXMgdWdseSBtaXggb2YgcHJv YmluZyBtZXRob2RzLgoKSW4gYW55IGNhc2UsIHJlcG9zdGluZyB0aGUgc2FtZSBzdHVmZiBhZCBu YXVzZWFtIGlzIG9ubHkgZ29pbmcgdG8KcmVzdWx0IGluIHRoaXMgc2VyaWVzIGJlaW5nIGlnbm9y ZWQsIHdoaWNoIEkgZG9uJ3QgdGhpbmsgaXMgd2hhdCB5b3UKd2FudC4KClRoYW5rcywKCglNLgoK LS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3Nz aWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC13EB64DA for ; Fri, 14 Jul 2023 09:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235596AbjGNJBs (ORCPT ); Fri, 14 Jul 2023 05:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235531AbjGNJBZ (ORCPT ); Fri, 14 Jul 2023 05:01:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125282D50; Fri, 14 Jul 2023 02:01:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9763661C9C; Fri, 14 Jul 2023 09:01:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9B80C433C9; Fri, 14 Jul 2023 09:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689325267; bh=9aSAz0aIfqYogVI+EirWrWSKc2FYSWjc3BKCTzLQWpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USKyd0GvPzCSuQlVqgFlqHoATTWs5ikOi6rE7AXKALSgoXtE3VPNdPqYy94D3yDUY wWBkyRkDAt8o0FrdbciWzvFotlESKSoAYEV3zr2EwzfcGO4vHQbox4mutEeiyDZGc7 qRRMdWboihnBZcXxFTTmyauK1x2CRoCGBCv5HTfoBZkm3jtzTp3mtQ2329P/CCsI29 6iTEcTpouaNbGIz2cd0hhrYl7Nn36JvcIfOT3XvcpVvY9QKgo8erOeGEbLY10lDA4D 2ipw50FfytpZXl0yaha690JCFzMEEIsNTYXcIwUgCxcTq915okX0P29MSqFHN61k+D 2MXZQmZbQpjVg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qKEfg-00D3IW-EV; Fri, 14 Jul 2023 10:01:04 +0100 Date: Fri, 14 Jul 2023 10:01:04 +0100 Message-ID: <86jzv2vpdb.wl-maz@kernel.org> From: Marc Zyngier To: Saravana Kannan , Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Atish Patra , Andrew Jones , Sunil V L , Conor Dooley , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: saravanak@google.com, apatel@ventanamicro.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Anup, On Fri, 14 Jul 2023 00:56:22 +0100, Saravana Kannan wrote: >=20 > On Mon, Jul 10, 2023 at 2:44=E2=80=AFAM Anup Patel wrote: > > > > The RISC-V advanced interrupt architecture (AIA) specification defines > > a new interrupt controller for managing wired interrupts on a RISC-V > > platform. This new interrupt controller is referred to as advanced > > platform-level interrupt controller (APLIC) which can forward wired > > interrupts to CPUs (or HARTs) as local interrupts OR as message > > signaled interrupts. > > (For more details refer https://github.com/riscv/riscv-aia) > > > > This patch adds an irqchip driver for RISC-V APLIC found on RISC-V > > platforms. > > > > Signed-off-by: Anup Patel [...] > > +static int __init aplic_dt_init(struct device_node *node, > > + struct device_node *parent) > > +{ > > + /* > > + * The APLIC platform driver needs to be probed early > > + * so for device tree: > > + * > > + * 1) Set the FWNODE_FLAG_BEST_EFFORT flag in fwnode which > > + * provides a hint to the device driver core to probe the > > + * platform driver early. > > + * 2) Clear the OF_POPULATED flag in device_node because > > + * of_irq_init() sets it which prevents creation of > > + * platform device. > > + */ > > + node->fwnode.flags |=3D FWNODE_FLAG_BEST_EFFORT; >=20 > Please stop spamming us with broken patches. Already told you this is > not an option. >=20 > Nack. What puzzles me here is that *no other arch* requires this sort of hack. What is so special about the APLIC that it requires it? I see nothing in this patch that even hints at it, despite the "discussion" in the last round. The rules are simple: - either the APLIC is so fundamental to the system that it has to be initialised super early, much like the GIC on arm64, at which point it cannot be a platform device, and the story is pretty simple. - or it isn't that fundamental, and it can be probed as a platform device using the dependency infrastructure that is already used by multiple other interrupt controller drivers, without any need to mess with internal flags. Again, this should be simple enough. If these rules don't apply to your stuff, please explain what is so different. And I mean actually explain the issue. Which isn't telling us "it doesn't work without it". Because as things stand, there is no way I will even consider taking this ugly mix of probing methods. In any case, reposting the same stuff ad nauseam is only going to result in this series being ignored, which I don't think is what you want. Thanks, M. --=20 Without deviation from the norm, progress is not possible.