From: merlyn@stonehenge.com (Randal L. Schwartz)
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org
Subject: Re: git-clean fails to remove a file whose name contains \\, ", or \n, TAB, etc.
Date: Tue, 08 May 2007 13:51:01 -0700 [thread overview]
Message-ID: <86k5vj9gzu.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <87ps5bhx8t.fsf@rho.meyering.net> (Jim Meyering's message of "Tue, 08 May 2007 22:32:50 +0200")
>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:
Jim> Not that it matters (or maybe this is a feature :-), because people
Jim> who create such files in their working directory deserve what they
Jim> get, Eh? :-)
The problem is the newline in the string, since
git-ls-files --others --directory $excl ${excl_info:+"$excl_info"} -- "$@" |
while read -r file; do
is using newline as a delimiter. Any file with a newline would mess this up.
Not being a shell programming expert, is there a way we could use -z and xargs
-0 here instead?
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
next prev parent reply other threads:[~2007-05-08 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 20:32 git-clean fails to remove a file whose name contains \\, ", or \n, TAB, etc Jim Meyering
2007-05-08 20:51 ` Randal L. Schwartz [this message]
2007-05-08 20:53 ` Junio C Hamano
2007-05-08 23:11 ` Jan Hudec
2007-05-08 23:18 ` Randal L. Schwartz
2007-05-08 23:27 ` Karl Hasselström
2007-05-08 23:29 ` Randal L. Schwartz
2007-05-08 23:38 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k5vj9gzu.fsf@blue.stonehenge.com \
--to=merlyn@stonehenge.com \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.