From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B987DF58 for ; Wed, 2 Aug 2023 17:52:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8EC9C433C8; Wed, 2 Aug 2023 17:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690998778; bh=uRYtG8q0OMNIrkxz12A1TeaVWvX+CXQ+DHeCh+Zma2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gZCs6EzXdrjn6ib1NtkAeFaf71VC84zl6lF1iqVCC2QxjXPpjJVqXjRsRkKrVz7UI G1ch6I/jZ14rH5vM/zYo9at60YPjUv3F9P0LXmXjR83gRLjUAwUuX0ayltPxImQeqz gdjz7dv234YslN5myKZtyELjWtX7f6ZJQoAl0tmd9qlOMmOunc4ahb4hGRb7W+I352 S6GNIH3UwM/fBBZd4lOQOLKLyko1aA0vYFbJ+YYoslhdeZ0yekE8QwRqBebbF1+H70 QEUruCGMptHaFYyhjAZc5yOybW7toswJvhFhRZDM8XGtHxq5gCPZvDTLmQu4BkjQoF +FgpQBaVCUDmg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qRG1o-001Rzi-Ad; Wed, 02 Aug 2023 18:52:56 +0100 Date: Wed, 02 Aug 2023 18:52:55 +0100 Message-ID: <86leet5o20.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v2 06/26] arm64: Add debug registers affected by HDFGxTR_EL2 In-Reply-To: <61B845D3-A42B-451F-B74D-51B4A1FD28C6@oracle.com> References: <20230728082952.959212-1-maz@kernel.org> <20230728082952.959212-7-maz@kernel.org> <61B845D3-A42B-451F-B74D-51B4A1FD28C6@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 31 Jul 2023 17:41:41 +0100, Miguel Luis wrote: >=20 > Hi Marc, >=20 > A few comments on this one, please see below. >=20 > > On 28 Jul 2023, at 08:29, Marc Zyngier wrote: > >=20 > > The HDFGxTR_EL2 registers trap a (huge) set of debug and trace > > related registers. Add their encodings (and only that, because > > we really don't care about what these registers actually do at > > this stage). > >=20 > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/include/asm/sysreg.h | 78 +++++++++++++++++++++++++++++++++ > > 1 file changed, 78 insertions(+) > >=20 > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/s= ysreg.h > > index 76289339b43b..9dfd127be55a 100644 > > --- a/arch/arm64/include/asm/sysreg.h > > +++ b/arch/arm64/include/asm/sysreg.h > > @@ -194,6 +194,84 @@ > > #define SYS_DBGDTRTX_EL0 sys_reg(2, 3, 0, 5, 0) > > #define SYS_DBGVCR32_EL2 sys_reg(2, 4, 0, 7, 0) > >=20 > > +#define SYS_BRBINF_EL1(n) sys_reg(2, 1, 8, (n & 15), (((n & 16) >> 2) = | 0)) > > +#define SYS_BRBINFINJ_EL1 sys_reg(2, 1, 9, 1, 0) > > +#define SYS_BRBSRC_EL1(n) sys_reg(2, 1, 8, (n & 15), (((n & 16) >> 2) = | 1)) > > +#define SYS_BRBSRCINJ_EL1 sys_reg(2, 1, 9, 1, 1) > > +#define SYS_BRBTGT_EL1(n) sys_reg(2, 1, 8, (n & 15), (((n & 16) >> 2) = | 2)) > > +#define SYS_BRBTGTINJ_EL1 sys_reg(2, 1, 9, 1, 2) > > +#define SYS_BRBTS_EL1 sys_reg(2, 1, 9, 0, 2) > > + > > +#define SYS_BRBCR_EL1 sys_reg(2, 1, 9, 0, 0) > > +#define SYS_BRBFCR_EL1 sys_reg(2, 1, 9, 0, 1) > > +#define SYS_BRBIDR0_EL1 sys_reg(2, 1, 9, 2, 0) > > + > > +#define SYS_TRCITECR_EL1 sys_reg(3, 0, 1, 2, 3) > > +#define SYS_TRCITECR_EL1 sys_reg(3, 0, 1, 2, 3) >=20 > SYS_TRCITECR_EL1 shows up twice. Ah, nice one. Too many registers. >=20 > > +#define SYS_TRCACATR(m) sys_reg(2, 1, 2, ((m & 7) << 1), (2 | (m >> 3)= )) >=20 > Besides m=E2=80=99s restrictions it could be sanitised in op2 to consider= only bit m[3]. > Suggestion for op2: (2 | ((m & 8) >> 3))) It is fully expected that 'm' will be in the 0-15 range, as per the architecture (D19.4.8), and the tables only use that exact range. Do you see an actual bug, or is this defensive programming? Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10859C04A94 for ; Wed, 2 Aug 2023 17:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fKEj1C/k9Bvy7ER9svDDQ0FY3vUGa5jbY/6tOXtcZHE=; b=3Wi8bwi0WlmPEv 2hSj9lMqm25DoIkoIawe5Lpyo7TqTVxrDbPGUJKqqdJ/l0Ac2bNgvz7ncK2QOChIMlofWcAcY74ph pinaVOI5IwGPsdc45t/y1IWUwb3x4+HcV2HasxJQAdcg2Ac06prtj6hgY1+vjrfB91q8uvPyU/4/s FIgBtw5asCVRVibziZ5fvmTMsyXbuL9Ubyz0s+MTdpg8HK45P+6W9i1klaI8RdSsDWnwYavYDHZmN FfiN3RzYzL+0l0loBfjkAaGTv7NvoJEOyc4CwqpwvY77ju+NKlrUOHIIIVJo6eNKkIugq4JvNR7Ow /xBNip7N3ZzraMAVJazw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRG1w-005aJc-28; Wed, 02 Aug 2023 17:53:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRG1s-005aJ8-0c for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 17:53:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FD6461A60; Wed, 2 Aug 2023 17:52:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8EC9C433C8; Wed, 2 Aug 2023 17:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690998778; bh=uRYtG8q0OMNIrkxz12A1TeaVWvX+CXQ+DHeCh+Zma2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gZCs6EzXdrjn6ib1NtkAeFaf71VC84zl6lF1iqVCC2QxjXPpjJVqXjRsRkKrVz7UI G1ch6I/jZ14rH5vM/zYo9at60YPjUv3F9P0LXmXjR83gRLjUAwUuX0ayltPxImQeqz gdjz7dv234YslN5myKZtyELjWtX7f6ZJQoAl0tmd9qlOMmOunc4ahb4hGRb7W+I352 S6GNIH3UwM/fBBZd4lOQOLKLyko1aA0vYFbJ+YYoslhdeZ0yekE8QwRqBebbF1+H70 QEUruCGMptHaFYyhjAZc5yOybW7toswJvhFhRZDM8XGtHxq5gCPZvDTLmQu4BkjQoF +FgpQBaVCUDmg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qRG1o-001Rzi-Ad; Wed, 02 Aug 2023 18:52:56 +0100 Date: Wed, 02 Aug 2023 18:52:55 +0100 Message-ID: <86leet5o20.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v2 06/26] arm64: Add debug registers affected by HDFGxTR_EL2 In-Reply-To: <61B845D3-A42B-451F-B74D-51B4A1FD28C6@oracle.com> References: <20230728082952.959212-1-maz@kernel.org> <20230728082952.959212-7-maz@kernel.org> <61B845D3-A42B-451F-B74D-51B4A1FD28C6@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_105300_319713_16BD4728 X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAzMSBKdWwgMjAyMyAxNzo0MTo0MSArMDEwMCwKTWlndWVsIEx1aXMgPG1pZ3VlbC5s dWlzQG9yYWNsZS5jb20+IHdyb3RlOgo+IAo+IEhpIE1hcmMsCj4gCj4gQSBmZXcgY29tbWVudHMg b24gdGhpcyBvbmUsIHBsZWFzZSBzZWUgYmVsb3cuCj4gCj4gPiBPbiAyOCBKdWwgMjAyMywgYXQg MDg6MjksIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gCj4gPiBUaGUg SERGR3hUUl9FTDIgcmVnaXN0ZXJzIHRyYXAgYSAoaHVnZSkgc2V0IG9mIGRlYnVnIGFuZCB0cmFj ZQo+ID4gcmVsYXRlZCByZWdpc3RlcnMuIEFkZCB0aGVpciBlbmNvZGluZ3MgKGFuZCBvbmx5IHRo YXQsIGJlY2F1c2UKPiA+IHdlIHJlYWxseSBkb24ndCBjYXJlIGFib3V0IHdoYXQgdGhlc2UgcmVn aXN0ZXJzIGFjdHVhbGx5IGRvIGF0Cj4gPiB0aGlzIHN0YWdlKS4KPiA+IAo+ID4gU2lnbmVkLW9m Zi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPiA+IC0tLQo+ID4gYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9zeXNyZWcuaCB8IDc4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ID4gMSBmaWxlIGNoYW5nZWQsIDc4IGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmggYi9hcmNoL2FybTY0L2luY2x1 ZGUvYXNtL3N5c3JlZy5oCj4gPiBpbmRleCA3NjI4OTMzOWI0M2IuLjlkZmQxMjdiZTU1YSAxMDA2 NDQKPiA+IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPiA+ICsrKyBiL2Fy Y2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPiA+IEBAIC0xOTQsNiArMTk0LDg0IEBACj4g PiAjZGVmaW5lIFNZU19EQkdEVFJUWF9FTDAgc3lzX3JlZygyLCAzLCAwLCA1LCAwKQo+ID4gI2Rl ZmluZSBTWVNfREJHVkNSMzJfRUwyIHN5c19yZWcoMiwgNCwgMCwgNywgMCkKPiA+IAo+ID4gKyNk ZWZpbmUgU1lTX0JSQklORl9FTDEobikgc3lzX3JlZygyLCAxLCA4LCAobiAmIDE1KSwgKCgobiAm IDE2KSA+PiAyKSB8IDApKQo+ID4gKyNkZWZpbmUgU1lTX0JSQklORklOSl9FTDEgc3lzX3JlZygy LCAxLCA5LCAxLCAwKQo+ID4gKyNkZWZpbmUgU1lTX0JSQlNSQ19FTDEobikgc3lzX3JlZygyLCAx LCA4LCAobiAmIDE1KSwgKCgobiAmIDE2KSA+PiAyKSB8IDEpKQo+ID4gKyNkZWZpbmUgU1lTX0JS QlNSQ0lOSl9FTDEgc3lzX3JlZygyLCAxLCA5LCAxLCAxKQo+ID4gKyNkZWZpbmUgU1lTX0JSQlRH VF9FTDEobikgc3lzX3JlZygyLCAxLCA4LCAobiAmIDE1KSwgKCgobiAmIDE2KSA+PiAyKSB8IDIp KQo+ID4gKyNkZWZpbmUgU1lTX0JSQlRHVElOSl9FTDEgc3lzX3JlZygyLCAxLCA5LCAxLCAyKQo+ ID4gKyNkZWZpbmUgU1lTX0JSQlRTX0VMMSBzeXNfcmVnKDIsIDEsIDksIDAsIDIpCj4gPiArCj4g PiArI2RlZmluZSBTWVNfQlJCQ1JfRUwxIHN5c19yZWcoMiwgMSwgOSwgMCwgMCkKPiA+ICsjZGVm aW5lIFNZU19CUkJGQ1JfRUwxIHN5c19yZWcoMiwgMSwgOSwgMCwgMSkKPiA+ICsjZGVmaW5lIFNZ U19CUkJJRFIwX0VMMSBzeXNfcmVnKDIsIDEsIDksIDIsIDApCj4gPiArCj4gPiArI2RlZmluZSBT WVNfVFJDSVRFQ1JfRUwxIHN5c19yZWcoMywgMCwgMSwgMiwgMykKPiA+ICsjZGVmaW5lIFNZU19U UkNJVEVDUl9FTDEgc3lzX3JlZygzLCAwLCAxLCAyLCAzKQo+IAo+IFNZU19UUkNJVEVDUl9FTDEg c2hvd3MgdXAgdHdpY2UuCgpBaCwgbmljZSBvbmUuIFRvbyBtYW55IHJlZ2lzdGVycy4KCj4gCj4g PiArI2RlZmluZSBTWVNfVFJDQUNBVFIobSkgc3lzX3JlZygyLCAxLCAyLCAoKG0gJiA3KSA8PCAx KSwgKDIgfCAobSA+PiAzKSkpCj4gCj4gQmVzaWRlcyBt4oCZcyByZXN0cmljdGlvbnMgaXQgY291 bGQgYmUgc2FuaXRpc2VkIGluIG9wMiB0byBjb25zaWRlciBvbmx5IGJpdCBtWzNdLgo+IFN1Z2dl c3Rpb24gZm9yIG9wMjogKDIgfCAoKG0gJiA4KSA+PiAzKSkpCgpJdCBpcyBmdWxseSBleHBlY3Rl ZCB0aGF0ICdtJyB3aWxsIGJlIGluIHRoZSAwLTE1IHJhbmdlLCBhcyBwZXIgdGhlCmFyY2hpdGVj dHVyZSAoRDE5LjQuOCksIGFuZCB0aGUgdGFibGVzIG9ubHkgdXNlIHRoYXQgZXhhY3QgcmFuZ2Uu CgpEbyB5b3Ugc2VlIGFuIGFjdHVhbCBidWcsIG9yIGlzIHRoaXMgZGVmZW5zaXZlIHByb2dyYW1t aW5nPwoKVGhhbmtzLAoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwg cHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=