[OpenRISC] [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support

[Yao Qi <qiyaoltc@gmail.com>]

Stafford Horne <shorne@gmail.com> writes:

> I tried to look into this, but it looks liek we do need
> set_gdbarch_print_insn ().   If not starting gdb hits this error in
> gdbarch.c verify_gdbarch().
>
> ...
>   if (gdbarch->print_insn == 0)
>     log.puts ("\n\tprint_insn");

These lines were removed by my commit
39503f82427e22ed8e04d986ccdc8562091ec62e (Delegate opcodes to select
disassembler in GDB) on May 24th.

-  if (gdbarch->print_insn == 0)
-    log.puts ("\n\tprint_insn");
+  /* Skip verify of print_insn, invalid_p == 0 */

> ...
>
>   if (!log.empty ())
>     internal_error (__FILE__, __LINE__,
> 		    _("verify_gdbarch: the following are invalid ...%s"),
> 		    log.c_str ());
> ...
>
> Is the automatic selecting of `print_insn` something new?  My patch is
> based on yesterdays master branch of http://sourceware.org/git/binutils-gdb.git.

Looks your gdbarch.c is out of date.

-- 
Yao (齐尧)