From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Date: Sat, 27 Dec 2014 13:00:31 -0800 Message-ID: <86lhlsq040.fsf@hiro.keithp.com> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> <86a929ypsa.fsf@hiro.keithp.com> <873881arbn.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0986469082==" Return-path: In-Reply-To: <873881arbn.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nzer?= Cc: "List, X.Org" , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============0986469082== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eric Anholt writes: >> --- a/glamor/glamor_xv.c >> +++ b/glamor/glamor_xv.c >> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, >> } >>=20=20 >> top =3D (src_y) & ~1; >> - nlines =3D (src_y + height) - top; >> + nlines =3D (src_y + src_h) - top; >>=20=20 >> switch (id) { >> case FOURCC_YV12: > > If the point is to upload only from the src_[xywh] recctangle, shouldn't > the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead > of width, too? It doesn't need to, but it could as an optimization. Skipping lines at the top and bottom is also just an optimization as the source rectangle defines a subset of the provided buffer, after all. I just fixed that optimization. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBVJ8d8tsiGmkAAAARAQhqTA/8C+M2VH/x8Q8h25sK+Iq9ineVHbs3m54Z Hc13NELVAi67C4tElNzaVPJtcZCao1vX36y11NdS+7cxDlAMSCqA2UrhFhFKKVlC eMl0qgw9rbn8Z9x6fNGLGBcW9KU34dFW3xJRA8kBfys1uZEyuLmQIAG3QEqFIBLt ki2QHCapHEuVtDY/rvfbpejhla/r86avKVL0z5US9saSVIOBFtH1fLDGgDAfdQpv p6NUFysO7zi8UYmn/enqa3hvMTrivB7pGGT/5mUDeVhPL5SHaBR15k48rEeGzzl6 u2xJQgVITdYuiNqv9GsH2bR7JVCe4fWBdNduOK6dKoUmyLuZdz6ae/PFTgnfe52X aQY03p0/oD5WHZC/Ri9U+61N7JHbLZFC3hkNqpQ/LevmeuMcRUggyBVgXhYot8/N b4SEyAzPZh8VMLVFTfIzREtPdk8tezHd24pn8CMmKMKbcY26Rv3uCr/kBXYaNrGD GR5BTpp5bmkdw3bUacyfB2vGdBuJp4KkmNUg6jRWgUKOsXJPyK1Lg+kDxgDOtt51 fnLMvD/FwKt4U/QUuwG1bcW4tww16PioTjXJgyNftCq2LDOJyiF8TVZSTI80CKOW XRAIjDNIycW3m3FsejXve1yr9Ms+gijHygesE9qHC5KtY5LTglUVKkJ69NtsrNQ7 +x2V4k0wUTA= =G0GQ -----END PGP SIGNATURE----- --=-=-=-- --===============0986469082== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0986469082==--