From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915: argument for deferring retirement Date: Tue, 24 Jan 2012 15:00:05 -0800 Message-ID: <86liowln9m.fsf@sumi.keithp.com> References: <1327444923-13316-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2118924602==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id B78D29E77F for ; Tue, 24 Jan 2012 15:00:11 -0800 (PST) In-Reply-To: <1327444923-13316-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============2118924602== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 24 Jan 2012 14:42:02 -0800, Ben Widawsky wrote: > Sometimes it may be the case when we idle the gpu or wait on something > we don't actually want to process the retiring list. This patch allows > callers to choose the behavior. !defer_retirement sounds like a double-negative to me, might be better to have the parameter called 'do_retire' and change usage to match? In any case, this looks easy to understand to me. Reviewed-by: Keith Packard =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTx839TYtFsjWk68qAQjohBAAivJ68pE/dZO7pMH9MBn5tn6h51BCThJo safR2GgobcZ+B01XDqWwzYjJnLsAPmFtPRFqnA8gzmEfWnqZxWuEMGSgKfqjKiDc nO302Zb/XzyaiqLrFi0kz4q3t3bRdgGQJuf+H4Pw/rWV17QODBCnhiYOvo1NzoAP 0Fmz4nptdW5Nd25/CxaPhwrAEhKIxkw3LujodzxoCWNk8ltQvxi8ti2wCSWZAY9+ r2q4VP2Sz2QCr6/r7llBTRzyOJaXxFET0OrlH7eOMhO77FrogjRp/ehGHtRikWS1 8U+L/rQsiwCTy3HA2C0CEWAV0Ck/+c1nyzMkfEL8VUPKDj1BLZxa7mHdpudSkIS/ 93lFYcSD3UWrDKl/6NebfqBtW26Tj4T6kOu5FfbHXXQaQvQeUJ6/lcQdpYwpG1hm achmZJt+0MUX84yuL0acSdoPmA+wR1l2wGeav7Fi+HsYEvex2gCl+0r7ZjIlumZZ nB9gG4Swf/fmBiLAnJvXFmzyyPbRXVCt4GzfGNrJCOXnbyGVlkJ7ZVPzt/qAZTmp pUYDmJ12sKyRr4+bTFB59Qu0ODigv8VGVzeun9oJdV0V/9MyHjCxw6lbLvdKxDz5 7u6PeTyRxBFeb35aMxBov/UPfYDyfDHJr9+3YzviMJo9Ln0oTHnl8vUPNYofYKJk xuUuysWVBrk= =NOvS -----END PGP SIGNATURE----- --=-=-=-- --===============2118924602== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2118924602==--