Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5

[Juan Quintela <quintela@mandrakesoft.com>]

>>>>> "yoichi" == Yoichi Yuasa <yuasa@hh.iij4u.or.jp> writes:

Hi
        a couple of comments.

Later, Juan.

yoichi> diff -aruN --exclude=CVS --exclude=.cvsignore linux.orig/arch/mips/vr41xx/tanbac-tb0226/setup.c linux/arch/mips/vr41xx/tanbac-tb0226/setup.c
yoichi> --- linux.orig/arch/mips/vr41xx/tanbac-tb0226/setup.c	Thu Jan  1 09:00:00 1970
yoichi> +++ linux/arch/mips/vr41xx/tanbac-tb0226/setup.c	Tue Apr 22 17:55:33 2003
yoichi> +
yoichi> +#ifdef CONFIG_PCI
yoichi> +static struct resource vr41xx_pci_io_resource = {
yoichi> +	"PCI I/O space",
yoichi> +	VR41XX_PCI_IO_START,
yoichi> +	VR41XX_PCI_IO_END,
yoichi> +	IORESOURCE_IO
yoichi> +};
yoichi> +
yoichi> +static struct resource vr41xx_pci_mem_resource = {
yoichi> +	"PCI memory space",
yoichi> +	VR41XX_PCI_MEM_START,
yoichi> +	VR41XX_PCI_MEM_END,
yoichi> +	IORESOURCE_MEM
yoichi> +};

Please, use C99 named initializers in the whole file.

yoichi> +
yoichi> +extern struct pci_ops vr41xx_pci_ops;
yoichi> +
yoichi> +struct pci_channel mips_pci_channels[] = {
yoichi> +	{&vr41xx_pci_ops, &vr41xx_pci_io_resource, &vr41xx_pci_mem_resource, 0, 256},
yoichi> +	{NULL, NULL, NULL, 0, 0}
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_mem1 = {
yoichi> +	VR41XX_PCI_MEM1_BASE,
yoichi> +	VR41XX_PCI_MEM1_MASK,
yoichi> +	IO_MEM1_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_mem2 = {
yoichi> +	VR41XX_PCI_MEM2_BASE,
yoichi> +	VR41XX_PCI_MEM2_MASK,
yoichi> +	IO_MEM2_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_io = {
yoichi> +	VR41XX_PCI_IO_BASE,
yoichi> +	VR41XX_PCI_IO_MASK,
yoichi> +	IO_PORT_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +static struct vr41xx_pci_address_map pci_address_map = {
yoichi> +	&vr41xx_pci_mem1,
yoichi> +	&vr41xx_pci_mem2,
yoichi> +	&vr41xx_pci_io
yoichi> +};
yoichi> +#endif

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy