From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1322D8635A for ; Fri, 14 Feb 2025 16:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739551404; cv=none; b=qRR8XGH0CW3j7lBlVa05Ea3dvridPhIvE5tByDU6ynMEHd75iURQ2rfL0+C4l8RBJnLunJhnhSPMVxnBx3TfP6SkUjlqLhl0s99yDkZdWn2om5kZZhLq8yYxT+UzyOctiKS5GRVUgKjnSR7hIkL+E8zc48Bfw3ccNXSOEYLT3Cs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739551404; c=relaxed/simple; bh=nZvXCi+p67k4zNOl9SV+J07JZZJ0CvtmHctG/EhAgfc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=LDOBDzvHfH88HdtWMjV1RIxnUFQwYNFSo9g2o6smeV22kA3RbNAhBYumtfAhjarVu71E+V8c7774iAdQgqSy6QwxFWoLjEzHyroEYfdeonQ9vVUm5mmm1rR3VgAlXYFVfZGW9WVOXbVaZ2bZWsbti4C2cfT1Uiikge8jdsZstyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=otpRedNL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="otpRedNL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CEBDC4CED1; Fri, 14 Feb 2025 16:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739551403; bh=nZvXCi+p67k4zNOl9SV+J07JZZJ0CvtmHctG/EhAgfc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=otpRedNLdmkSfIG1ewq3m7jO5EqL/ME7MqTtET8n1HLK3dt4IPmV0p24IycXb+lQU lq7aPURx50WL4kVol7fBVPUTg81g6i2EoNJMhhR/uUL2bWwij82aRsuzPcUtdiBUZy 3o/NO1gxS1dQHxf2w91pdfHFpewi19Xwzk80qNv2pDJmDR+HZir076sz3eidPPHpD7 hCwXDvC4heyobMZk5T4W74zC1q8rholTFsg0aDrVyeR7R5moyRaUvnMBlEF1EThwSV lGKTU9PDFuU9PjarYbohV92EIM6XML2SAFwCfSuAEWHcmnf95Efr4TSmg3x1DID4ZB EEvORoaH5KuQQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tiymf-0048hO-6A; Fri, 14 Feb 2025 16:43:21 +0000 Date: Fri, 14 Feb 2025 16:43:20 +0000 Message-ID: <86mseoscif.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Ott Cc: Shameer Kolothum , kvmarm@lists.linux.dev, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, cohuck@redhat.com, eric.auger@redhat.com, yuzenghui@huawei.com, wangzhou1@hisilicon.com, jiangkunkun@huawei.com, jonathan.cameron@huawei.com, anthony.jebson@huawei.com, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Subject: Re: [PATCH v7 4/5] smccc/kvm_guest: Enable errata based on implementation CPUs In-Reply-To: <10831a79-a21f-dc40-a374-81b300d26dac@redhat.com> References: <20250214151343.61348-1-shameerali.kolothum.thodi@huawei.com> <20250214151343.61348-5-shameerali.kolothum.thodi@huawei.com> <10831a79-a21f-dc40-a374-81b300d26dac@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, kvmarm@lists.linux.dev, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, cohuck@redhat.com, eric.auger@redhat.com, yuzenghui@huawei.com, wangzhou1@hisilicon.com, jiangkunkun@huawei.com, jonathan.cameron@huawei.com, anthony.jebson@huawei.com, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 14 Feb 2025 16:12:02 +0000, Sebastian Ott wrote: > > On Fri, 14 Feb 2025, Shameer Kolothum wrote: > > +++ b/arch/arm64/kernel/cpu_errata.c > > @@ -14,6 +14,9 @@ > > #include > > #include > > > > +u32 target_impl_cpu_num; > > +struct target_impl_cpu *target_impl_cpus; > > These should be exported (for configs using > CONFIG_CORESIGHT_SOURCE_ETM4X=m) It might be better to make is_midr_in_range() out of line, and export that. This could allow making the data static (by implementing a couple of additional accessors). Thanks, M. -- Without deviation from the norm, progress is not possible.