From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A739AC04AB6 for ; Fri, 31 May 2019 09:39:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D3BF266FF for ; Fri, 31 May 2019 09:39:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D3BF266FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hWdzt-0003ZH-0G; Fri, 31 May 2019 09:38:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hWdzr-0003ZC-On for xen-devel@lists.xenproject.org; Fri, 31 May 2019 09:38:47 +0000 X-Inumbo-ID: e2adfbfa-8387-11e9-ad65-c3f29740d28e Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id e2adfbfa-8387-11e9-ad65-c3f29740d28e; Fri, 31 May 2019 09:38:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C554341; Fri, 31 May 2019 02:38:45 -0700 (PDT) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E33F13F59C; Fri, 31 May 2019 02:38:42 -0700 (PDT) Date: Fri, 31 May 2019 10:38:40 +0100 Message-ID: <86muj36k0v.wl-marc.zyngier@arm.com> From: Marc Zyngier To: "Raslan, KarimAllah" In-Reply-To: <1559293922.14762.2.camel@amazon.de> References: <1539078879-4372-1-git-send-email-sironi@amazon.de> <1557847002-23519-1-git-send-email-sironi@amazon.de> <1557847002-23519-2-git-send-email-sironi@amazon.de> <3D2C4EE3-1C2E-4032-9964-31A066E542AA@amazon.de> <6b3dadf9-6240-6440-b784-50bec605bf2c@amazon.com> <1559293922.14762.2.camel@amazon.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [Xen-devel] [PATCH v2 1/2] KVM: Start populating /sys/hypervisor with KVM entries X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "kvm@vger.kernel.org" , "konrad.wilk@oracle.com" , "Sironi, Filippo" , "cohuck@redhat.com" , "linux-kernel@vger.kernel.org" , Christoffer Dall , "borntraeger@de.ibm.com" , "Graf, Alexander" , "xen-devel@lists.xenproject.org" , "boris.ostrovsky@oracle.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gRnJpLCAzMSBNYXkgMjAxOSAxMDoxMjowMyArMDEwMCwKIlJhc2xhbiwgS2FyaW1BbGxhaCIg PGthcmFobWVkQGFtYXpvbi5kZT4gd3JvdGU6Cj4gCj4gT24gRnJpLCAyMDE5LTA1LTMxIGF0IDEx OjA2ICswMjAwLCBBbGV4YW5kZXIgR3JhZiB3cm90ZToKPiA+IE9uIDE3LjA1LjE5IDE3OjQxLCBT aXJvbmksIEZpbGlwcG8gd3JvdGU6Cj4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IE9uIDE2LiBNYXkg MjAxOSwgYXQgMTU6NTAsIEdyYWYsIEFsZXhhbmRlciA8Z3JhZkBhbWF6b24uY29tPiB3cm90ZToK PiA+ID4gPiAKPiA+ID4gPiBPbiAxNC4wNS4xOSAwODoxNiwgRmlsaXBwbyBTaXJvbmkgd3JvdGU6 Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IFN0YXJ0IHBvcHVsYXRpbmcgL3N5cy9oeXBlcnZpc29yIHdp dGggS1ZNIGVudHJpZXMgd2hlbiB3ZSdyZSBydW5uaW5nIG9uCj4gPiA+ID4gPiBLVk0uIFRoaXMg aXMgdG8gcmVwbGljYXRlIGZ1bmN0aW9uYWxpdHkgdGhhdCdzIGF2YWlsYWJsZSB3aGVuIHdlJ3Jl Cj4gPiA+ID4gPiBydW5uaW5nIG9uIFhlbi4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gU3RhcnQgd2l0 aCAvc3lzL2h5cGVydmlzb3IvdXVpZCwgd2hpY2ggdXNlcnMgcHJlZmVyIG92ZXIKPiA+ID4gPiA+ IC9zeXMvZGV2aWNlcy92aXJ0dWFsL2RtaS9pZC9wcm9kdWN0X3V1aWQgYXMgYSB3YXkgdG8gcmVj b2duaXplIGEgdmlydHVhbAo+ID4gPiA+ID4gbWFjaGluZSwgc2luY2UgaXQncyBhbHNvIGF2YWls YWJsZSB3aGVuIHJ1bm5pbmcgb24gWGVuIEhWTSBhbmQgb24gWGVuIFBWCj4gPiA+ID4gPiBhbmQs IG9uIHRvcCBvZiB0aGF0IGRvZXNuJ3QgcmVxdWlyZSByb290IHByaXZpbGVnZXMgYnkgZGVmYXVs dC4KPiA+ID4gPiA+IExldCdzIGNyZWF0ZSBhcmNoLXNwZWNpZmljIGhvb2tzIHNvIHRoYXQgZGlm ZmVyZW50IGFyY2hpdGVjdHVyZXMgY2FuCj4gPiA+ID4gPiBwcm92aWRlIGRpZmZlcmVudCBpbXBs ZW1lbnRhdGlvbnMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEZpbGlwcG8g U2lyb25pIDxzaXJvbmlAYW1hem9uLmRlPgo+ID4gPiA+IEkgdGhpbmsgdGhpcyBuZWVkcyBzb21l dGhpbmcgYWtpbiB0bwo+ID4gPiA+IAo+ID4gPiA+ICAgaHR0cHM6Ly93d3cua2VybmVsLm9yZy9k b2MvRG9jdW1lbnRhdGlvbi9BQkkvc3RhYmxlL3N5c2ZzLWh5cGVydmlzb3IteGVuCj4gPiA+ID4g Cj4gPiA+ID4gdG8gZG9jdW1lbnQgd2hpY2ggZmlsZXMgYXJlIGF2YWlsYWJsZS4KPiA+ID4gPiAK PiA+ID4gPiA+IAo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiB2MjoKPiA+ID4gPiA+ICogbW92ZSB0 aGUgcmV0cmlldmFsIG9mIHRoZSBWTSBVVUlEIG91dCBvZiB1dWlkX3Nob3cgYW5kIGludG8KPiA+ ID4gPiA+ICAga3ZtX3BhcmFfZ2V0X3V1aWQsIHdoaWNoIGlzIGEgd2VhayBmdW5jdGlvbiB0aGF0 IGNhbiBiZSBvdmVyd3JpdHRlbgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBkcml2ZXJzL0tjb25maWcg ICAgICAgICAgICAgIHwgIDIgKysKPiA+ID4gPiA+IGRyaXZlcnMvTWFrZWZpbGUgICAgICAgICAg ICAgfCAgMiArKwo+ID4gPiA+ID4gZHJpdmVycy9rdm0vS2NvbmZpZyAgICAgICAgICB8IDE0ICsr KysrKysrKysrKysrCj4gPiA+ID4gPiBkcml2ZXJzL2t2bS9NYWtlZmlsZSAgICAgICAgIHwgIDEg Kwo+ID4gPiA+ID4gZHJpdmVycy9rdm0vc3lzLWh5cGVydmlzb3IuYyB8IDMwICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ID4gNSBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRp b25zKCspCj4gPiA+ID4gPiBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9rdm0vS2NvbmZpZwo+ ID4gPiA+ID4gY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMva3ZtL01ha2VmaWxlCj4gPiA+ID4g PiBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9rdm0vc3lzLWh5cGVydmlzb3IuYwo+ID4gPiA+ ID4gCj4gPiA+ID4gWy4uLl0KPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gKwo+ID4gPiA+ ID4gK19fd2VhayBjb25zdCBjaGFyICprdm1fcGFyYV9nZXRfdXVpZCh2b2lkKQo+ID4gPiA+ID4g K3sKPiA+ID4gPiA+ICsJcmV0dXJuIE5VTEw7Cj4gPiA+ID4gPiArfQo+ID4gPiA+ID4gKwo+ID4g PiA+ID4gK3N0YXRpYyBzc2l6ZV90IHV1aWRfc2hvdyhzdHJ1Y3Qga29iamVjdCAqb2JqLAo+ID4g PiA+ID4gKwkJCSBzdHJ1Y3Qga29ial9hdHRyaWJ1dGUgKmF0dHIsCj4gPiA+ID4gPiArCQkJIGNo YXIgKmJ1ZikKPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiArCWNvbnN0IGNoYXIgKnV1aWQgPSBrdm1f cGFyYV9nZXRfdXVpZCgpOwo+ID4gPiA+ID4gKwlyZXR1cm4gc3ByaW50ZihidWYsICIlc1xuIiwg dXVpZCk7Cj4gPiA+ID4gVGhlIHVzdWFsIHJldHVybiB2YWx1ZSBmb3IgdGhlIFhlbiAvc3lzL2h5 cGVydmlzb3IgaW50ZXJmYWNlIGlzCj4gPiA+ID4gIjxkZW5pZWQ+Ii4gV291bGRuJ3QgaXQgbWFr ZSBzZW5zZSB0byBmb2xsb3cgdGhhdCBwYXR0ZXJuIGZvciB0aGUgS1ZNCj4gPiA+ID4gb25lIHRv bz8gQ3VycmVudGx5LCBpZiB3ZSBjYW4gbm90IGRldGVybWluZSB0aGUgVVVJRCB0aGlzIHdpbGwg anVzdAo+ID4gPiA+IHJldHVybiAobnVsbCkuCj4gPiA+ID4gCj4gPiA+ID4gT3RoZXJ3aXNlLCBs b29rcyBnb29kIHRvIG1lLiBBcmUgeW91IGF3YXJlIG9mIGFueSBvdGhlciBmaWxlcyB3ZSBzaG91 bGQKPiA+ID4gPiBwcm92aWRlPyBBbHNvLCBpcyB0aGVyZSBhbnkgcmVhc29uIG5vdCB0byBpbXBs ZW1lbnQgQVJNIGFzIHdlbGwgd2hpbGUgYXQgaXQ/Cj4gPiA+ID4gCj4gPiA+ID4gQWxleAo+ID4g PiBUaGlzIG9yaWdpbmF0ZWQgZnJvbSBhIGN1c3RvbWVyIHJlcXVlc3QgdGhhdCB3YXMgdXNpbmcg L3N5cy9oeXBlcnZpc29yL3V1aWQuCj4gPiA+IE15IGd1ZXNzIGlzIHRoYXQgd2Ugd291bGQgd2Fu dCB0byBleHBvc2UgInR5cGUiIGFuZCAidmVyc2lvbiIgbW92aW5nCj4gPiA+IGZvcndhcmQgYW5k IHRoYXQncyB3aGVuIHdlIGh5cGVydmlzb3IgaG9va3Mgd2lsbCBiZSB1c2VmdWwgb24gdG9wCj4g PiA+IG9mIGFyY2ggaG9va3MuCj4gPiA+IAo+ID4gPiBPbiBhIGRpZmZlcmVudCBub3RlLCBhbnkg aWRlYSBob3cgdG8gY2hlY2sgd2hldGhlciB0aGUgT1MgaXMgcnVubmluZwo+ID4gPiB2aXJ0dWFs aXplZCBvbiBLVk0gb24gQVJNIGFuZCBBUk02ND8gIGt2bV9wYXJhX2F2YWlsYWJsZSgpIGlzbid0 IGFuCj4gPiAKPiA+IAo+ID4gWWVhaCwgQVJNIGRvZXNuJ3QgaGF2ZSBhbnkgS1ZNIFBWIEZXSVcu IEkgYWxzbyBjYW4ndCBmaW5kIGFueSBleHBsaWNpdCAKPiA+IGhpbnQgcGFzc2VkIGludG8gZ3Vl c3RzIHRoYXQgd2UgYXJlIGluZGVlZCBydW5uaW5nIGluIEtWTS4gVGhlIGNsb3Nlc3QgCj4gPiB0 aGluZyBJIGNhbiBzZWUgaXMgdGhlIFNNQklPUyBwcm9kdWN0IGlkZW50aWZpZXIgaW4gUUVNVSB3 aGljaCBnZXRzIAo+ID4gcGF0Y2hlZCB0byAiS1ZNIFZpcnR1YWwgTWFjaGluZSIuIE1heWJlIHdl J2xsIGhhdmUgdG8gZG8gd2l0aCB0aGF0IGZvciAKPiA+IHRoZSBzYWtlIG9mIGJhY2t3YXJkcyBj b21wYXRpYmlsaXR5IC4uLgo+IAo+IEhvdyBhYm91dCAicHNjaV9vcHMuY29uZHVpdCIgKFBTQ0lf Q09ORFVJVF9IVkMgdnMgUFNDSV9DT05EVUlUX1NNQyk/CgpbY2hhbmdpbmcgQ2hyaXN0b2ZmZXIg YWRkcmVzcyBmb3Igb25lIHRoYXQgYWN0dWFsbHldCgpUaGF0J3Mgbm90IGVub3VnaC4gSFZDIG9u bHkgdGVsbHMgeW91IGFib3V0IHRoZSBmYWN0IHRoYXQgeW91IGFyZQpydW5uaW5nIHVuZGVyIGEg aHlwZXJ2aXNvciB3aXRob3V0IHRlbGxpbmcgeW91IHdoaWNoIG9uZSwgYW5kIGRvZXNuJ3QKY2F0 ZXIgZm9yIG5lc3RlZCB2aXJ0LiBJdCBkb2Vzbid0IHRlbGwgeW91IGFueXRoaW5nIGFib3V0IGEg aHlwZXJ2aXNvcgp0aGF0IGRvZXNuJ3QgdXNlIEhWQyBhdCBhbGwgKGl0IGNvdWxkIG9ubHkgYWR2 ZXJ0aXNlIFNNQywgZm9yIGV4YW1wbGUpLgoKSWYgeW91IHdhbnQgdG8gaWRlbnRpZnkgdGhlIGh5 cGVydmlzb3IsIGRvbid0IGd1ZXNzLiBVc2UgdGhlIFNNQ0NDCmRpc2NvdmVyeSBtZWNoYW5pc20s IGFuZCBtYWtlIEtWTSBpZGVudGlmeSBpdHNlbGYgYXMgdGhlIGh5cGVydmlzb3IuIEkKaGF2ZSBz b21lIGNvZGUgZm9yIHRoYXQgc3Rhc2hlZCBhdCBbMV0gYXMgcGFydCBvZiBhbiB1bnJlbGF0ZWQg c2VyaWVzLAp3aGljaCBJIG1heSBwb3N0IGF0IHNvbWUgcG9pbnQuCgpUaGFua3MsCgoJTS4KClsx XSBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9tYXovYXJt LXBsYXRmb3Jtcy5naXQvbG9nLz9oPWt2bS1hcm02NC9wdmN5CgotLSAKSmF6eiBpcyBub3QgZGVh ZCwgaXQganVzdCBzbWVsbCBmdW5ueS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5m by94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE2CC04AB6 for ; Fri, 31 May 2019 09:38:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46C16266FD for ; Fri, 31 May 2019 09:38:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbfEaJiq (ORCPT ); Fri, 31 May 2019 05:38:46 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48932 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfEaJiq (ORCPT ); Fri, 31 May 2019 05:38:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C554341; Fri, 31 May 2019 02:38:45 -0700 (PDT) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E33F13F59C; Fri, 31 May 2019 02:38:42 -0700 (PDT) Date: Fri, 31 May 2019 10:38:40 +0100 Message-ID: <86muj36k0v.wl-marc.zyngier@arm.com> From: Marc Zyngier To: "Raslan, KarimAllah" Cc: "Sironi, Filippo" , "Graf, Alexander" , "boris.ostrovsky@oracle.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "cohuck@redhat.com" , "konrad.wilk@oracle.com" , "borntraeger@de.ibm.com" , "xen-devel@lists.xenproject.org" , Christoffer Dall Subject: Re: [PATCH v2 1/2] KVM: Start populating /sys/hypervisor with KVM entries In-Reply-To: <1559293922.14762.2.camel@amazon.de> References: <1539078879-4372-1-git-send-email-sironi@amazon.de> <1557847002-23519-1-git-send-email-sironi@amazon.de> <1557847002-23519-2-git-send-email-sironi@amazon.de> <3D2C4EE3-1C2E-4032-9964-31A066E542AA@amazon.de> <6b3dadf9-6240-6440-b784-50bec605bf2c@amazon.com> <1559293922.14762.2.camel@amazon.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 31 May 2019 10:12:03 +0100, "Raslan, KarimAllah" wrote: > > On Fri, 2019-05-31 at 11:06 +0200, Alexander Graf wrote: > > On 17.05.19 17:41, Sironi, Filippo wrote: > > > > > > > > > > > On 16. May 2019, at 15:50, Graf, Alexander wrote: > > > > > > > > On 14.05.19 08:16, Filippo Sironi wrote: > > > > > > > > > > Start populating /sys/hypervisor with KVM entries when we're running on > > > > > KVM. This is to replicate functionality that's available when we're > > > > > running on Xen. > > > > > > > > > > Start with /sys/hypervisor/uuid, which users prefer over > > > > > /sys/devices/virtual/dmi/id/product_uuid as a way to recognize a virtual > > > > > machine, since it's also available when running on Xen HVM and on Xen PV > > > > > and, on top of that doesn't require root privileges by default. > > > > > Let's create arch-specific hooks so that different architectures can > > > > > provide different implementations. > > > > > > > > > > Signed-off-by: Filippo Sironi > > > > I think this needs something akin to > > > > > > > > https://www.kernel.org/doc/Documentation/ABI/stable/sysfs-hypervisor-xen > > > > > > > > to document which files are available. > > > > > > > > > > > > > > --- > > > > > v2: > > > > > * move the retrieval of the VM UUID out of uuid_show and into > > > > > kvm_para_get_uuid, which is a weak function that can be overwritten > > > > > > > > > > drivers/Kconfig | 2 ++ > > > > > drivers/Makefile | 2 ++ > > > > > drivers/kvm/Kconfig | 14 ++++++++++++++ > > > > > drivers/kvm/Makefile | 1 + > > > > > drivers/kvm/sys-hypervisor.c | 30 ++++++++++++++++++++++++++++++ > > > > > 5 files changed, 49 insertions(+) > > > > > create mode 100644 drivers/kvm/Kconfig > > > > > create mode 100644 drivers/kvm/Makefile > > > > > create mode 100644 drivers/kvm/sys-hypervisor.c > > > > > > > > > [...] > > > > > > > > > > > > > > + > > > > > +__weak const char *kvm_para_get_uuid(void) > > > > > +{ > > > > > + return NULL; > > > > > +} > > > > > + > > > > > +static ssize_t uuid_show(struct kobject *obj, > > > > > + struct kobj_attribute *attr, > > > > > + char *buf) > > > > > +{ > > > > > + const char *uuid = kvm_para_get_uuid(); > > > > > + return sprintf(buf, "%s\n", uuid); > > > > The usual return value for the Xen /sys/hypervisor interface is > > > > "". Wouldn't it make sense to follow that pattern for the KVM > > > > one too? Currently, if we can not determine the UUID this will just > > > > return (null). > > > > > > > > Otherwise, looks good to me. Are you aware of any other files we should > > > > provide? Also, is there any reason not to implement ARM as well while at it? > > > > > > > > Alex > > > This originated from a customer request that was using /sys/hypervisor/uuid. > > > My guess is that we would want to expose "type" and "version" moving > > > forward and that's when we hypervisor hooks will be useful on top > > > of arch hooks. > > > > > > On a different note, any idea how to check whether the OS is running > > > virtualized on KVM on ARM and ARM64? kvm_para_available() isn't an > > > > > > Yeah, ARM doesn't have any KVM PV FWIW. I also can't find any explicit > > hint passed into guests that we are indeed running in KVM. The closest > > thing I can see is the SMBIOS product identifier in QEMU which gets > > patched to "KVM Virtual Machine". Maybe we'll have to do with that for > > the sake of backwards compatibility ... > > How about "psci_ops.conduit" (PSCI_CONDUIT_HVC vs PSCI_CONDUIT_SMC)? [changing Christoffer address for one that actually] That's not enough. HVC only tells you about the fact that you are running under a hypervisor without telling you which one, and doesn't cater for nested virt. It doesn't tell you anything about a hypervisor that doesn't use HVC at all (it could only advertise SMC, for example). If you want to identify the hypervisor, don't guess. Use the SMCCC discovery mechanism, and make KVM identify itself as the hypervisor. I have some code for that stashed at [1] as part of an unrelated series, which I may post at some point. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/pvcy -- Jazz is not dead, it just smell funny.