From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: enable semaphores on per-device defaults Date: Mon, 21 Nov 2011 08:46:42 -0800 Message-ID: <86mxbpift9.fsf@sumi.keithp.com> References: <1321880629-23854-1-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0829979509==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 085B19E807 for ; Mon, 21 Nov 2011 08:46:52 -0800 (PST) In-Reply-To: <1321880629-23854-1-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky , Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org --===============0829979509== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 21 Nov 2011 11:03:49 -0200, Eugeni Dodonov wrote: > -unsigned int i915_semaphores __read_mostly =3D 0; > +unsigned int i915_semaphores __read_mostly =3D -1; That better be signed or it's not going to compare well with -1 Otherwise, this looks good to me. Reviewed-by: Keith Packard =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTsqAcjYtFsjWk68qAQhEOg//Sf/BBvAV4y/c5LZABJfxWljmYJJrUgmw HAxpyWrqvrCqQzQEQylPGt/1FwW9yFXi5gP0yOLgf9mIomwJSX6k8AJmYUO0TcRb OwZI8apisBdo946RaK4EcGwfUTUMxRoQapDwDaIPKR7Rc9zFLDHK4iKbKPd2HHAC UuAnwTHdw6yXfzGgMyDHrgpnaacxORb2VKVOsvSrMk5D/1+T0PRz8DelS+aMOLlO E7uzHzDUTlHCt+oQOWsmZV0f6Vsb3J6rLEP0ZQllFh6l/YKdfvYPBOdhXrqC4Ko9 FDtlUUzddfrx44p535hzxveOQXS/AEQQqM1w6PlWQGIGb/BonMhb+c+qkqtrfNM4 y2Vi13ArIqQhVjPfVjZX7lDc+Gb4p8IgMmgJemnbrNjr2BujNBQJZRdumEBF6QMo MJlUyVwLFdLsTx9Hi0mIcKUHVCrwizG566gR07HLQ2Ke3PV0d8MQGzxbmAHUNtY1 RWAaympgf8/9M/ReFGrQRD6sJflgCyIu1K64+s8V3S+Q/dTEo+MGCX2xyAsaixyN Irk+ymgqQYETTDtk+5xxFPi2A24qQDV4YhqNE+PiQ3noosR/2NCmRZaFl4PRuvs3 ibepXYuXJRRQlP/wBBGRKBJ89G4AicvYmV2dc7fVCEMx1NaBtHcZqavlEJxyAXtZ sBSrMybWHTQ= =DwN4 -----END PGP SIGNATURE----- --=-=-=-- --===============0829979509== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0829979509==--