From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86A00C3DA6E for ; Tue, 9 Jan 2024 03:28:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 759E387855; Tue, 9 Jan 2024 04:27:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="IICRPmoL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06CDE807EC; Tue, 9 Jan 2024 03:24:37 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7F9387718 for ; Tue, 9 Jan 2024 03:24:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=j-humphreys@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4092ORDR038803; Mon, 8 Jan 2024 20:24:27 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704767067; bh=ugCKvKEFh0tfpa4D0lHvm8lvSpTxut8NfiKyfDlNDns=; h=From:To:CC:Subject:In-Reply-To:References:Date; b=IICRPmoLP8PB+T8sqqC+jXIahBYNc5r5b/ZF299VBMHEwD1gxBCbMuqT5wEFktYIj GLkZbU6ur5FXclXbnZ6ziRmcsWodGKDkWL4LiLVJ4YxGOJo+oaEgOkj7jpElt26/0M OGiM2oKjSuqOk88Wvzx6owEUJwdzFbpdnK0qkLoQ= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4092ORZt107031 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jan 2024 20:24:27 -0600 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 8 Jan 2024 20:24:27 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 8 Jan 2024 20:24:27 -0600 Received: from localhost (udb0321960.dhcp.ti.com [128.247.81.241]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4092OQVp093388; Mon, 8 Jan 2024 20:24:26 -0600 From: Jon Humphreys To: Nishanth Menon , Tom Rini CC: Kamlesh Gurudasani , Sinthu Raja , Neha Malcom Francis , Heinrich Schuchardt , Roger Quadros , Simon Glass , Andrew Davis , Mattijs Korpershoek , Nikhil M Jain , "Manorit Chawdhry" , Bryan Brattlof , Robert Nelson , , Nishanth Menon Subject: Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script In-Reply-To: <20240108173301.2692332-9-nm@ti.com> References: <20240108173301.2692332-1-nm@ti.com> <20240108173301.2692332-9-nm@ti.com> Date: Mon, 8 Jan 2024 20:24:26 -0600 Message-ID: <86o7dvdz1h.fsf@udb0321960.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Approved-At: Tue, 09 Jan 2024 04:27:54 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Nishanth Menon writes: > Stop using the findfdt script and switch to setting the fdtfile from C > code. > > While at this, replace findfdt in environment with a warning as it is > no longer needed > > Signed-off-by: Nishanth Menon > --- > board/beagle/beagleboneai64/beagleboneai64.c | 14 ++++++++++++++ > board/beagle/beagleboneai64/beagleboneai64.env | 1 - > configs/j721e_beagleboneai64_a72_defconfig | 3 ++- > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/board/beagle/beagleboneai64/beagleboneai64.c b/board/beagle/beagleboneai64/beagleboneai64.c > index c8c1c78ae5a2..1982f738b04e 100644 > --- a/board/beagle/beagleboneai64/beagleboneai64.c > +++ b/board/beagle/beagleboneai64/beagleboneai64.c > @@ -28,3 +28,17 @@ int dram_init_banksize(void) > { > return fdtdec_setup_memory_banksize(); > } > + > +#ifdef CONFIG_BOARD_LATE_INIT > +int board_late_init(void) > +{ > + char fdtfile[50]; > + > + snprintf(fdtfile, sizeof(fdtfile), "%s/%s.dtb", > + CONFIG_TI_EVM_FDT_FOLDER_PATH, CONFIG_DEFAULT_DEVICE_TREE); This would set the board to using the control DT, not boot DT. Is that what you meant? But anyway, why not just hard code the FDT path/name here since there is only one for this board? I don't see the value in the extra logic of using the config values (or having a fdt_map). (Same for beagleplay) > + > + env_set("fdtfile", fdtfile); > + > + return 0; > +} > +#endif > diff --git a/board/beagle/beagleboneai64/beagleboneai64.env b/board/beagle/beagleboneai64/beagleboneai64.env > index 4f0a94a8113e..647b25d14c8e 100644 > --- a/board/beagle/beagleboneai64/beagleboneai64.env > +++ b/board/beagle/beagleboneai64/beagleboneai64.env > @@ -1,5 +1,4 @@ > #include > -#include > #include > > name_kern=Image > diff --git a/configs/j721e_beagleboneai64_a72_defconfig b/configs/j721e_beagleboneai64_a72_defconfig > index 959f86844d32..9e53658eacb9 100644 > --- a/configs/j721e_beagleboneai64_a72_defconfig > +++ b/configs/j721e_beagleboneai64_a72_defconfig > @@ -34,7 +34,8 @@ CONFIG_AUTOBOOT_PROMPT="Press SPACE to abort autoboot in %d seconds\n" > CONFIG_AUTOBOOT_DELAY_STR="d" > CONFIG_AUTOBOOT_STOP_STR=" " > CONFIG_OF_SYSTEM_SETUP=y > -CONFIG_BOOTCOMMAND="run set_led_state_start_load;run findfdt; run envboot; bootflow scan -lb;run set_led_state_fail_load" > +CONFIG_BOOTCOMMAND="run set_led_state_start_load; run envboot; bootflow scan -lb;run set_led_state_fail_load" > +CONFIG_BOARD_LATE_INIT=y > CONFIG_LOGLEVEL=7 > CONFIG_SPL_MAX_SIZE=0xc0000 > CONFIG_SPL_HAS_BSS_LINKER_SECTION=y > -- > 2.43.0