From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D81CA9EC3 for ; Tue, 29 Oct 2019 09:04:46 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D76102083E for ; Tue, 29 Oct 2019 09:04:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D76102083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 32CB34A52E; Tue, 29 Oct 2019 05:04:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kG9rjH4C1B6I; Tue, 29 Oct 2019 05:04:44 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1D9384A535; Tue, 29 Oct 2019 05:04:44 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EFCB34A4F6 for ; Tue, 29 Oct 2019 05:04:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kyqGQkdvLyGy for ; Tue, 29 Oct 2019 05:04:41 -0400 (EDT) Received: from inca-roads.misterjones.org (inca-roads.misterjones.org [213.251.177.50]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CFFC84A483 for ; Tue, 29 Oct 2019 05:04:41 -0400 (EDT) Received: from [91.217.168.176] (helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iPNQZ-0005PR-7S; Tue, 29 Oct 2019 10:04:35 +0100 Date: Tue, 29 Oct 2019 09:04:34 +0000 Message-ID: <86o8xzylb1.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Subject: Re: [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo In-Reply-To: <20191029071919.177-3-yuzenghui@huawei.com> References: <20191029071919.177-1-yuzenghui@huawei.com> <20191029071919.177-3-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 91.217.168.176 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Zenghui, On Tue, 29 Oct 2019 07:19:18 +0000, Zenghui Yu wrote: > > s/vgic_its_save_pending_tables/vgic_v3_save_pending_tables/ > s/then/the/ > > Signed-off-by: Zenghui Yu > --- > include/kvm/arm_vgic.h | 2 +- > virt/kvm/arm/vgic/vgic-v3.c | 2 +- > virt/kvm/arm/vgic/vgic-v4.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 0fb240ec0a2a..01f8b3739a09 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -240,7 +240,7 @@ struct vgic_dist { > * Contains the attributes and gpa of the LPI configuration table. > * Since we report GICR_TYPER.CommonLPIAff as 0b00, we can share > * one address across all redistributors. > - * GICv3 spec: 6.1.2 "LPI Configuration tables" > + * GICv3 spec "LPI Configuration tables" Why the change here? Pointing to the chapter in the spec is pretty helpful, given that it is 800 pages long (although it should mention what revision of the spec this refers to). For example, it should say something like "IHI 0069E 6.1.1 ...". Thanks, M. -- Jazz is not dead, it just smells funny. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BF2CA9EAE for ; Tue, 29 Oct 2019 09:04:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F26620717 for ; Tue, 29 Oct 2019 09:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i8Hfu52h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F26620717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rD5fkTMBmRiADrpfIUAw7+oV1f6jqrhnNs847yeWynA=; b=i8Hfu52hR1rjYl IQ9vGmRFdDUG/mDYvukZyNcBq+2MFss83k6ZhG7WRDPdYCXTcUfGaM+bsk2K6B4r/tTpQI73NhvFF scYRZVz4Jp2TCia7nJkJrYETp39PHUJufMQQimNG60xv4pYqvhRSDpEFtRDh813aWqEWXKm0xyska wWTrM392JizGZZCT/2PyIhTdykEWJs/XPScBrkey0h87pdiLD7MypOp+PXQky5tRFKy/TcRj/FkxO uodKJiB4rAa9acZ2d6oVFZk+BBNU4caAnGgK4ozq82RtO4vmfjXYF90ADTWxSzemX7AdD5KRH00Lt x/kZ7GTKwOKkMdViQsDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPNQh-0004fh-UQ; Tue, 29 Oct 2019 09:04:43 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPNQd-0004eS-Qd for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 09:04:41 +0000 Received: from [91.217.168.176] (helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iPNQZ-0005PR-7S; Tue, 29 Oct 2019 10:04:35 +0100 Date: Tue, 29 Oct 2019 09:04:34 +0000 Message-ID: <86o8xzylb1.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Subject: Re: [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo In-Reply-To: <20191029071919.177-3-yuzenghui@huawei.com> References: <20191029071919.177-1-yuzenghui@huawei.com> <20191029071919.177-3-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 91.217.168.176 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_020440_014414_CC033C66 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, linux-kernel@vger.kernel.org, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, wanghaibin.wang@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Zenghui, On Tue, 29 Oct 2019 07:19:18 +0000, Zenghui Yu wrote: > > s/vgic_its_save_pending_tables/vgic_v3_save_pending_tables/ > s/then/the/ > > Signed-off-by: Zenghui Yu > --- > include/kvm/arm_vgic.h | 2 +- > virt/kvm/arm/vgic/vgic-v3.c | 2 +- > virt/kvm/arm/vgic/vgic-v4.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 0fb240ec0a2a..01f8b3739a09 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -240,7 +240,7 @@ struct vgic_dist { > * Contains the attributes and gpa of the LPI configuration table. > * Since we report GICR_TYPER.CommonLPIAff as 0b00, we can share > * one address across all redistributors. > - * GICv3 spec: 6.1.2 "LPI Configuration tables" > + * GICv3 spec "LPI Configuration tables" Why the change here? Pointing to the chapter in the spec is pretty helpful, given that it is 800 pages long (although it should mention what revision of the spec this refers to). For example, it should say something like "IHI 0069E 6.1.1 ...". Thanks, M. -- Jazz is not dead, it just smells funny. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB9CC47E49 for ; Tue, 29 Oct 2019 09:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D824D20717 for ; Tue, 29 Oct 2019 09:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572339885; bh=w2z3QwyvjxWb031hC33QUmA8g7oNLT5WYBU21sxdGF0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=aavWB7zz+eaJjkC2mH8Su8i87pbSXbt1GNdJABK2EWoPS2ZlWmvLhEerWYRe73VYD cf0auUWR6Sra95lQBiCCSFreZ9kslULiL632I+ult9C/brxObcHpKGDrxQFAoWBlyo feGaFXdab4qRSS+jHKjo+QtPb20s6Q/dKKN6So9E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730811AbfJ2JEn (ORCPT ); Tue, 29 Oct 2019 05:04:43 -0400 Received: from inca-roads.misterjones.org ([213.251.177.50]:35381 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbfJ2JEn (ORCPT ); Tue, 29 Oct 2019 05:04:43 -0400 Received: from [91.217.168.176] (helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iPNQZ-0005PR-7S; Tue, 29 Oct 2019 10:04:35 +0100 Date: Tue, 29 Oct 2019 09:04:34 +0000 Message-ID: <86o8xzylb1.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: , , , , , , , Subject: Re: [PATCH 2/3] KVM: arm/arm64: vgic: Fix some comments typo In-Reply-To: <20191029071919.177-3-yuzenghui@huawei.com> References: <20191029071919.177-1-yuzenghui@huawei.com> <20191029071919.177-3-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 91.217.168.176 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zenghui, On Tue, 29 Oct 2019 07:19:18 +0000, Zenghui Yu wrote: > > s/vgic_its_save_pending_tables/vgic_v3_save_pending_tables/ > s/then/the/ > > Signed-off-by: Zenghui Yu > --- > include/kvm/arm_vgic.h | 2 +- > virt/kvm/arm/vgic/vgic-v3.c | 2 +- > virt/kvm/arm/vgic/vgic-v4.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 0fb240ec0a2a..01f8b3739a09 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -240,7 +240,7 @@ struct vgic_dist { > * Contains the attributes and gpa of the LPI configuration table. > * Since we report GICR_TYPER.CommonLPIAff as 0b00, we can share > * one address across all redistributors. > - * GICv3 spec: 6.1.2 "LPI Configuration tables" > + * GICv3 spec "LPI Configuration tables" Why the change here? Pointing to the chapter in the spec is pretty helpful, given that it is 800 pages long (although it should mention what revision of the spec this refers to). For example, it should say something like "IHI 0069E 6.1.1 ...". Thanks, M. -- Jazz is not dead, it just smells funny.