From: Marc Zyngier <maz@kernel.org>
To: Wei-Lin Chang <r09922117@csie.ntu.edu.tw>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org,
Oliver Upton <oliver.upton@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Jintack Lim <jintack@cs.columbia.edu>,
Christoffer Dall <christoffer.dall@arm.com>
Subject: Re: [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put_nested()
Date: Mon, 16 Jun 2025 18:00:52 +0100 [thread overview]
Message-ID: <86plf3d3jv.wl-maz@kernel.org> (raw)
In-Reply-To: <2p4urq6ij5zq77c7viydmqqaj2doeyja43khvcjgn5pkpe7saz@eyfvuykscn22>
On Mon, 16 Jun 2025 15:34:58 +0100,
Wei-Lin Chang <r09922117@csie.ntu.edu.tw> wrote:
>
> On Mon, Jun 16, 2025 at 11:54:57AM +0100, Marc Zyngier wrote:
>
> > +static u64 translate_lr_hw_bit(struct kvm_vcpu *vcpu, u64 lr)
>
> I believe translate_lr_pintid() better describes what this function is
> doing.
Ah, you too noticed that I am terrible at naming things? ;-)
Agreed, this is a better name, and I'll gladly apply your suggestion.
>
> For everything else, I don't spot any issues after review.
>
> Reviewed-by: Wei-Lin Chang <r09922117@csie.ntu.edu.tw>
Thanks again!
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-06-16 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 14:57 [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put_nested() Wei-Lin Chang
2025-06-16 5:55 ` Oliver Upton
2025-06-16 14:40 ` Wei-Lin Chang
2025-06-16 10:54 ` Marc Zyngier
2025-06-16 14:34 ` Wei-Lin Chang
2025-06-16 17:00 ` Marc Zyngier [this message]
2025-06-17 4:53 ` Oliver Upton
2025-06-17 9:26 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plf3d3jv.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=jintack@cs.columbia.edu \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=r09922117@csie.ntu.edu.tw \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.