From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: add multi-threaded forcewake support Date: Fri, 18 Nov 2011 14:35:22 -0800 Message-ID: <86pqgpkqj9.fsf@sumi.keithp.com> References: <20111118113632.594717c8@jbarnes-desktop> <86y5vdks4j.fsf@sumi.keithp.com> <20111118141203.14ddde98@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1400481469==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 94BD69E7B3 for ; Fri, 18 Nov 2011 14:35:32 -0800 (PST) In-Reply-To: <20111118141203.14ddde98@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1400481469== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 18 Nov 2011 14:12:03 -0800, Jesse Barnes = wrote: > No this one should be looking at the bottom bit, so I think it's ok. Sorry, bad mail edit. There's one << 15 in both force_wake_mt_put and force_wake_mt_get and they both need to be << 16: +void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv) +{ + int count; + + count =3D 0; + while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1)) + udelay(10); + + I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 1); <<16 + POSTING_READ(FORCEWAKE_MT); + + count =3D 0; + while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1) =3D=3D 0) + udelay(10); +} + ... +void __gen6_gt_force_wake_mt_put(struct drm_i915_private *dev_priv) +{ + I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 0); <<16 + POSTING_READ(FORCEWAKE_MT); +} + > Cool, hope it'll help others too. Let me know when you hear back from the VPG folks about how we're supposed to know which method to use. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTsbdqjYtFsjWk68qAQjumBAAn24eLE3EOibnqBGnhTldDLAOBWnhZ4Zh pUixBC03W97pmtrXCFYs7k9BzDKeVGfzHLCUi2BuyTxiUTh0Ojo7X138LPZW8Aq9 EUpdZ5Izksv2U2RVWHYNj+ZG8k0igno6OihvA5rvNEiq/nY6hv9SKRTAlOdHdOXl ULEQq3LGsIw2f493SPwh/INfibeQxnO4GGEgB6eAHrndg60rISimo20yNM6uadJ3 VaK405E/uiWHT06snOAWSy6pDF20zkxepbf9wrgtY4K1Ku/6d4uHIufgyv6D/PDW MLJX1/eQvDss/8KlTAKxlmlvcGaATyFCTIL0Hq6yK6uYjSrnBez3mAy4YZdCpY6+ IjMg+THf5G1XLSJfEYvlKM7oJKpbsJcRcwvRuCp0gVuAVgxkG6W8Y8jh/mU16bOz su6wx37ewJ1rVeGPk0DKf99Ev8kMnjLKKfvaXy2GdaOs55IQjhd2cu7ixv1DYHoJ Azzhpq57hmVYHY40lW0Czp6danQoa+veJXIa6zbajZ6pBmANWYkKoiFLuBwXN/wc lKfZD9/s9U8Xf0mfVgYMiP6qk6/u/p5Fv2J9hxIdqlidoxYmcYXTpmOHeHRUbyIX pDUp2iK3SYT/psCd+bh96uv8bDpBJcC56AQruKx6RDT43j4E2TssZmffi9U5Rsub FPlC5qCY9VI= =87P4 -----END PGP SIGNATURE----- --=-=-=-- --===============1400481469== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1400481469==--