All of lore.kernel.org
 help / color / mirror / Atom feed
From: merlyn@stonehenge.com (Randal L. Schwartz)
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: "Terje Sten Bjerkseth" <terje@bjerkseth.org>,
	"Linus Torvalds" <torvalds@osdl.org>,
	"Junio C Hamano" <junkio@cox.net>,
	git@vger.kernel.org
Subject: Re: [BUG] daemon.c blows up on OSX
Date: 20 Dec 2006 17:35:08 -0800	[thread overview]
Message-ID: <86psaevxo3.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <24BF45E9-DD98-4609-9D65-B01EAA30CCA8@silverinsanity.com>

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

>>>>> "Brian" == Brian Gernhardt <benji@silverinsanity.com> writes:

Brian> On Dec 20, 2006, at 8:08 PM, Randal L. Schwartz wrote:

>>>>>>> "Terje" == Terje Sten Bjerkseth <terje@bjerkseth.org> writes:
>> 
>> 
Terje> +#ifndef __APPLE_CC__
Terje> #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500,  OpenBSD
Terje> needs 600 for S_ISLNK() */
Terje> #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
Terje> +#endif
Terje> #define _GNU_SOURCE
Terje> #define _BSD_SOURCE
Terje> -
>> 
>> I tried the moral equivalent of that, and it failed to compile many
>> other things then.  So that's not it.

Brian> Well, it seems to work for me as is (although I applied it manually  instead
Brian> of dealing with copy/paste with a patch).

I did it with #if 0 / #end instead of the __APPLE_CC__ symbol.
But, weirdly, now that I used the symbol, I get a good compile.

Does #if 0 not work? :)

Sorry for being objectionable earlier then.  I've attached the precise
patch I used and works and verified.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

[-- Attachment #2: 0001-patch-from-email.txt --]
[-- Type: text/plain, Size: 727 bytes --]

>From 9e3f88df3f6b17804f53fb497202f0879ea5e5f3 Mon Sep 17 00:00:00 2001
From: Randal L. Schwartz <merlyn@stonehenge.com>
Date: Wed, 20 Dec 2006 17:32:21 -0800
Subject: [PATCH] patch-from-email

---
 git-compat-util.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/git-compat-util.h b/git-compat-util.h
index bc296b3..41fa7f6 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -11,8 +11,10 @@
 
 #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))
 
+#ifndef __APPLE_CC__
 #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
 #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
+#endif
 #define _GNU_SOURCE
 #define _BSD_SOURCE
 
-- 
1.4.4.3.g9e3f8


  parent reply	other threads:[~2006-12-21  1:35 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 20:48 What's in git.git (stable), and Announcing GIT 1.4.4.3 Junio C Hamano
2006-12-20 22:04 ` Randal L. Schwartz
2006-12-20 22:04   ` Randal L. Schwartz
2006-12-20 22:14   ` Linus Torvalds
2006-12-20 22:14     ` Linus Torvalds
2006-12-20 22:20     ` [BUG] daemon.c blows up on OSX (was Re: What's in git.git (stable), and Announcing GIT 1.4.4.3) Randal L. Schwartz
2006-12-20 22:20       ` Randal L. Schwartz
2006-12-20 22:25       ` [BUG] daemon.c blows up on OSX Junio C Hamano
2006-12-20 22:35         ` Randal L. Schwartz
2006-12-20 22:35           ` Randal L. Schwartz
2006-12-20 22:44           ` Junio C Hamano
2006-12-20 22:46           ` Randal L. Schwartz
2006-12-20 22:46             ` Randal L. Schwartz
2006-12-20 23:03             ` Junio C Hamano
2006-12-20 23:25               ` Randal L. Schwartz
2006-12-20 23:34                 ` Randal L. Schwartz
2006-12-21  2:04                   ` Stefan Pfetzing
2006-12-20 23:07             ` Linus Torvalds
2006-12-20 23:07               ` Linus Torvalds
2006-12-20 23:17               ` Randal L. Schwartz
2006-12-20 23:17                 ` Randal L. Schwartz
2006-12-20 23:30                 ` Junio C Hamano
2006-12-20 23:41                 ` Linus Torvalds
2006-12-20 23:41                   ` Linus Torvalds
2006-12-21  0:36                   ` Terje Sten Bjerkseth
2006-12-21  0:44                     ` Junio C Hamano
2006-12-21  0:54                       ` Terje Sten Bjerkseth
2006-12-21  1:00                         ` Junio C Hamano
2006-12-21  1:20                           ` Randal L. Schwartz
2006-12-21  1:29                             ` Junio C Hamano
2006-12-21  1:35                             ` Terje Sten Bjerkseth
2006-12-21 10:39                               ` [PATCH] Do not define _XOPEN_SOURCE on MacOSX as it is too restricting there Marco Roeland
2006-12-21 11:28                                 ` [PATCH] Don't define _XOPEN_SOURCE on MacOSX and FreeBSD as it is too restricting Marco Roeland
2006-12-22  0:52                                   ` Junio C Hamano
2006-12-22  1:04                                     ` Shawn Pearce
2006-12-22  6:53                                     ` Rocco Rutte
2006-12-22  7:51                                     ` Marco Roeland
2006-12-22  8:37                                       ` Junio C Hamano
2006-12-22 11:47                                         ` Marco Roeland
2006-12-22 12:55                                           ` Rocco Rutte
2006-12-22 13:14                                             ` Marco Roeland
2007-01-03 15:25                       ` [BUG] daemon.c blows up on OSX Andreas Ericsson
2006-12-21  0:44                     ` Linus Torvalds
2006-12-21  1:07                       ` Randal L. Schwartz
2006-12-21  1:13                         ` Junio C Hamano
2006-12-21  1:08                     ` Randal L. Schwartz
     [not found]                       ` <24BF45E9-DD98-4609-9D65-B01EAA30CCA8@silverinsanity.com>
2006-12-21  1:35                         ` Randal L. Schwartz [this message]
2006-12-21  1:48                           ` Junio C Hamano
2006-12-21  1:50                             ` Randal L. Schwartz
2006-12-21  1:57                               ` Junio C Hamano
2006-12-20 23:58     ` What's in git.git (stable), and Announcing GIT 1.4.4.3 Randal L. Schwartz
2006-12-20 22:17   ` Junio C Hamano
2006-12-21  8:43     ` Johannes Schindelin
2006-12-21  8:52       ` Junio C Hamano
2006-12-20 22:19   ` Nicolas Pitre
2006-12-20 22:19     ` Nicolas Pitre
2006-12-21 11:38 ` Johannes Schindelin
  -- strict thread matches above, loose matches on Subject: below --
2006-12-21  0:56 [BUG] daemon.c blows up on OSX Brian Gernhardt
2006-12-21  2:52 Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86psaevxo3.fsf@blue.stonehenge.com \
    --to=merlyn@stonehenge.com \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=terje@bjerkseth.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.