From: Pratyush Yadav <pratyush@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pratyush Yadav <pratyush@kernel.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Arnd Bergmann <arnd@arndb.de>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kairui Song <kasong@tencent.com>,
David Hildenbrand <david@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Guo Weikang <guoweikang.kernel@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n
Date: Thu, 04 Dec 2025 14:31:47 +0100 [thread overview]
Message-ID: <86qztal6f0.fsf@kernel.org> (raw)
In-Reply-To: <20251204102905.1048000-1-arnd@kernel.org> (Arnd Bergmann's message of "Thu, 4 Dec 2025 11:28:59 +0100")
On Thu, Dec 04 2025, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added 'flags' variable is unused and causes a warning if
> CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed
> into does nothing:
>
> mm/shmem.c: In function '__shmem_file_setup':
> mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=unused-variable]
> 5816 | unsigned long flags = (vm_flags & VM_NORESERVE) ? SHMEM_F_NORESERVE : 0;
> | ^~~~~
>
> Replace the two macros with equivalent inline functions tto get the
> argument checking.
>
> Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2025-12-04 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 10:28 [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n Arnd Bergmann
2025-12-04 10:34 ` David Hildenbrand (Red Hat)
2025-12-04 10:41 ` Arnd Bergmann
2025-12-04 10:55 ` Mike Rapoport
2025-12-04 11:03 ` David Hildenbrand (Red Hat)
2025-12-04 13:34 ` Pratyush Yadav
2025-12-04 10:55 ` Mike Rapoport
2025-12-04 12:38 ` Baolin Wang
2025-12-04 13:31 ` Pratyush Yadav [this message]
2025-12-04 14:10 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86qztal6f0.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=guoweikang.kernel@gmail.com \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.