From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AF42D47F2; Mon, 11 Aug 2025 17:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754934672; cv=none; b=uq9Eq5nk6LghXtb6g9iu9uxFSVgsGrnQof4PYxXpr0p1l3ls2Iq1HAsDOSxKID/uVIPd/NUf7dc0Mrqrs8mWRqyhYZryDyJWRNjCTJxDa27uFJqmtj7ccZGx9R7Sqfxx9DAKCNFrHk3X01ZWnS14k50PKYE0PCVHqEV2NX4A+Sk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754934672; c=relaxed/simple; bh=Zzdn6Km1K+4KwSat9G4goOyX1m0FKWNRUjtzFo6LSmY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=CCagifWRnKIf/IYS6ugWezGGdQ5zo9JARlOhFjab59p3VtJ4WPPN7M6E7Z2jJA/V+Cn1WmRrvP/9nopoPatOeNYH+xj1V1ziEX3IrJXTdzXouHq+pxFFcUyQEmTieyYlyUFzTQTw73yJ3HJyPnNaM5ABVY48Derb1Ycbi4y4SOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QfqTeA/Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QfqTeA/Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50980C4CEED; Mon, 11 Aug 2025 17:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754934672; bh=Zzdn6Km1K+4KwSat9G4goOyX1m0FKWNRUjtzFo6LSmY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QfqTeA/ZJw3hLLA3KA0PsG1dBpYvf5q/1wQ81yPe1lsB6yMtR1wNvFxkaxwNRYocC aU/C+U8nXrYJiiXRTJoyNi5g2rvMufv4nNwKBznVNImdhEfboNrsXDzWvLBk20uZOn zWGw9WqFWcbZJg/AlKShjJtRV0MPis6ZZSatEJySyrwM49m5Wdfmf6fOQdqkDveLRs cXeC8A00vkfOCzQ2cQXEPezVHZsaNTRicvyH9efhGHxbB0aWV2o2d52OKaIuxujhQu t01IYePfp6XDQ9BJZaESOJ+gUraHnSH8W+mObYvR3cFN+Hj67B8KvgY4hH4aljIcP2 s5bxk7q0kuXBg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ulWft-006LvS-55; Mon, 11 Aug 2025 18:51:09 +0100 Date: Mon, 11 Aug 2025 18:51:08 +0100 Message-ID: <86qzxh927n.wl-maz@kernel.org> From: Marc Zyngier To: Yeoreum Yun Cc: catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, oliver.upton@linux.dev, anshuman.khandual@arm.com, robh@kernel.org, james.morse@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, ry111@xry111.site, Dave.Martin@arm.com, ahmed.genidi@arm.com, kevin.brodsky@arm.com, scott@os.amperecomputing.com, mbenes@suse.cz, james.clark@linaro.org, frederic@kernel.org, rafael@kernel.org, pavel@kernel.org, ryan.roberts@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v2 6/6] KVM: arm64: initialise SCTLR2_EL1 at __kvm_host_psci_cpu_entry() In-Reply-To: <20250811163340.1561893-7-yeoreum.yun@arm.com> References: <20250811163340.1561893-1-yeoreum.yun@arm.com> <20250811163340.1561893-7-yeoreum.yun@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yeoreum.yun@arm.com, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, oliver.upton@linux.dev, anshuman.khandual@arm.com, robh@kernel.org, james.morse@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, ry111@xry111.site, Dave.Martin@arm.com, ahmed.genidi@arm.com, kevin.brodsky@arm.com, scott@os.amperecomputing.com, mbenes@suse.cz, james.clark@linaro.org, frederic@kernel.org, rafael@kernel.org, pavel@kernel.org, ryan.roberts@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 11 Aug 2025 17:33:40 +0100, Yeoreum Yun wrote: > > initialise SCTLR2_EL1 at __kvm_host_psci_cpu_entry(). Same comment, I don't think this is an acceptable commit message. Please ask for help if you don't feel confident writing it (I'm sure some of your colleagues will be happy to help). > > Signed-off-by: Yeoreum Yun > --- > arch/arm64/kvm/hyp/nvhe/psci-relay.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/nvhe/psci-relay.c b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > index c3e196fb8b18..4ed4b7fa57c2 100644 > --- a/arch/arm64/kvm/hyp/nvhe/psci-relay.c > +++ b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > @@ -4,6 +4,7 @@ > * Author: David Brazdil > */ > > +#include > #include > #include > #include > @@ -219,6 +220,8 @@ asmlinkage void __noreturn __kvm_host_psci_cpu_entry(bool is_cpu_on) > release_boot_args(boot_args); > > write_sysreg_el1(INIT_SCTLR_EL1_MMU_OFF, SYS_SCTLR); > + if (alternative_has_cap_unlikely(ARM64_HAS_SCTLR2)) > + write_sysreg_el1(INIT_SCTLR2_EL1, SYS_SCTLR2); > write_sysreg(INIT_PSTATE_EL1, SPSR_EL2); > > __host_enter(host_ctxt); This needs to be folded into patch #1. Otherwise, there is a window of patches where the kernel will not survive CPU hotplug when booted in protected mode. M. -- Without deviation from the norm, progress is not possible.