From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A805AEAD8 for ; Mon, 4 Dec 2023 09:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ehcE4IcF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D406C433C9; Mon, 4 Dec 2023 09:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701680424; bh=Gt8qQX0dLBoE9A1NhesBli+9toqY41S3mdlGK2o31zc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ehcE4IcFZUD7pZB7iulQ0fpBf0Mlo8JQv+mrUqSTAyOj9fm/6a94Jol0kc2M8WqKG gS5IQ4tntoQUlCPgUxLI5ynkqggB+UQrELfBdO6cEArTcj4d9HopDRqxxXpnQumX7O LoTeiFa3Hnqjz02T3tm3V0SkAMpmrpx06J0UvuiScWI/3MVKehKx+3F9xKEpKWoZFZ dwIK89Nmjrlx1FVg1VE3fcCok8GnMlZ5bH9JNL42yhFndfnxkYVzAul9bvHhx85f+v djAliMwgBMG7ZcvPTGEli7Fz5u1IF2kMdKn6B32z5YxE3qZ9QJmoHDPvm5szSMxuyB TzGebDC9D+sig== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rA4oP-0019X3-Ly; Mon, 04 Dec 2023 09:00:21 +0000 Date: Mon, 04 Dec 2023 09:00:21 +0000 Message-ID: <86r0k2bavu.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: Kunkun Jiang , dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Gavin Shan , Jean-Philippe Brucker , "open list:IRQCHIP DRIVERS" , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI In-Reply-To: References: <20231102143507.840-1-jiangkunkun@huawei.com> <87msvt6cc7.wl-maz@kernel.org> <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com> <86edh228xx.wl-maz@kernel.org> <952bd5dc-dd20-acc3-d77e-c9b14e5728d3@huawei.com> <87fs0k94og.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jasowang@redhat.com, jiangkunkun@huawei.com, dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, gshan@redhat.com, jean-philippe@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 04 Dec 2023 08:47:49 +0000, Jason Wang wrote: >=20 > On Mon, Dec 4, 2023 at 4:39=E2=80=AFPM Jason Wang w= rote: > > > > On Sat, Dec 2, 2023 at 8:20=E2=80=AFPM Marc Zyngier wr= ote: > > > > > > Hi Kunkun, > > > > > > On Wed, 08 Nov 2023 09:45:51 +0000, > > > Kunkun Jiang wrote: > > > > > > > > Hi Marc, > > > > > > > > On 2023/11/6 23:33, Marc Zyngier wrote: > > > > > On Mon, 06 Nov 2023 14:59:01 +0000, > > > > > Kunkun Jiang wrote: > > > > >> The virtio-pci driver write entry1-6 > > > > >> massage.data in the msix-table and trap to QEMU for processing. = The > > > > >> massage.data is as follow: > > > > >>> entry-0 0 > > > > >>> entry-1 1 > > > > >>> entry-2 1 > > > > >>> entry-3 1 > > > > >>> entry-4 1 > > > > >>> entry-5 1 > > > > >>> entry-6 1 > > > > It looks like a bug from the driver. It should only use vector 0 and 1 > > in this case. > > > > Could you please check the queue_msix_vector for each queue in this cas= e? >=20 > Or did you actually mean queue_msix_vector here? I'm not familiar with > ARM but 0 doesn't seem to be a good message.data anyhow. Why? What's special about 0? 0 is a perfectly fine value. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BBF3C4167B for ; Mon, 4 Dec 2023 09:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AvAi2uBogHZXPTEg0DCb5AObv93ZkURX2PC/3JM32cg=; b=VGETCSw7dUkop2 i9+qVmeaL1H3C1zGCcL5k2vBESDodR8O3nnVUFl7VP8xWrDI5Zp7ontcZhbHEEA6RfPLyJhcR9B+c jiHViVdrh6tdXYJpwBmPjdyZmhBSY9inm6LMqJSUAmBJtn7fRrliJO77G3l9X4t7SkKZYBKQy8LHD tefF59WcsgOrjEWM8yxI0NM5ET/5aCW950sNujfjsv67alIPK3EYc+D0DtNkbyBQffwkSHiweIb95 JoMoSR2RH5JlIXkfT37QEvZYPRW8FL2vhvON3v1X7CKAvK3sxIxu9JHxyQ6BwnylpbmdGeqDHnj6t DAGTENRPYLJAFKYXwXcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA4oZ-003M1v-2i; Mon, 04 Dec 2023 09:00:31 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA4oU-003M0q-0v for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 09:00:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id A7411B80D67; Mon, 4 Dec 2023 09:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D406C433C9; Mon, 4 Dec 2023 09:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701680424; bh=Gt8qQX0dLBoE9A1NhesBli+9toqY41S3mdlGK2o31zc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ehcE4IcFZUD7pZB7iulQ0fpBf0Mlo8JQv+mrUqSTAyOj9fm/6a94Jol0kc2M8WqKG gS5IQ4tntoQUlCPgUxLI5ynkqggB+UQrELfBdO6cEArTcj4d9HopDRqxxXpnQumX7O LoTeiFa3Hnqjz02T3tm3V0SkAMpmrpx06J0UvuiScWI/3MVKehKx+3F9xKEpKWoZFZ dwIK89Nmjrlx1FVg1VE3fcCok8GnMlZ5bH9JNL42yhFndfnxkYVzAul9bvHhx85f+v djAliMwgBMG7ZcvPTGEli7Fz5u1IF2kMdKn6B32z5YxE3qZ9QJmoHDPvm5szSMxuyB TzGebDC9D+sig== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rA4oP-0019X3-Ly; Mon, 04 Dec 2023 09:00:21 +0000 Date: Mon, 04 Dec 2023 09:00:21 +0000 Message-ID: <86r0k2bavu.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: Kunkun Jiang , dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Gavin Shan , Jean-Philippe Brucker , "open list:IRQCHIP DRIVERS" , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI In-Reply-To: References: <20231102143507.840-1-jiangkunkun@huawei.com> <87msvt6cc7.wl-maz@kernel.org> <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com> <86edh228xx.wl-maz@kernel.org> <952bd5dc-dd20-acc3-d77e-c9b14e5728d3@huawei.com> <87fs0k94og.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jasowang@redhat.com, jiangkunkun@huawei.com, dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com, mst@redhat.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, gshan@redhat.com, jean-philippe@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_010027_902971_F8242242 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNCBEZWMgMjAyMyAwODo0Nzo0OSArMDAwMCwKSmFzb24gV2FuZyA8amFzb3dhbmdA cmVkaGF0LmNvbT4gd3JvdGU6Cj4gCj4gT24gTW9uLCBEZWMgNCwgMjAyMyBhdCA0OjM54oCvUE0g SmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gU2F0LCBE ZWMgMiwgMjAyMyBhdCA4OjIw4oCvUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3Jv dGU6Cj4gPiA+Cj4gPiA+IEhpIEt1bmt1biwKPiA+ID4KPiA+ID4gT24gV2VkLCAwOCBOb3YgMjAy MyAwOTo0NTo1MSArMDAwMCwKPiA+ID4gS3Vua3VuIEppYW5nIDxqaWFuZ2t1bmt1bkBodWF3ZWku Y29tPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IEhpIE1hcmMsCj4gPiA+ID4KPiA+ID4gPiBPbiAy MDIzLzExLzYgMjM6MzMsIE1hcmMgWnluZ2llciB3cm90ZToKPiA+ID4gPiA+IE9uIE1vbiwgMDYg Tm92IDIwMjMgMTQ6NTk6MDEgKzAwMDAsCj4gPiA+ID4gPiBLdW5rdW4gSmlhbmcgPGppYW5na3Vu a3VuQGh1YXdlaS5jb20+IHdyb3RlOgo+ID4gPiA+ID4+IFRoZSB2aXJ0aW8tcGNpIGRyaXZlciB3 cml0ZSBlbnRyeTEtNgo+ID4gPiA+ID4+IG1hc3NhZ2UuZGF0YSBpbiB0aGUgbXNpeC10YWJsZSBh bmQgdHJhcCB0byBRRU1VIGZvciBwcm9jZXNzaW5nLiBUaGUKPiA+ID4gPiA+PiBtYXNzYWdlLmRh dGEgaXMgYXMgZm9sbG93Ogo+ID4gPiA+ID4+PiBlbnRyeS0wIDAKPiA+ID4gPiA+Pj4gZW50cnkt MSAxCj4gPiA+ID4gPj4+IGVudHJ5LTIgMQo+ID4gPiA+ID4+PiBlbnRyeS0zIDEKPiA+ID4gPiA+ Pj4gZW50cnktNCAxCj4gPiA+ID4gPj4+IGVudHJ5LTUgMQo+ID4gPiA+ID4+PiBlbnRyeS02IDEK PiA+Cj4gPiBJdCBsb29rcyBsaWtlIGEgYnVnIGZyb20gdGhlIGRyaXZlci4gSXQgc2hvdWxkIG9u bHkgdXNlIHZlY3RvciAwIGFuZCAxCj4gPiBpbiB0aGlzIGNhc2UuCj4gPgo+ID4gQ291bGQgeW91 IHBsZWFzZSBjaGVjayB0aGUgcXVldWVfbXNpeF92ZWN0b3IgZm9yIGVhY2ggcXVldWUgaW4gdGhp cyBjYXNlPwo+IAo+IE9yIGRpZCB5b3UgYWN0dWFsbHkgbWVhbiBxdWV1ZV9tc2l4X3ZlY3RvciBo ZXJlPyBJJ20gbm90IGZhbWlsaWFyIHdpdGgKPiBBUk0gYnV0IDAgZG9lc24ndCBzZWVtIHRvIGJl IGEgZ29vZCBtZXNzYWdlLmRhdGEgYW55aG93LgoKV2h5PyBXaGF0J3Mgc3BlY2lhbCBhYm91dCAw PyAwIGlzIGEgcGVyZmVjdGx5IGZpbmUgdmFsdWUuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlv biBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==