From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771267485 for ; Fri, 14 Jul 2023 07:57:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED09BC433C8; Fri, 14 Jul 2023 07:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689321435; bh=IfLcYQotq5TIIbvKcOUwPCwI16MLFXvxH0vMKPmHXh4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YlgziZ5qZnrI/ZzCgpJQBW/3vMznxbe4/tMTaOWjAA6EF2cK4lBLnNL2mkNCKfHWA R8e20j2i2h07MBg+DCXaSmmL//e2ejUrQJsgKxcHR/Z2bwVI+D40CxT6AjOGaNsM4F ow5oOovl/kjyOYUpZOGnGfSynKakM818vGuC0KWE/KPU2qTI42URs+fiSX1qxlpi4w L3RL+zPahMLboiF3YtXskoWAzPl+4IUe7ySCqToybU+i65cU3tIFbvL5MelXznPag1 k2dhvVl40PWeMfnnDFSagS375GTWBd+aeGMqpzYJhZkYD/3zAVxKAEhjNsDuIQdPPF 1Op37vMKurl5Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qKDfs-00D1NY-Ll; Fri, 14 Jul 2023 08:57:12 +0100 Date: Fri, 14 Jul 2023 08:57:12 +0100 Message-ID: <86r0pbudrb.wl-maz@kernel.org> From: Marc Zyngier To: chenqingyun001@208suo.com Cc: oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH] KVM: arm64:Use #include instead of In-Reply-To: <3d56cf129c2cf1cf53f19ebe3c23a803@208suo.com> References: <3d56cf129c2cf1cf53f19ebe3c23a803@208suo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chenqingyun001@208suo.com, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 14 Jul 2023 05:57:42 +0100, chenqingyun001@208suo.com wrote: > > Since is a kernel-proprietary header file, it > should not be included by user-space programs. There is no userspace involved here. > And is a public header file, > which provides some functions for registering > and unregistering probes How is that relevant? Have you checked *why* we're including this file? > > Signed-off-by: Qingyun Chen > --- > arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > index b35a178e7e0d..072471df8b1b 100644 > --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > @@ -9,7 +9,7 @@ > #include > #include > > -#include > +#include And this is at the wrong thing to do. > #include > #include > #include > I'd rather you *stop* sending these patches. There is no justification for them, and you keep doing the wrong thing. M. -- Without deviation from the norm, progress is not possible.