From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A2EEC61DA4 for ; Thu, 16 Feb 2023 08:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I7FdCxXAsTxogoyua75fB0hPBvW4nj3kCStwyBmsAxE=; b=EuYQgoPI0LLDI5 xzIAZi3DATQ3+fwLj/jPl8K2tdBj278Jbkjk2EEwXCC19tnAZIULsf88pkE0odwQ6TOH5BImis8Lk 9rjI4fR2/HKZJl6SYaj/wunXC5hFtxFDj7CBjIYQo5/N0ENLqBdKDio1H4dhYdgF/eJbErVSER+u9 v1Ii92ZB6JiEnKLt7/5LLnNvSqScPT7yZl8hWSRiROfYCcX7ShhIIN+eEOTVrE0aezSRASigD5rxY Au5svDEnv6KEhEojfloMfU7c/s2Y28rCsb0AkEAyi2sbTD8+q9itUbQop6BNlAGI2F9AEvr5nw2Bz fOY9jaqm2pj8q6OdtlBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSZfg-00926F-62; Thu, 16 Feb 2023 08:31:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSZfa-00923w-3S for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 08:31:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B08F061EC3; Thu, 16 Feb 2023 08:31:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B04C433D2; Thu, 16 Feb 2023 08:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676536268; bh=E/M1ELV4fyFhnwIoVdGYsz6UrhilMsJN7X3A2snOokU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YmVDOUddLM+S8+9NYj7sGXUdZuEmtJzl0CgbU/byLdEVlok5oRYEW1MTxHC29C2J2 bFd6WXbEHAz+zxHoS4Yj8J96YxYtqYYO4pIwUdpOiv/AXN+7St8dwcbiwiCHxhsvnL 1jz3Z5boU/nJPhc6JRwYpN/ySryHZ53ZITALLeIE9jjW4NAvAaUovCp1+dzp97JfPc koa+rRem3NM9Wn8W8QoNGl5UCZLjBovRmV+Jgy3dXdeQVEl0gForq2aEGhWw3Nkj/A YaAdcR5U+t3ok5x0yPGx5/TSWZhQ4AZkkEv0DGapRKx1SO1jbBH852/JdEsfMpuKO8 M+9FOPqxFg29A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSZfW-00Aowv-9h; Thu, 16 Feb 2023 08:31:06 +0000 Date: Thu, 16 Feb 2023 08:31:06 +0000 Message-ID: <86r0uqxb91.wl-maz@kernel.org> From: Marc Zyngier To: Sudeep Holla Cc: Florian Fainelli , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Oliver Upton , "open list:IRQCHIP DRIVERS" , Broadcom internal kernel review list Subject: Re: [PATCH 3/3] irqchip/gic-v3: Save and restore distributor and re-distributor In-Reply-To: <20230215151048.xxmpvfre2xdngowr@bogus> References: <20230214233426.2994501-1-f.fainelli@gmail.com> <20230214233426.2994501-4-f.fainelli@gmail.com> <87o7pvz78z.wl-maz@kernel.org> <20230215121050.d57tnfh7wzpyqzti@bogus> <86ttznxa9n.wl-maz@kernel.org> <20230215151048.xxmpvfre2xdngowr@bogus> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sudeep.holla@arm.com, f.fainelli@gmail.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_003110_281891_8B15A6B9 X-CRM114-Status: GOOD ( 45.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxNSBGZWIgMjAyMyAxNToxMDo0OCArMDAwMCwKU3VkZWVwIEhvbGxhIDxzdWRlZXAu aG9sbGFAYXJtLmNvbT4gd3JvdGU6Cj4gCj4gT24gV2VkLCBGZWIgMTUsIDIwMjMgYXQgMDI6NDA6 MDRQTSArMDAwMCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gV2VkLCAxNSBGZWIgMjAyMyAx MjoxMDo1MCArMDAwMCwKPiA+IFN1ZGVlcCBIb2xsYSA8c3VkZWVwLmhvbGxhQGFybS5jb20+IHdy b3RlOgo+ID4gPiAKPiA+ID4gT24gV2VkLCBGZWIgMTUsIDIwMjMgYXQgMDg6MDI6MjBBTSArMDAw MCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgMTQgRmViIDIwMjMgMjM6MzQ6 MjYgKzAwMDAsCj4gPiA+ID4gRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+ IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IE9uIHBsYXRmb3JtcyBpbXBsZW1lbnRpbmcgU3Vz cGVuZCB0byBSQU0gd2hlcmUgdGhlIEdJQyBsb3NlcyBwb3dlciwgd2UKPiA+ID4gPiA+IGFyZSBu b3QgcHJvcGVybHkgc2F2aW5nIGFuZCByZXN0b3JpbmcgdGhlIEdJQyBkaXN0cmlidXRvciBhbmQK PiA+ID4gPiA+IHJlLWRpc3RyaWJ1dG9yIHJlZ2lzdGVycyB0aHVzIGxlYWRpbmcgdG8gdGhlIHN5 c3RlbSByZXN1bWluZyB3aXRob3V0IGFueQo+ID4gPiA+ID4gZnVuY3Rpb25hbCBpbnRlcnJ1cHRz Lgo+ID4gPiA+Cj4gPiA+ID4gVGhlIHJlYWwgcXVlc3Rpb24gaXMgKndoeSogd2UgbmVlZCBhbnkg b2YgdGhpcy4gT24gYW55IGRlY2VudCBzeXN0ZW0sCj4gPiA+ID4gdGhpcyBpcyB0aGUgZmlybXdh cmUncyBqb2IuICBJdCB3YXMgKm5ldmVyKiB0aGUgT1MgR0lDIGRyaXZlcidzIGpvYgo+ID4gPiA+ IHRoZSBmaXJzdCBwbGFjZS4KPiA+ID4gPgo+ID4gPiAKPiA+ID4gQ29tcGxldGVseSBhZ3JlZWQg b24gdGhlIHBvaW50cyB5b3UgaGF2ZSBtYWRlIGhlcmUsIG5vIGRpc2FncmVlbWVudC4KPiA+ID4g SG93ZXZlciBJIHdvdWxkIGxpa2UgdG8gaXRlcmF0ZSBzb21lIG9mIHRoZSBhcmd1bWVudHMvY29u Y2VybnMgdGhlCj4gPiA+IGZpcm13YXJlIHRlYW1zIEkgaGF2ZSBpbnRlcmFjdGVkIGluIHRoZSBw YXN0IGhhdmUgbWFkZSBhcm91bmQgdGhpcy4KPiA+ID4gQW5kIHRoaXMgaXMgd2hpbGUgYWdvKGNv dXBsZSBvZiB5ZWFycykgYW5kIHRoZXkgbWF5IGhhdmUgZGlmZmVyZW50Cj4gPiA+IHZpZXdzLiBJ IGFtIHJlcGVhdGluZyB0aGVtIGFzIEkgdGhpbmsgaXQgbWF5IGJlIHN0aWxsIHZhbGlkIG9uIHNv bWUKPiA+ID4gc3lzdGVtcyBzbyB0aGF0IHdlIGNhbiBtYWtlIHNvbWUgc3VnZ2VzdGlvbnMgaWYg d2UgaGF2ZSBoZXJlLgo+ID4gPiAKPiA+ID4gPiBJbXBvcnRhbnRseSwgdGhlIE9TIGNhbm5vdCBz YXZlIHRoZSBmdWxsIHN0YXRlOiBhIGxhcmdlIHBhcnQgb2YgaXQgaXMKPiA+ID4gPiBvbmx5IGFj Y2Vzc2libGUgdmlhIHNlY3VyZSwgYW5kIExpbnV4IGRvZXNuJ3QgcnVuIGluIHNlY3VyZSBtb2Rl LiBIb3cKPiA+ID4gPiBkbyB5b3UgcmVzdG9yZSB0aGUgZ3JvdXAgY29uZmlndXJhdGlvbiwgZm9y IGV4YW1wbGU/IE9oIHdhaXQsIHlvdQo+ID4gPiA+IGRvbid0IGV2ZW4gc2F2ZSBpdC4KPiA+ID4g Pgo+ID4gPiAKPiA+ID4gQWdyZWVkLCB3ZSBjYW4ndCBtYW5hZ2Ugc2VjdXJlIHNpZGUgY29uZmln dXJhdGlvbnMuIEJ1dCBvbmUgb2YgdGhlIGNvbmNlcm4KPiA+ID4gd2FzIGFib3V0IHRoZSBsYXJn ZSBtZW1vcnkgZm9vdHByaW50IHRvIHNhdmUgdGhlIGxhcmdlciBub24tc2VjdXJlIEdJQwo+ID4g PiBjb250ZXh0IGluIHRoZSBzbWFsbGVyIHNlY3VyZSBtZW1vcnkuCj4gPiA+IAo+ID4gPiBPbmUg b2YgdGhlIHN1Z2dlc3Rpb24gYXQgdGhlIHRpbWUgd2FzIHRvIGNhcnZlIG91dCBhIGNodW5rIG9m IG5vbi1zZWN1cmUKPiA+ID4gbWVtb3J5IGFuZCBsZXQgdGhlIHNlY3VyZSBzaWRlIHVzZSB0aGUg c2FtZSBmb3IgY29udGV4dCBzYXZlIGFuZCByZXN0b3JlLgo+ID4gPiBOb3Qgc3VyZSBpZiB0aGlz IHdhcyB0cmllZCBvdXQgZXNwZWNpYWxseSBmb3IgdGhlIEdJQy4gSSBtYXkgbmVlZCB0bwo+ID4g PiBjaGFzZSB0aGF0IHdpdGggdGhlIGNvbmNlcm5lZCB0ZWFtcy4KPiA+IAo+ID4gVGhlIG1haW4g aXNzdWUgaXMgdGhhdCB5b3Ugc3RpbGwgbmVlZCBzZWN1cmUgbWVtb3J5IHRvIHNhdmUgdGhlIHNl Y3VyZQo+ID4gc3RhdGUsIGFzIGxlYXZpbmcgaXQgaW4gTlMgbWVtb3J5IHdvdWxkIGJlIGFuIGlu dGVyZXN0aW5nIGF0dGFjawo+ID4gdmVjdG9yISBPdGhlciB0aGFuIHRoYXQsIEkgc2VlIG5vIGlz c3VlIHdpdGggRlcgY2FydmluZyBvdXQgdGhlIG1lbW9yeQo+ID4gaXQgbmVlZHMgdG8gc2F2ZS9y ZXN0b3JlIHRoZSBOUyBzdGF0ZSBvZiB0aGUgR0lDLgo+ID4KPiAKPiBZZXMgSSBtZWFudCBOUyBt ZW1vcnkgZm9yIG9ubHkgTlMgc3RhdGUgb2YgR0lDLgo+IAo+ID4gTm90ZSB0aGF0IHRoaXMgaXNu J3Qgb25seSB0aGUgKHJlLSlkaXN0cmlidXRvcihzKSBQUEkvU1BJIHJlZ2lzdGVycy4KPiA+IFRo ZSBMUEkgc2V0dXAgbXVzdCBhbHNvIGJlIHNhdmVkLCBhbmQgdGhhdCBpbmNsdWRlcyBhbGwgdGhl IElUUwo+ID4gcmVnaXN0ZXJzLiBJJ20gc3VycHJpc2VkIHRoZSBGVyBmb2xrcyBhcmUsIGFsbCBv ZiBhIHN1ZGRlbiwKPiA+IGRpc2NvdmVyaW5nIHRoaXMgcmVxdWlyZW1lbnRzLiBJdCBpc24ndCBs aWtlIHRoZSBHSUMgYXJjaGl0ZWN0dXJlIGlzIGEKPiA+IG5vdmVsdHksIGFuZCB0aGV5IGhhdmUg aGFkIGFtcGxlIHRpbWUgdG8gcmV2aWV3IHRoZSBzcGVjLi4uCj4gPgo+IAo+IEkgdW5kZXJzdGFu ZCB5b3VyIGNvbmNlcm4gYWJvdXQgbGF0ZSByZWFsaXNhdGlvbiDwn5iELgo+IAo+IEFub3RoZXIg aXNzdWUgaW4gZ2VuZXJhbCBJIHNlZSB3aXRoIHJlZmVyZW5jZSBmaXJtd2FyZSBzdGFjayhsaWtl Cj4gVHJ1c3RlZCBGaXJtd2FyZSBpbiB0aGlzIGNhc2UpIGlzIHRoYXQgdGhlIHJlcXVpcmVtZW50 cyBhcmUgZHJpdmVuIGZyb20KPiB0aGUgcmVmZXJlbmNlIHBsYXRmb3JtcyB3aGljaCBtYXkgbm90 IGhhdmUgdGhpcyBHSUMgc2F2ZS9yZXN0b3JlCj4gcmVxdWlyZW1lbnQgYXMgdGhleSBhcmUgaW4g YWx3YXlzIG9uIGRvbWFpbiBhbmQgaXQgaXMgdGhlbiBtYWRlIHBsYXRmb3JtCj4gc3BlY2lmaWMg cHJvYmxlbSBpbiB0aGF0IHByb2plY3Qgd2hpY2ggbWF5IG5vdCBiZSBpZGVhbCBhbmQgbWF5IHJl c3VsdAo+IGluIHNvbWV3aGF0IG1pc2xlYWRpbmcgaW5kaXJlY3RseSBvdGhlciBmaXJtd2FyZSBk ZXZlbG9wZXJzIHVzaW5nCj4gaXQuCgpZZWFoLCB0aGF0J3MgdGhlIHVzdWFsIHN0YXRlIG9mIGFm ZmFpci4gVW5yZWFsaXN0aWMgcGxhdGZvcm1zLCBubwppbnNpZ2h0IChhbmQgbW9yZSBnZW5lcmFs bHkgbm8gaW50ZXJlc3QpIGluIHRoZSBhY3R1YWwgdXNhZ2UgbW9kZWwuCgpTdGlsbCwgbW9zdCBw ZW9wbGUgZ290IGl0IHJpZ2h0LCBzbyBJIGd1ZXNzIHRoZXkgbXVzdCBiZSByZWFkaW5nIHRoZQpz cGVjLiBIb3cgY29tZXMgdGhpcyB3YXMgbmV2ZXIgcGlja2VkIGZyb20gY29udHJpYnV0aW9ucyB0 byBURi1BPwpTdXJlbHkgZHVwbGljYXRpb24gb2YgcGxhdGZvcm0gY29kZSBzaG91bGQgYmUgYSBt YXNzaXZlIGhpbnQgdG8gdGhlCmZpcm13YXJlIG1haW50YWluZXJzPwoKVGhhbmtzLAoKCU0uCgot LSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3Np YmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94D0C636CC for ; Thu, 16 Feb 2023 08:31:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjBPIbT (ORCPT ); Thu, 16 Feb 2023 03:31:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjBPIbP (ORCPT ); Thu, 16 Feb 2023 03:31:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818434A1FC for ; Thu, 16 Feb 2023 00:31:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D22061ED1 for ; Thu, 16 Feb 2023 08:31:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B04C433D2; Thu, 16 Feb 2023 08:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676536268; bh=E/M1ELV4fyFhnwIoVdGYsz6UrhilMsJN7X3A2snOokU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YmVDOUddLM+S8+9NYj7sGXUdZuEmtJzl0CgbU/byLdEVlok5oRYEW1MTxHC29C2J2 bFd6WXbEHAz+zxHoS4Yj8J96YxYtqYYO4pIwUdpOiv/AXN+7St8dwcbiwiCHxhsvnL 1jz3Z5boU/nJPhc6JRwYpN/ySryHZ53ZITALLeIE9jjW4NAvAaUovCp1+dzp97JfPc koa+rRem3NM9Wn8W8QoNGl5UCZLjBovRmV+Jgy3dXdeQVEl0gForq2aEGhWw3Nkj/A YaAdcR5U+t3ok5x0yPGx5/TSWZhQ4AZkkEv0DGapRKx1SO1jbBH852/JdEsfMpuKO8 M+9FOPqxFg29A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSZfW-00Aowv-9h; Thu, 16 Feb 2023 08:31:06 +0000 Date: Thu, 16 Feb 2023 08:31:06 +0000 Message-ID: <86r0uqxb91.wl-maz@kernel.org> From: Marc Zyngier To: Sudeep Holla Cc: Florian Fainelli , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Oliver Upton , "open list:IRQCHIP DRIVERS" , Broadcom internal kernel review list Subject: Re: [PATCH 3/3] irqchip/gic-v3: Save and restore distributor and re-distributor In-Reply-To: <20230215151048.xxmpvfre2xdngowr@bogus> References: <20230214233426.2994501-1-f.fainelli@gmail.com> <20230214233426.2994501-4-f.fainelli@gmail.com> <87o7pvz78z.wl-maz@kernel.org> <20230215121050.d57tnfh7wzpyqzti@bogus> <86ttznxa9n.wl-maz@kernel.org> <20230215151048.xxmpvfre2xdngowr@bogus> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sudeep.holla@arm.com, f.fainelli@gmail.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2023 15:10:48 +0000, Sudeep Holla wrote: >=20 > On Wed, Feb 15, 2023 at 02:40:04PM +0000, Marc Zyngier wrote: > > On Wed, 15 Feb 2023 12:10:50 +0000, > > Sudeep Holla wrote: > > >=20 > > > On Wed, Feb 15, 2023 at 08:02:20AM +0000, Marc Zyngier wrote: > > > > On Tue, 14 Feb 2023 23:34:26 +0000, > > > > Florian Fainelli wrote: > > > > > > > > > > On platforms implementing Suspend to RAM where the GIC loses powe= r, we > > > > > are not properly saving and restoring the GIC distributor and > > > > > re-distributor registers thus leading to the system resuming with= out any > > > > > functional interrupts. > > > > > > > > The real question is *why* we need any of this. On any decent syste= m, > > > > this is the firmware's job. It was *never* the OS GIC driver's job > > > > the first place. > > > > > > >=20 > > > Completely agreed on the points you have made here, no disagreement. > > > However I would like to iterate some of the arguments/concerns the > > > firmware teams I have interacted in the past have made around this. > > > And this is while ago(couple of years) and they may have different > > > views. I am repeating them as I think it may be still valid on some > > > systems so that we can make some suggestions if we have here. > > >=20 > > > > Importantly, the OS cannot save the full state: a large part of it = is > > > > only accessible via secure, and Linux doesn't run in secure mode. H= ow > > > > do you restore the group configuration, for example? Oh wait, you > > > > don't even save it. > > > > > > >=20 > > > Agreed, we can't manage secure side configurations. But one of the co= ncern > > > was about the large memory footprint to save the larger non-secure GIC > > > context in the smaller secure memory. > > >=20 > > > One of the suggestion at the time was to carve out a chunk of non-sec= ure > > > memory and let the secure side use the same for context save and rest= ore. > > > Not sure if this was tried out especially for the GIC. I may need to > > > chase that with the concerned teams. > >=20 > > The main issue is that you still need secure memory to save the secure > > state, as leaving it in NS memory would be an interesting attack > > vector! Other than that, I see no issue with FW carving out the memory > > it needs to save/restore the NS state of the GIC. > > >=20 > Yes I meant NS memory for only NS state of GIC. >=20 > > Note that this isn't only the (re-)distributor(s) PPI/SPI registers. > > The LPI setup must also be saved, and that includes all the ITS > > registers. I'm surprised the FW folks are, all of a sudden, > > discovering this requirements. It isn't like the GIC architecture is a > > novelty, and they have had ample time to review the spec... > > >=20 > I understand your concern about late realisation =F0=9F=98=84. >=20 > Another issue in general I see with reference firmware stack(like > Trusted Firmware in this case) is that the requirements are driven from > the reference platforms which may not have this GIC save/restore > requirement as they are in always on domain and it is then made platform > specific problem in that project which may not be ideal and may result > in somewhat misleading indirectly other firmware developers using > it. Yeah, that's the usual state of affair. Unrealistic platforms, no insight (and more generally no interest) in the actual usage model. Still, most people got it right, so I guess they must be reading the spec. How comes this was never picked from contributions to TF-A? Surely duplication of platform code should be a massive hint to the firmware maintainers? Thanks, M. --=20 Without deviation from the norm, progress is not possible.