From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 5/6] dri3: Add DRI3 support to GLX, DRI common and Intel driver Date: Sun, 03 Nov 2013 14:35:49 -0800 Message-ID: <86r4axf70a.fsf@miki.keithp.com> References: <1383261196-25093-1-git-send-email-keithp@keithp.com> <1383261196-25093-6-git-send-email-keithp@keithp.com> <20131102053154.GA4221@tokamak.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1929723709==" Return-path: In-Reply-To: <20131102053154.GA4221@tokamak.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces@lists.freedesktop.org Errors-To: mesa-dev-bounces@lists.freedesktop.org To: Kristian =?utf-8?Q?H=C3=B8gsberg?= Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1929723709== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kristian H=C3=B8gsberg writes: > I sent a reply to the sourceforge addresses in the original emails, > but I didn't see it show up in the archives. Trying again with the > freedesktop addresses. (sorry for having an ancient shell script with sourceforge addresses in it) >> +typedef uint32_t * >> +(*__DRIdri3Stamp)(__DRIdrawable *drawable); > > This looks OK, as long as it's not tied into the xcb special_event > semantics. From the way it's used, it looks like a loader can just > increment this uint32_t when it needs to invalidate the buffer. Still > seems like an odd API - a invalidate function would be simpler, but > I'm guessing it's limited by what you can do if you receive the > special event in a different thread. Yeah, I definitely do not want a callback function here. The API was actually designed from the DRI2 side, not the xcb side as DRI2 has this uint32_t already sitting there that just needed poking. > With those changes, we can reuse __DRIimage for DRI3 which makes a lot > of sense. The GBM and Wayland backends already use __DRIimage for > color buffers, but convert them to __DRI2buffer to be able to pass > them into the DRI driver. Being able to pass a __DRIimage into the > driver in getBuffers will simplify those backends, and it should be > fairly simple to port them to the dri3 driver interface. Ok, so the first step would be to convert drivers from __DRI2buffer to __DRIimage, at which point it should be trivial to use __DRIimage to support DRI3? Or should I just take my existing __DRI3buffer code and change that into a __DRIimage API and leave the __DRI2buffer code around in the driver to support DRI2? I'm game for either approach, but fixing the drivers to export a single API that can support all of the window systems sure seems like a better long-term plan... =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIVAwUBUnbPxtsiGmkAAAARAQiPxg//a5Y6YmZU732dBHOlrOTcjGKeuDZQ7Hl7 qf6x8P+1Uw9EMs2FYPePNLVwi07PUzmJ2NTv4VsG9mWf2f7Y5wN0zA4LrRnD+RuO mArbasq5wYBzQTLqu826ztw4HKZztt2VLzzHtlY4Ys5wG0ohdNiwVjg26p/Y2LE2 H2iZJ2BRH/+4C3Lfb5B77ez0hc8wdjK7i/jSAgG7XR85v2hdmptzS3jtBsyy/UEr NpD3oKsakBKeuF6J/b9PoPp/YseO6sK/LuO5cUWMFtdOaknYxjHGuKD/Sr9AsHrQ vL5IAouPLHx13faADpRecGJkUFeWt0h1amaMobNu8kLxddj0g64gLB5CKUQAnc0z wWa8t+c3v/yrkmhZQheqrPeXXyemcLXsdELShHClxIsnSQQ6Y8tnSvfWzpH6jcnA yPu+WvgkMNtvr5VObOiDb5z5bU3ADUiefyAbKi/6vtRdIyBgZJUaJMHkj4zBTMSD +L7/B8VAHQ6kvOzBVz1f/s4WQQY/H2IJ0Nk6MkuCrZ2lMyWG8T5ogKtKGC1ZAmpl HARh9AOT4OtiBUnDgQtGfHJPka+KCcgEu4oH+0l68mFM2jdbKh34GZenEEf6xMqa /Wz9MLq+9Vh7GfzV1qzV20XpdKlTpLzi7wQin1B4Ky23+P5U3h/io6SYA3yb/dBv C/i/0ehcTVE= =Seir -----END PGP SIGNATURE----- --=-=-=-- --===============1929723709== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev --===============1929723709==--