From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1FlC5h-00073O-DP for mharc-grub-devel@gnu.org; Tue, 30 May 2006 17:49:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FlC5f-00071B-5n for grub-devel@gnu.org; Tue, 30 May 2006 17:49:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FlC5b-00070z-M6 for grub-devel@gnu.org; Tue, 30 May 2006 17:49:25 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FlC5b-00070w-GE for grub-devel@gnu.org; Tue, 30 May 2006 17:49:23 -0400 Received: from [207.152.70.127] (helo=baz.foobar-qux.org) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FlCBT-0000LJ-KZ for grub-devel@gnu.org; Tue, 30 May 2006 17:55:27 -0400 Received: from baz.foobar-qux.org (localhost.foobar-qux.org [127.0.0.1]) by baz.foobar-qux.org (8.13.3/8.13.3) with ESMTP id k4V3xcfD056549 for ; Tue, 30 May 2006 22:59:38 -0500 (CDT) (envelope-from hde@gnu.org) Received: (from hde@localhost) by baz.foobar-qux.org (8.13.3/8.13.3/Submit) id k4V3xbK8056546; Tue, 30 May 2006 22:59:37 -0500 (CDT) (envelope-from hde@gnu.org) X-Authentication-Warning: baz.foobar-qux.org: hde set sender to hde@gnu.org using -f Sender: hde@baz.foobar-qux.org Mail-Copies-To: hde@gnu.org To: The development of GRUB 2 References: <447CB449.9080901@nic.fi> <1149023752.7177.86.camel@basalt.austin.ibm.com> From: hde@gnu.org (Harley D. Eades III) Date: 30 May 2006 22:59:37 -0500 In-Reply-To: <1149023752.7177.86.camel@basalt.austin.ibm.com> Message-ID: <86r72aetee.fsf@baz.foobar-qux.org> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 21:49:27 -0000 Hollis Blanchard writes: > On Wed, 2006-05-31 at 00:08 +0300, Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote: > > Attached patch fixes problems for compiling correct code on i386-pc... > > other platforms needs to be modified similarly too... >=20 > I'm confused by this; could you explain? If _TARGET_CFLAGS is used for > everything to be run on the target, perhaps we should just rename > _CFLAGS to _TARGET_CFLAGS. >=20 > Also, in the future, could you please supply best-guess code for other > architectures? It's ok if you don't know, but in this case it seems it > would be easy enough to duplicate your i386-pc.mk changes for the > other .mk files. I am also confused. Is this keeping to the changes presented by Okuji? I don't think it is best to move from CFLAGS to something different, this would make it odd when porting to other OS, it also seems off convention.=20=20 Okuji's post: http://lists.gnu.org/archive/html/grub-devel/2006-05/msg00106.html Cheers Harley