From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A480013D50C for ; Sat, 9 Nov 2024 13:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731158224; cv=none; b=WRcXLRTZSmgGQi32rNlvX2N1rd90px78OnxDrj1oq2T76kV8Gsco0fQHfuXGtMuHEnAIHMEfJw5BjZZuG4GDomY1Y29njQvKXKvYlGMdIcBsRjEw2yVMi3goQYPNtXxDaZsWmtfhK9KjSaQILKNw9e7bBsQ7i3UCrlnOiMhDYN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731158224; c=relaxed/simple; bh=PvsMKKCClU37zgRn+Zj7g/B/71pXYL7VIycTpWHQ2o4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=IM4m797LiBxskipydENJd1eSEhd+AMuF1NFcEyO+HTj9olLNmUiq0br5xzS9LT8vGwMMpxF6tkS7J9xdulXOkDI4BaidjMcwSkgjHkj4ZSE1aK2/YvPfsBcee231OW89D2BAb6ctEThBZiRQc5ohIIhx2eWeqdDNt0j6K/PlUH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tZi1OaoA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tZi1OaoA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27C4CC4CECE; Sat, 9 Nov 2024 13:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731158224; bh=PvsMKKCClU37zgRn+Zj7g/B/71pXYL7VIycTpWHQ2o4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tZi1OaoAWz+hl3oZLGl45A9lNlQwzo/B7E7/imjzYl6z5LP3xSqFKKTlLJNOcBwLy RizvxYgSWRQLLe1qLYBkNI/Tp67YOD/1XDykgQ6pArI/cmmrmub30jG8/SbzEiI8Je iHI0HeP2EujIQw09E8KhlV6Ip4PCFiWwf8+iRSNdRFOqoLCe7OjLthmK0g++LGUZS5 X2Xx3/nk25ikNWeMIJalSmT5d4KP9cf/mUJIOHa40L2MeNGbvMmIPokNQMTxifDWKQ 2x7X/5flU+873mnhmMYu8U8wU92iIxhWBXhtcku3wIr3FvNEXX959uflCrlzWg03sP wXKxeqLJqoNLw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t9lKn-00BQmL-QW; Sat, 09 Nov 2024 13:17:02 +0000 Date: Sat, 09 Nov 2024 13:17:00 +0000 Message-ID: <86ses0zgvn.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mingwei Zhang , Colton Lewis , Alexandru Elisei Subject: Re: [PATCH 09/15] KVM: arm64: Remove debug tracepoints In-Reply-To: <86zfm8zkbm.wl-maz@kernel.org> References: <20241108222418.1677420-1-oliver.upton@linux.dev> <20241108222418.1677420-10-oliver.upton@linux.dev> <86zfm8zkbm.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mizhang@google.com, coltonlewis@google.com, alexandru.elisei@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 09 Nov 2024 12:02:37 +0000, Marc Zyngier wrote: > > Whilst you're at it, how about: > > diff --git a/arch/arm64/kvm/trace_handle_exit.h b/arch/arm64/kvm/trace_handle_exit.h > index 064a58c19f481..fa1e48a36d3f9 100644 > --- a/arch/arm64/kvm/trace_handle_exit.h > +++ b/arch/arm64/kvm/trace_handle_exit.h > @@ -101,26 +101,6 @@ TRACE_EVENT(kvm_arm_set_dreg32, > > TRACE_DEFINE_SIZEOF(__u64); > > -TRACE_EVENT(kvm_arm_set_regset, > - TP_PROTO(const char *type, int len, __u64 *control, __u64 *value), > - TP_ARGS(type, len, control, value), > - TP_STRUCT__entry( > - __field(const char *, name) > - __field(int, len) > - __array(u64, ctrls, 16) > - __array(u64, values, 16) > - ), > - TP_fast_assign( > - __entry->name = type; > - __entry->len = len; > - memcpy(__entry->ctrls, control, len << 3); > - memcpy(__entry->values, value, len << 3); > - ), > - TP_printk("%d %s CTRL:%s VALUE:%s", __entry->len, __entry->name, > - __print_array(__entry->ctrls, __entry->len, sizeof(__u64)), > - __print_array(__entry->values, __entry->len, sizeof(__u64))) > -); > - > TRACE_EVENT(trap_reg, > TP_PROTO(const char *fn, int reg, bool is_write, u64 write_value), > TP_ARGS(fn, reg, is_write, write_value), > > It's not like we're going to miss that. Same thing for kvm_arm_set_dreg32(), by the way. Hopefully nobody will notice. M. -- Without deviation from the norm, progress is not possible.