From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EFB51BDC6 for ; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SQlOiKX/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31B9CC433C9; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698085184; bh=oS4z+Mn7/hwPC7bpjt/NEir6aeKFv3WVk0pLVerqzFw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQlOiKX/tPZPymq+Xg2Z6Xpi9AS+MXP05zyw3Ng7z7apeSdOL+E/U8V+gToVXJxti j/QPFhH6ZQBPPqZIl25EZa2U2kAC/tXgHgbanJ5lFc5JDmjBQR5ZtyVMkgInHreYdh 6YgKJbSzOWIsTJcJ7muXYx42fAYolMzOjwJsQ6gR7aTOdidcMRlbMcflr/16pJkfov IOQFMgTnKZF/BJtBziMQzskTpBowwToKN7gIbU+0uIeI27BthgK9ex3VPiWHa7WLuy qyoaidWIivH061C6n04JcJR87Z8HbLyNlJ2XD2pPa3I9YDrCRymN/rUHmrroP4g15A KbQKEFUgxoZwA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quzWf-006wp4-Cd; Mon, 23 Oct 2023 19:19:41 +0100 Date: Mon, 23 Oct 2023 19:19:39 +0100 Message-ID: <86sf6142x0.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU In-Reply-To: References: <20231020214053.2144305-1-rananta@google.com> <86v8ax4hae.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 23 Oct 2023 18:58:19 +0100, Raghavendra Rao Ananta wrote: >=20 > On Mon, Oct 23, 2023 at 6:09=E2=80=AFAM Marc Zyngier wro= te: > > > > On Fri, 20 Oct 2023 22:40:40 +0100, > > Raghavendra Rao Ananta wrote: > > > > > > Hello, > > > > > > The goal of this series is to allow userspace to limit the number > > > of PMU event counters on the vCPU. We need this to support migration > > > across systems that implement different numbers of counters. > > > > [...] > > > > I've gone through the initial patches, and stopped before the tests > > (which I usually can't be bothered to review anyway). > > > > The comments I have a relatively minor and could be applied as fixes > > on top if Oliver can be convinced to do so. Note that patch #4 has an > > attribution issue. > > > > > base-commit: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 > > > > maz@valley-girl:~/hot-poop/arm-platforms$ git describe 0a3a1665cbc59ee8= d6326aa6c0b4a8d1cd67dda3 > > fatal: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 is neither a commit nor= blob > > > > Can you please make an effort to base your postings on a known, stable > > commit? A tagged -rc would be best. but certainly not a random commit. > > > I usually do base on a known -rc. But this series needed a couple of > series from kvmarm/next (mentioned in the original patch), and hence I > rebased on top of them. Well, that commit has since disappeared, as git cannot find it (as demonstrated above). Which is why I insist on a public tag as a base, as everything else is completely volatile. > How do you suggest I handle this in the future? Rebase to a known > -rc on mainline, apply the required series, and then my series on > top? No. You base your own series on an -rc (ideally, -rc3). If there is a conflict with another series, it is our job (Oliver and I) to fix it (bonus points if you indicate a resolution for the conflict in the cover letter). If there is a hard dependency (something that would actively prevent your series from working at all), you cherry-pick the minimal set of patches that makes your own series functional as a *prefix*, and post the whole thing, including the patches you depend on. Oliver and I will make sure the common prefix is dealt with without duplication. And for what it is worth, this series directly applies on v6.6-rc3 without a conflict. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85573C25B46 for ; Mon, 23 Oct 2023 18:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AA7zePqtBF6WGcr3M1n920IojBFTncfTWBXn7H6F+BE=; b=JddKycJjprQuPC 1X5gAHKjOZors4kZv55Z+S6SC7rb5ReQGMiZ8nFc9Sawuf+ExMTjnI/x5aE6DKSKTCiEosVWvHs8q nyJMkTVhws/yprKdPVnM+HH3dmC/+7GgLVz2iCNfuK69TAzlnrfqrd5HIDlYw4+3/bxxl23TnSECr 8Di+RQttbOFeCXFJrx/ZSr55VTL8ogrXr6OjTIX2AYBftetNT4JnJ+kBt1gHUfuv3Qwc91gFQeMFK /j8LMPXJp7Aq0c0WnV+7YASqoIYYeAUjhmpiq68EEBV49EqGzv2rBgPtGyI1oRWn7n6rU5rb1MTVv Xy6/qSCiuP5xWNvj5TQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quzWm-0084Q6-38; Mon, 23 Oct 2023 18:19:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quzWk-0084P6-0j for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 18:19:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 846DD62706; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31B9CC433C9; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698085184; bh=oS4z+Mn7/hwPC7bpjt/NEir6aeKFv3WVk0pLVerqzFw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQlOiKX/tPZPymq+Xg2Z6Xpi9AS+MXP05zyw3Ng7z7apeSdOL+E/U8V+gToVXJxti j/QPFhH6ZQBPPqZIl25EZa2U2kAC/tXgHgbanJ5lFc5JDmjBQR5ZtyVMkgInHreYdh 6YgKJbSzOWIsTJcJ7muXYx42fAYolMzOjwJsQ6gR7aTOdidcMRlbMcflr/16pJkfov IOQFMgTnKZF/BJtBziMQzskTpBowwToKN7gIbU+0uIeI27BthgK9ex3VPiWHa7WLuy qyoaidWIivH061C6n04JcJR87Z8HbLyNlJ2XD2pPa3I9YDrCRymN/rUHmrroP4g15A KbQKEFUgxoZwA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quzWf-006wp4-Cd; Mon, 23 Oct 2023 19:19:41 +0100 Date: Mon, 23 Oct 2023 19:19:39 +0100 Message-ID: <86sf6142x0.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU In-Reply-To: References: <20231020214053.2144305-1-rananta@google.com> <86v8ax4hae.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_111946_353478_62B32833 X-CRM114-Status: GOOD ( 25.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMyBPY3QgMjAyMyAxODo1ODoxOSArMDEwMCwKUmFnaGF2ZW5kcmEgUmFvIEFuYW50 YSA8cmFuYW50YUBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBPbiBNb24sIE9jdCAyMywgMjAyMyBh dCA2OjA54oCvQU0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4g T24gRnJpLCAyMCBPY3QgMjAyMyAyMjo0MDo0MCArMDEwMCwKPiA+IFJhZ2hhdmVuZHJhIFJhbyBB bmFudGEgPHJhbmFudGFAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEhlbGxvLAo+ID4g Pgo+ID4gPiBUaGUgZ29hbCBvZiB0aGlzIHNlcmllcyBpcyB0byBhbGxvdyB1c2Vyc3BhY2UgdG8g bGltaXQgdGhlIG51bWJlcgo+ID4gPiBvZiBQTVUgZXZlbnQgY291bnRlcnMgb24gdGhlIHZDUFUu ICBXZSBuZWVkIHRoaXMgdG8gc3VwcG9ydCBtaWdyYXRpb24KPiA+ID4gYWNyb3NzIHN5c3RlbXMg dGhhdCBpbXBsZW1lbnQgZGlmZmVyZW50IG51bWJlcnMgb2YgY291bnRlcnMuCj4gPgo+ID4gWy4u Ll0KPiA+Cj4gPiBJJ3ZlIGdvbmUgdGhyb3VnaCB0aGUgaW5pdGlhbCBwYXRjaGVzLCBhbmQgc3Rv cHBlZCBiZWZvcmUgdGhlIHRlc3RzCj4gPiAod2hpY2ggSSB1c3VhbGx5IGNhbid0IGJlIGJvdGhl cmVkIHRvIHJldmlldyBhbnl3YXkpLgo+ID4KPiA+IFRoZSBjb21tZW50cyBJIGhhdmUgYSByZWxh dGl2ZWx5IG1pbm9yIGFuZCBjb3VsZCBiZSBhcHBsaWVkIGFzIGZpeGVzCj4gPiBvbiB0b3AgaWYg T2xpdmVyIGNhbiBiZSBjb252aW5jZWQgdG8gZG8gc28uIE5vdGUgdGhhdCBwYXRjaCAjNCBoYXMg YW4KPiA+IGF0dHJpYnV0aW9uIGlzc3VlLgo+ID4KPiA+ID4gYmFzZS1jb21taXQ6IDBhM2ExNjY1 Y2JjNTllZThkNjMyNmFhNmMwYjRhOGQxY2Q2N2RkYTMKPiA+Cj4gPiBtYXpAdmFsbGV5LWdpcmw6 fi9ob3QtcG9vcC9hcm0tcGxhdGZvcm1zJCBnaXQgZGVzY3JpYmUgMGEzYTE2NjVjYmM1OWVlOGQ2 MzI2YWE2YzBiNGE4ZDFjZDY3ZGRhMwo+ID4gZmF0YWw6IDBhM2ExNjY1Y2JjNTllZThkNjMyNmFh NmMwYjRhOGQxY2Q2N2RkYTMgaXMgbmVpdGhlciBhIGNvbW1pdCBub3IgYmxvYgo+ID4KPiA+IENh biB5b3UgcGxlYXNlIG1ha2UgYW4gZWZmb3J0IHRvIGJhc2UgeW91ciBwb3N0aW5ncyBvbiBhIGtu b3duLCBzdGFibGUKPiA+IGNvbW1pdD8gQSB0YWdnZWQgLXJjIHdvdWxkIGJlIGJlc3QuIGJ1dCBj ZXJ0YWlubHkgbm90IGEgcmFuZG9tIGNvbW1pdC4KPiA+Cj4gSSB1c3VhbGx5IGRvIGJhc2Ugb24g YSBrbm93biAtcmMuIEJ1dCB0aGlzIHNlcmllcyBuZWVkZWQgYSBjb3VwbGUgb2YKPiBzZXJpZXMg ZnJvbSBrdm1hcm0vbmV4dCAobWVudGlvbmVkIGluIHRoZSBvcmlnaW5hbCBwYXRjaCksIGFuZCBo ZW5jZSBJCj4gcmViYXNlZCBvbiB0b3Agb2YgdGhlbS4KCldlbGwsIHRoYXQgY29tbWl0IGhhcyBz aW5jZSBkaXNhcHBlYXJlZCwgYXMgZ2l0IGNhbm5vdCBmaW5kIGl0IChhcwpkZW1vbnN0cmF0ZWQg YWJvdmUpLiBXaGljaCBpcyB3aHkgSSBpbnNpc3Qgb24gYSBwdWJsaWMgdGFnIGFzIGEgYmFzZSwK YXMgZXZlcnl0aGluZyBlbHNlIGlzIGNvbXBsZXRlbHkgdm9sYXRpbGUuCgo+IEhvdyBkbyB5b3Ug c3VnZ2VzdCBJIGhhbmRsZSB0aGlzIGluIHRoZSBmdXR1cmU/IFJlYmFzZSB0byBhIGtub3duCj4g LXJjIG9uIG1haW5saW5lLCBhcHBseSB0aGUgcmVxdWlyZWQgc2VyaWVzLCBhbmQgdGhlbiBteSBz ZXJpZXMgb24KPiB0b3A/CgpOby4gWW91IGJhc2UgeW91ciBvd24gc2VyaWVzIG9uIGFuIC1yYyAo aWRlYWxseSwgLXJjMykuIElmIHRoZXJlIGlzIGEKY29uZmxpY3Qgd2l0aCBhbm90aGVyIHNlcmll cywgaXQgaXMgb3VyIGpvYiAoT2xpdmVyIGFuZCBJKSB0byBmaXggaXQKKGJvbnVzIHBvaW50cyBp ZiB5b3UgaW5kaWNhdGUgYSByZXNvbHV0aW9uIGZvciB0aGUgY29uZmxpY3QgaW4gdGhlCmNvdmVy IGxldHRlcikuCgpJZiB0aGVyZSBpcyBhIGhhcmQgZGVwZW5kZW5jeSAoc29tZXRoaW5nIHRoYXQg d291bGQgYWN0aXZlbHkgcHJldmVudAp5b3VyIHNlcmllcyBmcm9tIHdvcmtpbmcgYXQgYWxsKSwg eW91IGNoZXJyeS1waWNrIHRoZSBtaW5pbWFsIHNldCBvZgpwYXRjaGVzIHRoYXQgbWFrZXMgeW91 ciBvd24gc2VyaWVzIGZ1bmN0aW9uYWwgYXMgYSAqcHJlZml4KiwgYW5kIHBvc3QKdGhlIHdob2xl IHRoaW5nLCBpbmNsdWRpbmcgdGhlIHBhdGNoZXMgeW91IGRlcGVuZCBvbi4gT2xpdmVyIGFuZCBJ CndpbGwgbWFrZSBzdXJlIHRoZSBjb21tb24gcHJlZml4IGlzIGRlYWx0IHdpdGggd2l0aG91dCBk dXBsaWNhdGlvbi4KCkFuZCBmb3Igd2hhdCBpdCBpcyB3b3J0aCwgdGhpcyBzZXJpZXMgZGlyZWN0 bHkgYXBwbGllcyBvbiB2Ni42LXJjMwp3aXRob3V0IGEgY29uZmxpY3QuCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==