From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] Mark drmServerInfo.debug_print with printf
	attribute
Date: Wed, 11 Dec 2013 22:42:00 -0800
Message-ID: <86sityzi2v.fsf@miki.keithp.com>
References: <1386796627-29167-1-git-send-email-keithp@keithp.com>
	<52A9351C.3090802@oracle.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1989018802=="
Return-path: <mesa-dev-bounces@lists.freedesktop.org>
In-Reply-To: <52A9351C.3090802@oracle.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/mesa-dev>,
	<mailto:mesa-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/mesa-dev>
List-Post: <mailto:mesa-dev@lists.freedesktop.org>
List-Help: <mailto:mesa-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/mesa-dev>,
	<mailto:mesa-dev-request@lists.freedesktop.org?subject=subscribe>
Sender: mesa-dev-bounces@lists.freedesktop.org
Errors-To: mesa-dev-bounces@lists.freedesktop.org
To: Alan Coopersmith <alan.coopersmith@oracle.com>
Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============1989018802==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

Alan Coopersmith <alan.coopersmith@oracle.com> writes:

> You should drop that line - those comments are used for us to figure out =
which
> xproto version to list in the pkg-config requirements when using newer _X=
_*=20
> macros out of Xfuncproto.h, so doesn't make sense here.
>
> Also be warned that using a macro name starting with an _ will cause you =
to get
> complaints about violating the "reserved for the implementation" rule in =
the
> ANSI/ISO C standards from people who consider the implementation to solel=
y be
> the compiler, not the OS.  https://bugs.freedesktop.org/show_bug.cgi?id=
=3D70686
> for example.

Thanks for the suggestions; both easy to adopt.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIVAwUBUqlauNsiGmkAAAARAQja+xAAkOZtOjfmuXUBQGpUeyQliszgmZO6vpWK
3DUWMwZRdm4/vZrBkQM6SI2rj/WrJEc134rfoyC3ZC98T5mQEyyZjNuQorEgZSxI
kfqyqPMmcHhoysaNVDSvZIWQiJIGbWru3lUzuqy2f8aDQaCC/K4B/x560UQazlzF
nHRzVViB0tzA0cQyTzxlBdyzB+jDMSgiNhdhjg3wBXYzcN79k00pXHppNMyCE/y7
glf7u6BNgWFXatngzAxMbnQHi0F1JmTgQ7xtuyIQ1nmOE/C0OInm3iI+cTRB7HFG
sm4Ce9OJPXRf/b0pyQII0Cd+5u2vX17f6hyNSZD6KLKB8JQrR3a5uu7/dWlCvVPz
rtgZm+TdDgZvp0kkveq/3EhOHl65LTaiVfdGcXuG4bKjqDENelBYazWpTsamYvvp
f4G27zAtEdfZQfGSAU0YdsyaFUXBM7MJYPG/2jnfGhv1yil6ffHL25U2dLhDsi32
Ykj1BxHKLoj0E2az237yQHZX3SfMT3Vk/ikO6ztAAMihwKrm5Sbhyl/MBm625OG6
IKqmAAPscmEeuHbKWzF4+U4E/07AHexuaIdTxHBs2BGFOedN9oUQ9G5Nv5fnSPNi
CieR+2FYX9MQvAojdhYubW9i3DJNNsufyo1/L8KGPJ/w8cHCODdBcOzfFQg2l3Nl
pcQz54QLX3I=
=LPW2
-----END PGP SIGNATURE-----
--=-=-=--

--===============1989018802==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

--===============1989018802==--