From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8428B423E8A; Wed, 23 Sep 2026 17:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790186167; cv=none; b=msVjd+N6mOumCWfaZpM5/FlrYS5uVNJRzPs8da85sLWxqyhCKyvOt4bWR+bE6uybRdWeBIkEDjzOnxx4Kfm+7qSZcwKjtpyb2R5mwxuQxl+XqlZLTajZw6rCympoThTd1y8WoW2tRdbbkb8Tv8PQhinnftg2vQIdMTNqJPzjtFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790186167; c=relaxed/simple; bh=IgYrzGv3GAR+oSrmYS8KbJaOvZ63i8REBVvPEeWVztg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=GwkuJjYAUm01dfb/Yz3dUHEQZGDSKqPtBMjH4Ye6mX3b9OwsH1+/3db/z7XfLGKbWywrwAWkgdHzNiMn28aYV3TWE06Gel7Gw131CqsIxGJOKBNw9AvD1NfldhXkBy/O435kPJCanicLiMDTRlY288RCtB4CRAhUaK/JalI/VoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YFnAeGEO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YFnAeGEO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E189F1F000FF; Wed, 23 Sep 2026 17:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790186165; bh=+l6+DVGUFN64O6d08bcZG9OWF2xVHTC1zWXloLSk9r8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YFnAeGEO1nXbcQ8CV0dcE9j4iq3CeEKS/X5k7U0dFH+rXEsg64ToWw2F3nHjVtUce OjatB4s+fKSpV+4yurm/WIPvjt3hwt7o1wuowal8jZZSSIDwxe8k8lUKarF+4xOtOA nxfwaJZsnWQ7xr5lxT/QTOiJX4TGOi9mYnHG2E7ESLObRh6qTLn+btzQzNO1ByAHWu HwnjVwvCj9QIBDPx+v8Mh0S4gliO7PIShef1Pfz84BG7MlUNyfzGZc+baSWie4NewJ RGMB6z0T/SGsZYblmx5RR2dNAdxu00Ro6SrD7QLxwMop72sFb+WcJNPR6TMN5BcpeC wgy/SyjqxOQpw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x9RCN-0000000CfYC-3bV6; Wed, 23 Sep 2026 17:56:03 +0000 Date: Wed, 23 Sep 2026 18:56:03 +0100 Message-ID: <86tsnf4zt8.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: sashiko-reviews@lists.linux.dev, kvmarm@lists.linux.dev Subject: Re: [PATCH 3/3] KVM: arm64: vgic: Stop the VM when disabling LPIs In-Reply-To: References: <20260922214212.3327146-1-maz@kernel.org> <20260922214212.3327146-4-maz@kernel.org> <20260922220125.91CC01F000FF@smtp.kernel.org> <86v77w50us.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oupton@kernel.org, sashiko-reviews@lists.linux.dev, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 23 Sep 2026 17:41:53 +0100, Oliver Upton wrote: > > No issues with this approach but it is worth noting that all other > callers of kvm_arm_halt_guest() do so behind the config_lock today. You > could probably do the same with the LPI disable path. Not quite. The IRQ bypass stuff doesn't know about the lock... But maybe we can fix it the same way. I'll investigate. Thanks, M. -- Without deviation from the norm, progress is not possible.