From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5072318C027; Tue, 20 Aug 2024 09:54:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724147700; cv=none; b=eQ3I5XgK76JWL1alwD1ZFqzSldCZcPCj8on6KgrnYWKlk3cGSKJIZGTouJ1kxSiz8o0gbmaO3BYATF2X6PiwV+/3n8kvy/oqssnnBFz28077kgx5d4YLUO3ao3eqWAxlwv2nSGSxeSg0WpMLCko/0KjWmb2DpEo91IXzD2qu5WU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724147700; c=relaxed/simple; bh=Skj0x3MfuIw+zzNHiN5rJLqdPBEqOODIJoUTO80lc48=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=IzZOmbl1qKbkmOeqlOmLkG6LrxSm8hwhOYPnHj9/kMrXnVFdMMBsaHefY14I4DTRZ/1XXewTpA3QYu/8rNpuPrtQpL2VHOyGRTMeYXCKNZ+FbUVyJcKlBpuEzH/+AIOG58tGphJLoPvK2tGeOIAWvs6R6i0YxEulo60CanrrfiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ARVc1Xeg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ARVc1Xeg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB4ADC4AF09; Tue, 20 Aug 2024 09:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724147699; bh=Skj0x3MfuIw+zzNHiN5rJLqdPBEqOODIJoUTO80lc48=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ARVc1Xeg15K+Agq6v9d38vDMQ7O8JbcVXDS2KQ0dQ6D9NJAPcR7oAt/g4cO8ic7cj 5NIT4Z5uRtmJlCal0u8FcRQoJcEkO0QcGlc/Q6s8NaVVZfrr54ZC98FO48s6Xeh75i +KVIl98GRb2hukyulOnqPBEwvL1c0SQMvJS0Y9W6K9dOFCrGDnqMWCX2QdLR7Uj+jb yGnjRKX1RBaT2Cj8XAV81713X81zSiSSShL1p3PKu7+SLZwW9fw2Q3tBEF8r2Ep1ah aSqsLKFB7Vzvf0yAvBjIQ3k0w/kM975YleP/yJP5fYxcFjRA4FgLnuhXmOeZVxcnvT Lv2X9tjyaqkgw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sgLZp-005DZl-13; Tue, 20 Aug 2024 10:54:57 +0100 Date: Tue, 20 Aug 2024 10:54:56 +0100 Message-ID: <86ttffy0wf.wl-maz@kernel.org> From: Marc Zyngier To: Ma Ke Cc: tglx@linutronix.de, Suravee.Suthikulpanit@amd.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init In-Reply-To: <20240820092843.1219933-1-make24@iscas.ac.cn> References: <20240820092843.1219933-1-make24@iscas.ac.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: make24@iscas.ac.cn, tglx@linutronix.de, Suravee.Suthikulpanit@amd.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 20 Aug 2024 10:28:43 +0100, Ma Ke wrote: > > We fail to perform an of_node_put() when of_address_to_resource() > fails, leading to a refcount leak. > > Address this by moving the error handling path outside of the loop and > making it common to all failure modes. > > Cc: stable@vger.kernel.org > Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support") > Signed-off-by: Ma Ke Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.