From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE2721340 for ; Mon, 23 Oct 2023 18:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jXwRKzZw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B449AC433C7; Mon, 23 Oct 2023 18:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698084436; bh=jtuaBQVuX0vmQM7WsCi8Gb09fVhDqkHZSM6gB5rDtFo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jXwRKzZwNj0FTw56MdTWNjLatEHZ0SDJgsD2oyj1/eliX3oztcakL7bkJfTh/Z/5h vclzVmNSg4qc8m1v/jxwSn/2d6bG0bzleBauMLAUMp6I+BMV9RSLpP7ih9JRZ2s2/i RSoGSmi0rEgHV3FC1hQIR5j6weIZQ9xLWDEYl0GWTFgWS9UcQCIezJN6V34ctaCZxh 7rb5zdNJsPYztjj7uG54NurVMZpS3OVNHLHdThL1dOpxroDbKMHMM154JsME0uJE2I UHyzxTlwpaN+8tRrRU8bvcY8BFFk7SnTMcQ1XCxc8eDFkXCU8Mx9mQo5WU+gDyWji8 XK0qir1ozJvgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quzKc-006wN9-16; Mon, 23 Oct 2023 19:07:14 +0100 Date: Mon, 23 Oct 2023 19:07:13 +0100 Message-ID: <86ttqh43hq.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 06/13] KVM: arm64: Sanitize PM{C,I}NTEN{SET,CLR}, PMOVS{SET,CLR} before first run In-Reply-To: References: <20231020214053.2144305-1-rananta@google.com> <20231020214053.2144305-7-rananta@google.com> <86y1ft4ijm.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 23 Oct 2023 18:42:43 +0100, Raghavendra Rao Ananta wrote: >=20 > On Mon, Oct 23, 2023 at 5:42=E2=80=AFAM Marc Zyngier wro= te: > > > > On Fri, 20 Oct 2023 22:40:46 +0100, > > Raghavendra Rao Ananta wrote: > > > > > > For unimplemented counters, the registers PM{C,I}NTEN{SET,CLR} > > > and PMOVS{SET,CLR} are expected to have the corresponding bits RAZ. > > > Hence to ensure correct KVM's PMU emulation, mask out the bits in > > > these registers for these unimplemented counters before the first > > > vCPU run. > > > > > > Signed-off-by: Raghavendra Rao Ananta > > > --- > > > arch/arm64/kvm/arm.c | 2 +- > > > arch/arm64/kvm/pmu-emul.c | 11 +++++++++++ > > > include/kvm/arm_pmu.h | 2 ++ > > > 3 files changed, 14 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > > index e3074a9e23a8b..3c0bb80483fb1 100644 > > > --- a/arch/arm64/kvm/arm.c > > > +++ b/arch/arm64/kvm/arm.c > > > @@ -857,7 +857,7 @@ static int check_vcpu_requests(struct kvm_vcpu *v= cpu) > > > } > > > > > > if (kvm_check_request(KVM_REQ_RELOAD_PMU, vcpu)) > > > - kvm_pmu_handle_pmcr(vcpu, kvm_vcpu_read_pmcr(vc= pu)); > > > + kvm_vcpu_handle_request_reload_pmu(vcpu); > > > > Please rename this to kvm_vcpu_reload_pmu(). That's long enough. But > > see below. > > > Sounds good. >=20 > > > > > > if (kvm_check_request(KVM_REQ_RESYNC_PMU_EL0, vcpu)) > > > kvm_vcpu_pmu_restore_guest(vcpu); > > > diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c > > > index 9e24581206c24..31e4933293b76 100644 > > > --- a/arch/arm64/kvm/pmu-emul.c > > > +++ b/arch/arm64/kvm/pmu-emul.c > > > @@ -788,6 +788,17 @@ u64 kvm_pmu_get_pmceid(struct kvm_vcpu *vcpu, bo= ol pmceid1) > > > return val & mask; > > > } > > > > > > +void kvm_vcpu_handle_request_reload_pmu(struct kvm_vcpu *vcpu) > > > +{ > > > + u64 mask =3D kvm_pmu_valid_counter_mask(vcpu); > > > + > > > + kvm_pmu_handle_pmcr(vcpu, kvm_vcpu_read_pmcr(vcpu)); > > > + > > > + __vcpu_sys_reg(vcpu, PMOVSSET_EL0) &=3D mask; > > > + __vcpu_sys_reg(vcpu, PMINTENSET_EL1) &=3D mask; > > > + __vcpu_sys_reg(vcpu, PMCNTENSET_EL0) &=3D mask; > > > +} > > > > Why is this done on a vcpu request? Why can't it be done upfront, when > > we're requesting the reload? Or when assigning the PMU? Or when > > setting PMCR_EL0? > > > The idea was to do this only once, after userspace has configured the > PMCR.N (and has no option to change it), but before we run the guest > for the first time. So, I guess this can be done when we are > requesting the reload, if you prefer. Well, I'm trying to limit the proliferation of these one-off "helpers" that make the code hard to follow. So it isn't "what I prefer", but what makes the code easier to understand without having to follow a maze of pointless abstraction. > When assigning the PMU, it could be too early to sanitize as the > userspace would not have configured the PMCR.N yet. > It can probably be done when userspace configures PMCR.N, but since > this field is per-guest, we may have to apply the setting for all the > vCPUs during the ioctl, which may get a little ugly. Right. So it has to happen at the point where userspace cannot write to PMCR_EL0 anymore, for which any of the options I mentioned is too early. What you have is thus correct. But it would have helped if that rationale was captured in the commit message. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65629C25B46 for ; Mon, 23 Oct 2023 18:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fgoL2oaVzwpy64bITGRWDfYUjDaSR5TL7HamUbMZnEw=; b=X/6QETsgR0OZ5S Ninrylk52dAxMXm2qUTXDbzGGvgGRw6v6ow484evx6ewZJjBTNEBeAIRFMQWd1y0LQYrn7Jzxi4zx epijtr0BesKiLDK70g4fmD8KgWZehBgQdpuXzdG3yfgX1+TwtvJ0oNbdGgcXZqYtPdXPrmXs2P1rM IeOC01j+cgTM1Xk0+NXpTEag1MY7Nj0/ct6DiLSUP+ZnMKGltLgprwtcrtesztKsslB3cnTCAJkxR fk8rfUV7l7LsYNim4/2kZwufsB8HJ01XX9chIdZfyDtWhBqUNQils8cNQhy35RoLkJV4Ww6sZRH5C IaOo16u5iCe4b2KKyKNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quzKj-0082pd-2b; Mon, 23 Oct 2023 18:07:21 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quzKh-0082oy-19 for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 18:07:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8268ECE27C9; Mon, 23 Oct 2023 18:07:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B449AC433C7; Mon, 23 Oct 2023 18:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698084436; bh=jtuaBQVuX0vmQM7WsCi8Gb09fVhDqkHZSM6gB5rDtFo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jXwRKzZwNj0FTw56MdTWNjLatEHZ0SDJgsD2oyj1/eliX3oztcakL7bkJfTh/Z/5h vclzVmNSg4qc8m1v/jxwSn/2d6bG0bzleBauMLAUMp6I+BMV9RSLpP7ih9JRZ2s2/i RSoGSmi0rEgHV3FC1hQIR5j6weIZQ9xLWDEYl0GWTFgWS9UcQCIezJN6V34ctaCZxh 7rb5zdNJsPYztjj7uG54NurVMZpS3OVNHLHdThL1dOpxroDbKMHMM154JsME0uJE2I UHyzxTlwpaN+8tRrRU8bvcY8BFFk7SnTMcQ1XCxc8eDFkXCU8Mx9mQo5WU+gDyWji8 XK0qir1ozJvgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quzKc-006wN9-16; Mon, 23 Oct 2023 19:07:14 +0100 Date: Mon, 23 Oct 2023 19:07:13 +0100 Message-ID: <86ttqh43hq.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 06/13] KVM: arm64: Sanitize PM{C,I}NTEN{SET,CLR}, PMOVS{SET,CLR} before first run In-Reply-To: References: <20231020214053.2144305-1-rananta@google.com> <20231020214053.2144305-7-rananta@google.com> <86y1ft4ijm.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_110719_736961_BB9D7668 X-CRM114-Status: GOOD ( 34.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMyBPY3QgMjAyMyAxODo0Mjo0MyArMDEwMCwKUmFnaGF2ZW5kcmEgUmFvIEFuYW50 YSA8cmFuYW50YUBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBPbiBNb24sIE9jdCAyMywgMjAyMyBh dCA1OjQy4oCvQU0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4g T24gRnJpLCAyMCBPY3QgMjAyMyAyMjo0MDo0NiArMDEwMCwKPiA+IFJhZ2hhdmVuZHJhIFJhbyBB bmFudGEgPHJhbmFudGFAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEZvciB1bmltcGxl bWVudGVkIGNvdW50ZXJzLCB0aGUgcmVnaXN0ZXJzIFBNe0MsSX1OVEVOe1NFVCxDTFJ9Cj4gPiA+ IGFuZCBQTU9WU3tTRVQsQ0xSfSBhcmUgZXhwZWN0ZWQgdG8gaGF2ZSB0aGUgY29ycmVzcG9uZGlu ZyBiaXRzIFJBWi4KPiA+ID4gSGVuY2UgdG8gZW5zdXJlIGNvcnJlY3QgS1ZNJ3MgUE1VIGVtdWxh dGlvbiwgbWFzayBvdXQgdGhlIGJpdHMgaW4KPiA+ID4gdGhlc2UgcmVnaXN0ZXJzIGZvciB0aGVz ZSB1bmltcGxlbWVudGVkIGNvdW50ZXJzIGJlZm9yZSB0aGUgZmlyc3QKPiA+ID4gdkNQVSBydW4u Cj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgPHJhbmFu dGFAZ29vZ2xlLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBhcmNoL2FybTY0L2t2bS9hcm0uYyAgICAg IHwgIDIgKy0KPiA+ID4gIGFyY2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMgfCAxMSArKysrKysrKysr Kwo+ID4gPiAgaW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICB8ICAyICsrCj4gPiA+ICAzIGZpbGVz IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4KPiA+ID4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL2FybS5jIGIvYXJjaC9hcm02NC9rdm0vYXJtLmMKPiA+ ID4gaW5kZXggZTMwNzRhOWUyM2E4Yi4uM2MwYmI4MDQ4M2ZiMSAxMDA2NDQKPiA+ID4gLS0tIGEv YXJjaC9hcm02NC9rdm0vYXJtLmMKPiA+ID4gKysrIGIvYXJjaC9hcm02NC9rdm0vYXJtLmMKPiA+ ID4gQEAgLTg1Nyw3ICs4NTcsNyBAQCBzdGF0aWMgaW50IGNoZWNrX3ZjcHVfcmVxdWVzdHMoc3Ry dWN0IGt2bV92Y3B1ICp2Y3B1KQo+ID4gPiAgICAgICAgICAgICAgIH0KPiA+ID4KPiA+ID4gICAg ICAgICAgICAgICBpZiAoa3ZtX2NoZWNrX3JlcXVlc3QoS1ZNX1JFUV9SRUxPQURfUE1VLCB2Y3B1 KSkKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIGt2bV9wbXVfaGFuZGxlX3BtY3IodmNwdSwg a3ZtX3ZjcHVfcmVhZF9wbWNyKHZjcHUpKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGt2 bV92Y3B1X2hhbmRsZV9yZXF1ZXN0X3JlbG9hZF9wbXUodmNwdSk7Cj4gPgo+ID4gUGxlYXNlIHJl bmFtZSB0aGlzIHRvIGt2bV92Y3B1X3JlbG9hZF9wbXUoKS4gVGhhdCdzIGxvbmcgZW5vdWdoLiBC dXQKPiA+IHNlZSBiZWxvdy4KPiA+Cj4gU291bmRzIGdvb2QuCj4gCj4gPiA+Cj4gPiA+ICAgICAg ICAgICAgICAgaWYgKGt2bV9jaGVja19yZXF1ZXN0KEtWTV9SRVFfUkVTWU5DX1BNVV9FTDAsIHZj cHUpKQo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAga3ZtX3ZjcHVfcG11X3Jlc3RvcmVfZ3Vl c3QodmNwdSk7Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jIGIv YXJjaC9hcm02NC9rdm0vcG11LWVtdWwuYwo+ID4gPiBpbmRleCA5ZTI0NTgxMjA2YzI0Li4zMWU0 OTMzMjkzYjc2IDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jCj4g PiA+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMKPiA+ID4gQEAgLTc4OCw2ICs3ODgs MTcgQEAgdTY0IGt2bV9wbXVfZ2V0X3BtY2VpZChzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsIGJvb2wg cG1jZWlkMSkKPiA+ID4gICAgICAgcmV0dXJuIHZhbCAmIG1hc2s7Cj4gPiA+ICB9Cj4gPiA+Cj4g PiA+ICt2b2lkIGt2bV92Y3B1X2hhbmRsZV9yZXF1ZXN0X3JlbG9hZF9wbXUoc3RydWN0IGt2bV92 Y3B1ICp2Y3B1KQo+ID4gPiArewo+ID4gPiArICAgICB1NjQgbWFzayA9IGt2bV9wbXVfdmFsaWRf Y291bnRlcl9tYXNrKHZjcHUpOwo+ID4gPiArCj4gPiA+ICsgICAgIGt2bV9wbXVfaGFuZGxlX3Bt Y3IodmNwdSwga3ZtX3ZjcHVfcmVhZF9wbWNyKHZjcHUpKTsKPiA+ID4gKwo+ID4gPiArICAgICBf X3ZjcHVfc3lzX3JlZyh2Y3B1LCBQTU9WU1NFVF9FTDApICY9IG1hc2s7Cj4gPiA+ICsgICAgIF9f dmNwdV9zeXNfcmVnKHZjcHUsIFBNSU5URU5TRVRfRUwxKSAmPSBtYXNrOwo+ID4gPiArICAgICBf X3ZjcHVfc3lzX3JlZyh2Y3B1LCBQTUNOVEVOU0VUX0VMMCkgJj0gbWFzazsKPiA+ID4gK30KPiA+ Cj4gPiBXaHkgaXMgdGhpcyBkb25lIG9uIGEgdmNwdSByZXF1ZXN0PyBXaHkgY2FuJ3QgaXQgYmUg ZG9uZSB1cGZyb250LCB3aGVuCj4gPiB3ZSdyZSByZXF1ZXN0aW5nIHRoZSByZWxvYWQ/IE9yIHdo ZW4gYXNzaWduaW5nIHRoZSBQTVU/IE9yIHdoZW4KPiA+IHNldHRpbmcgUE1DUl9FTDA/Cj4gPgo+ IFRoZSBpZGVhIHdhcyB0byBkbyB0aGlzIG9ubHkgb25jZSwgYWZ0ZXIgdXNlcnNwYWNlIGhhcyBj b25maWd1cmVkIHRoZQo+IFBNQ1IuTiAoYW5kIGhhcyBubyBvcHRpb24gdG8gY2hhbmdlIGl0KSwg YnV0IGJlZm9yZSB3ZSBydW4gdGhlIGd1ZXN0Cj4gZm9yIHRoZSBmaXJzdCB0aW1lLiBTbywgSSBn dWVzcyB0aGlzIGNhbiBiZSBkb25lIHdoZW4gd2UgYXJlCj4gcmVxdWVzdGluZyB0aGUgcmVsb2Fk LCBpZiB5b3UgcHJlZmVyLgoKV2VsbCwgSSdtIHRyeWluZyB0byBsaW1pdCB0aGUgcHJvbGlmZXJh dGlvbiBvZiB0aGVzZSBvbmUtb2ZmICJoZWxwZXJzIgp0aGF0IG1ha2UgdGhlIGNvZGUgaGFyZCB0 byBmb2xsb3cuIFNvIGl0IGlzbid0ICJ3aGF0IEkgcHJlZmVyIiwgYnV0CndoYXQgbWFrZXMgdGhl IGNvZGUgZWFzaWVyIHRvIHVuZGVyc3RhbmQgd2l0aG91dCBoYXZpbmcgdG8gZm9sbG93IGEKbWF6 ZSBvZiBwb2ludGxlc3MgYWJzdHJhY3Rpb24uCgo+IFdoZW4gYXNzaWduaW5nIHRoZSBQTVUsIGl0 IGNvdWxkIGJlIHRvbyBlYXJseSB0byBzYW5pdGl6ZSBhcyB0aGUKPiB1c2Vyc3BhY2Ugd291bGQg bm90IGhhdmUgY29uZmlndXJlZCB0aGUgUE1DUi5OIHlldC4KPiBJdCBjYW4gcHJvYmFibHkgYmUg ZG9uZSB3aGVuIHVzZXJzcGFjZSBjb25maWd1cmVzIFBNQ1IuTiwgYnV0IHNpbmNlCj4gdGhpcyBm aWVsZCBpcyBwZXItZ3Vlc3QsIHdlIG1heSBoYXZlIHRvIGFwcGx5IHRoZSBzZXR0aW5nIGZvciBh bGwgdGhlCj4gdkNQVXMgZHVyaW5nIHRoZSBpb2N0bCwgd2hpY2ggbWF5IGdldCBhIGxpdHRsZSB1 Z2x5LgoKUmlnaHQuIFNvIGl0IGhhcyB0byBoYXBwZW4gYXQgdGhlIHBvaW50IHdoZXJlIHVzZXJz cGFjZSBjYW5ub3Qgd3JpdGUKdG8gUE1DUl9FTDAgYW55bW9yZSwgZm9yIHdoaWNoIGFueSBvZiB0 aGUgb3B0aW9ucyBJIG1lbnRpb25lZCBpcyB0b28KZWFybHkuIFdoYXQgeW91IGhhdmUgaXMgdGh1 cyBjb3JyZWN0LiBCdXQgaXQgd291bGQgaGF2ZSBoZWxwZWQgaWYgdGhhdApyYXRpb25hbGUgd2Fz IGNhcHR1cmVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4KCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0 aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK