From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 779777F4
	for <loongarch@lists.linux.dev>; Tue, 27 Sep 2022 11:37:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BF0EC433D6;
	Tue, 27 Sep 2022 11:37:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664278630;
	bh=3PBR6jtbh1qTflhCYVgBgGTgrWQZjL8THBuMEWqh6Ls=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=u9TwBkciHvLbhWtRjmeA9Gi9qYfDxSP8WqasYHlU6mxqB7RpbKwOIdpCu0NObXB7u
	 VNJeLyZMUKsnu9kJUo0xkzCxkX/l3PWB/1EbU1qLbjwYmCDahHNjzyBwaAgBBiVt9V
	 Mz0aedshjFhtf4dpFLEj2jzRso/96UNQ1LDaMYN/QGq+/YS92zDYyW3a0kN+koxuzl
	 dJHvyKP09mcPtRFbwZduf+j0hgjEu9NbEYfueIpRidG/pwbmLKZTPNy3I055+ySzqh
	 xATTTo0EqIlOt7eGM8o48R5Hz25WXtsZT0Q53FVRhO9Tpwh/HRIuqilCJAmASYsOQs
	 +rwK4MujNu4/Q==
Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org)
	by disco-boy.misterjones.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.95)
	(envelope-from <maz@kernel.org>)
	id 1od8tf-00Cy3R-TZ;
	Tue, 27 Sep 2022 12:37:08 +0100
Date: Tue, 27 Sep 2022 07:37:07 -0400
Message-ID: <86tu4t6obg.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Huacai Chen" <chenhuacai@loongson.cn>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	loongarch@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	"Xuefeng Li" <lixuefeng@loongson.cn>,
	"Huacai Chen" <chenhuacai@gmail.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems
In-Reply-To: <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
References: <20220927045514.2762299-1-chenhuacai@loongson.cn>
	<e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
X-Mailing-List: loongarch@lists.linux.dev
List-Id: <loongarch.lists.linux.dev>
List-Subscribe: <mailto:loongarch+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:loongarch+unsubscribe@lists.linux.dev>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: arnd@arndb.de, chenhuacai@loongson.cn, tglx@linutronix.de, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, lixuefeng@loongson.cn, chenhuacai@gmail.com, jiaxun.yang@flygoat.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Tue, 27 Sep 2022 03:51:04 -0400,
"Arnd Bergmann" <arnd@arndb.de> wrote:
> 
> On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
> 
> > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> > 
> >  void __init irqchip_init(void)
> >  {
> > +#ifdef CONFIG_OF_IRQ
> >  	of_irq_init(__irqchip_of_table);
> > +#endif
> >  	acpi_probe_device_table(irqchip);
> >  }
> 
> I think that #ifdef should be in the include/linux/of_irq.h
> header, with an empty inline function in the #else path.

Agreed. Please keep the C code free of #ifdefs if at all possible.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.