All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <chris@printf.net>
To: Grant Grundler <grundler@chromium.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Puthikorn Voravootivat <puthik@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v2] mmc-utils: add eMMC 5.0 FFU support
Date: Wed, 29 Jan 2014 01:34:10 +0000	[thread overview]
Message-ID: <86txcnzi3x.fsf@void.printf.net> (raw)
In-Reply-To: <1390506264-17107-1-git-send-email-grundler@chromium.org> (Grant Grundler's message of "Thu, 23 Jan 2014 11:44:24 -0800")

Hi Grant, still one warning/error left:

On Thu, Jan 23 2014, Grant Grundler wrote:
> V2:
> Fix compiler borkage in use of strncmp().
> Use '\0' instead of 0 in char assignment.

λ make
cc  -Wall -Werror -Wuninitialized -Wundef -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -O2 -Wp,-MMD,./.mmc_cmds.o.d,-MT,mmc_cmds.o -c mmc_cmds.c
mmc_cmds.c: In function ‘do_firmware_update’:
mmc_cmds.c:1290:4: error: format ‘%d’ expects argument of type ‘int’,
but argument 3 has type ‘size_t’ [-Werror=format=]
    fwsize, fwfilename, ret);
    ^
cc1: all warnings being treated as errors

-- 
Chris Ball   <chris@printf.net>   <http://printf.net/>

  reply	other threads:[~2014-01-29  1:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 19:44 [PATCH v2] mmc-utils: add eMMC 5.0 FFU support Grant Grundler
2014-01-29  1:34 ` Chris Ball [this message]
2014-02-02 17:52 ` Chris Ball
2014-02-03 17:21   ` Grant Grundler
2014-02-06 11:57 ` Alex Lemberg
2014-02-06 18:41   ` Grant Grundler
2014-02-09  9:06     ` Alex Lemberg
2014-02-21 21:27       ` Grant Grundler
2014-02-21 21:31         ` Grant Grundler
2014-02-26 23:07           ` Alex Lemberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86txcnzi3x.fsf@void.printf.net \
    --to=chris@printf.net \
    --cc=grundler@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=puthik@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.