From: merlyn@stonehenge.com (Randal L. Schwartz)
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] import-tars: be nice to wrong directory modes
Date: Sat, 28 Apr 2007 18:36:33 -0700 [thread overview]
Message-ID: <86tzv07yhq.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704290159230.29859@racer.site> (Johannes Schindelin's message of "Sun, 29 Apr 2007 01:59:47 +0200 (CEST)")
>>>>> "Johannes" == Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Johannes> + next if $name =~ '/$';
This is misleading. That's a regex there. And it also falsely matches a
string ending in "/\n", but I bet there are parts of git that break on those
filenames too. :)
Consider:
next if $name =~ m{/\z};
which matches precisely when the filename ends in /.
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
prev parent reply other threads:[~2007-04-29 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 23:59 [PATCH] import-tars: be nice to wrong directory modes Johannes Schindelin
2007-04-29 0:08 ` Shawn O. Pearce
2007-04-29 1:07 ` Junio C Hamano
2007-04-29 1:11 ` Shawn O. Pearce
2007-04-29 1:36 ` Randal L. Schwartz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tzv07yhq.fsf@blue.stonehenge.com \
--to=merlyn@stonehenge.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.