From: Mikhail Rudenko <xyzzy@yandex-team.ru>
To: Mikhail Rudenko <xyzzy@yandex-team.ru>
Cc: Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: reject IOPS limits above UINT_MAX for legacy interface
Date: Sat, 05 Sep 2026 16:09:26 +0300 [thread overview]
Message-ID: <86v78jrgga.fsf@yandex-team.ru> (raw)
In-Reply-To: <20260903-throttl-truncation-fix-v1-1-c6a864c8bc17@yandex-team.ru>
On 2026-09-03 at 14:54 +03, Mikhail Rudenko <xyzzy@yandex-team.ru> wrote:
> tg_set_conf(), used for blkio.throttle.{read,write}_iops_device legacy
> blkio cgroup sysfs knobs, parses limits as u64 but stores them in
> unsigned int, silently truncating values above UINT_MAX. In addition
> to being an obvios correctness issue, this may result in division by
> zero in tg_within_iops_limit(), if the value is truncated to zero.
Nevermind, there is a patch under review [1] which solves this.
[1] https://lore.kernel.org/r/20260722102459.253189-1-cui.tao@linux.dev
--
Best regards,
Mikhail Rudenko
prev parent reply other threads:[~2026-09-05 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 11:54 [PATCH] blk-throttle: reject IOPS limits above UINT_MAX for legacy interface Mikhail Rudenko
2026-09-05 13:09 ` Mikhail Rudenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v78jrgga.fsf@yandex-team.ru \
--to=xyzzy@yandex-team.ru \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.