From: Marc Zyngier <maz@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: tglx@linutronix.de, Suravee.Suthikulpanit@amd.com,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
Date: Tue, 20 Aug 2024 09:50:27 +0100 [thread overview]
Message-ID: <86v7zvy3vw.wl-maz@kernel.org> (raw)
In-Reply-To: <20240820075401.1206522-1-make24@iscas.ac.cn>
On Tue, 20 Aug 2024 08:54:01 +0100,
Ma Ke <make24@iscas.ac.cn> wrote:
>
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().
This doesn't reflect the patch anymore. Something like this should be
closer to reality:
"We fail to perform an of_node_put() when of_address_to_resource()
fails, leading to a refcount leak.
Address this by moving the error handling path outside of the loop and
making it common to all failure modes."
With the commit message fixed:
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2024-08-20 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 7:54 [PATCH v2] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init Ma Ke
2024-08-20 8:50 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v7zvy3vw.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.