From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF2512D20D for ; Wed, 17 Apr 2024 10:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713351370; cv=none; b=uKssSApLsGLbeK8PXTTXLmxd2g3QGo/qEFoQTlZR2CzImdZf/5BQ9g7O/9c5Q1hbbV0bnKRrpgRy9HsCSCnBt7d7VF6bn+3+Mz9LUnV4tMxQKfc23QumdNJ7eBgnfznXglhKzRX5g/99o3s6sLlffF/GqX2nmm99okmNmyoW7Yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713351370; c=relaxed/simple; bh=EWti/8CN6ncBmT5gymMNjUv58LReaR0BCx6NWeoqYE0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=eLPmvM6SRqWKKp7LN4aXmV+uZsbW7fFBbJ3i4PFwO8DFgRSebjDc2luXxNZXvJ48O7xJfgEuTo0+a5U+M1nOESuWg+RROqSN2+S2B01CeUl82fE5nVBsnZ8NYYzoU72FTBO0bxIQ8tpRAP2ghRRekHjxhCiQAXvtmRPC8Ah/cV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ERZ1YEyl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ERZ1YEyl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D90B6C072AA; Wed, 17 Apr 2024 10:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713351369; bh=EWti/8CN6ncBmT5gymMNjUv58LReaR0BCx6NWeoqYE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ERZ1YEyl9I2YiVpCO4Ls9TAVkyd/wNyGV0D6MjL0xcFkjAUcPLZzxjuacbG+DKZI9 zTuWDbHQ8DJB9koR+B9Sx8Ho5C2mNxth9keEzlMSt0Yryd5mH+/ftj7tXGGIKuQXLe mwpA3QZHJVq4RDZWNa7iH0+Zw9e6GFn1GQYhp5u5ZrPNWh4DeOsYV+7t7h6Wg8fTdq SSE/vuJxOG0LOQictZpZaxW6UkRWvVl+z6B+ID/ocbVLKe46hoP/PNScq8yLE+WeG2 7PaoJ4tgfRlF5AoyiPGXnyPVxXUJjnz4cvdqgfBLqj+SNZrB4MRr8EWpSLCtbDuwk6 St/lMZWWd8p1g== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rx2xT-005L7r-El; Wed, 17 Apr 2024 11:56:07 +0100 Date: Wed, 17 Apr 2024 11:56:07 +0100 Message-ID: <86v84gqmuw.wl-maz@kernel.org> From: Marc Zyngier To: Dawei Li Cc: tglx@linutronix.de, yury.norov@gmail.com, rafael@kernel.org, akpm@linux-foundation.org, florian.fainelli@broadcom.com, chenhuacai@kernel.org, jiaxun.yang@flygoat.com, anup@brainfault.org, palmer@dabbelt.com, samuel.holland@sifive.com, linux@rasmusvillemoes.dk, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack In-Reply-To: <20240416085454.3547175-4-dawei.li@shingroup.cn> References: <20240416085454.3547175-1-dawei.li@shingroup.cn> <20240416085454.3547175-4-dawei.li@shingroup.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dawei.li@shingroup.cn, tglx@linutronix.de, yury.norov@gmail.com, rafael@kernel.org, akpm@linux-foundation.org, florian.fainelli@broadcom.com, chenhuacai@kernel.org, jiaxun.yang@flygoat.com, anup@brainfault.org, palmer@dabbelt.com, samuel.holland@sifive.com, linux@rasmusvillemoes.dk, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 16 Apr 2024 09:54:50 +0100, Dawei Li wrote: > > In general it's preferable to avoid placing cpumasks on the stack, as > for large values of NR_CPUS these can consume significant amounts of > stack space and make stack overflows more likely. > > Remove cpumask var on stack and use cpumask_any_and() to address it. > > Signed-off-by: Dawei Li Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.