From: Marc Zyngier <maz@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype
Date: Wed, 20 Sep 2023 10:51:27 +0100 [thread overview]
Message-ID: <86v8c5cgv4.wl-maz@kernel.org> (raw)
In-Reply-To: <20230920052139.10570-10-rdunlap@infradead.org>
On Wed, 20 Sep 2023 06:21:32 +0100,
Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Add <linux/irqchips/xtensa-mx.h> to provide the function prototype to
> prevent a build warning:
>
> drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes]
> 166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent)
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
> drivers/irqchip/irq-xtensa-mx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c
> --- a/drivers/irqchip/irq-xtensa-mx.c
> +++ b/drivers/irqchip/irq-xtensa-mx.c
> @@ -12,6 +12,7 @@
> #include <linux/irqdomain.h>
> #include <linux/irq.h>
> #include <linux/irqchip.h>
> +#include <linux/irqchip/xtensa-mx.h>
> #include <linux/of.h>
>
> #include <asm/mxregs.h>
>
Acked-by: Marc Zyngier <maz@kernel.org>
It also begs the question of the continuing support for non-DT driven
systems.
Max, Chris: are we any closer to being DT-only on the xtensa front?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-09-20 9:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 5:21 [PATCH 00/16] xtensa: fix W=1 build warnings Randy Dunlap
2023-09-20 5:21 ` [PATCH 01/16] xtensa: FSF: define XCHAL_HAVE_DIV32 Randy Dunlap
2023-09-20 11:53 ` Max Filippov
2023-09-20 5:21 ` [PATCH 02/16] xtensa: fault: include <asm/traps.h> Randy Dunlap
2023-09-20 5:21 ` [PATCH 03/16] xtensa: irq: " Randy Dunlap
2023-09-20 5:21 ` [PATCH 04/16] xtensa: ptrace: add prototypes to <asm/ptrace.h> Randy Dunlap
2023-09-20 5:21 ` [PATCH 05/16] xtensa: processor.h: add init_arch() prototype Randy Dunlap
2023-09-20 5:21 ` [PATCH 06/16] xtensa: signal: include headers for function prototypes Randy Dunlap
2023-09-20 5:21 ` [PATCH 07/16] xtensa: stacktrace: include <asm/ftrace.h> for prototype Randy Dunlap
2023-09-20 5:21 ` [PATCH 08/16] xtensa: traps: add <linux/cpu.h> for function prototype Randy Dunlap
2023-09-20 5:21 ` [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype Randy Dunlap
2023-09-20 9:51 ` Marc Zyngier [this message]
2023-09-20 10:53 ` Max Filippov
2023-09-20 5:21 ` [PATCH 10/16] xtensa: smp: add headers for missing function prototypes Randy Dunlap
2023-09-20 5:21 ` [PATCH 11/16] xtensa: hw_breakpoint: include header for missing prototype Randy Dunlap
2023-09-20 5:21 ` [PATCH 12/16] xtensa: tlb: include <asm/tlb.h> " Randy Dunlap
2023-09-20 5:21 ` [PATCH 13/16] xtensa: iss/network: make functions static Randy Dunlap
2023-09-20 5:21 ` [PATCH 14/16] xtensa: boot: don't add include-dirs Randy Dunlap
2023-09-20 5:21 ` [PATCH 15/16] xtensa: umulsidi3: fix conditional expression Randy Dunlap
2023-09-20 5:21 ` [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions Randy Dunlap
2023-09-20 11:54 ` Max Filippov
2023-09-20 12:11 ` [PATCH 00/16] xtensa: fix W=1 build warnings Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v8c5cgv4.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.