From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48710C4332F for ; Thu, 17 Nov 2022 20:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234784AbiKQUoh (ORCPT ); Thu, 17 Nov 2022 15:44:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbiKQUof (ORCPT ); Thu, 17 Nov 2022 15:44:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A76A5597 for ; Thu, 17 Nov 2022 12:44:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BBF661E76 for ; Thu, 17 Nov 2022 20:44:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DF43C433C1; Thu, 17 Nov 2022 20:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668717874; bh=lyFlAiXX/0sekMpQruZl7vUjQEm9ivtWTX1+AuNEpv4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YsB77V1Hae177FvyJ47xC7qQCr2z1TyL3GPcGVocr2+KgFY2N2EZn2bbQjc3YDrNm DyM6SDEOldv1muUykG221IPqtZpiK4rxq+9yh/JZje8B2O0hjmdVoKYYPrt0P6MeVo 5i0F1qQ2207XkNihG8j6v7gJToeSso1fVbDVHDdei6zp0NNVQjsYsyPyoHqpdkpcK9 0GGo5p3TDdrWCsd7lP5xNZWS2aCix/ob0fEPMzMEdfFVCpuO8LGdVznBcc2GGPnkWY zvbFPkiKrQjh2/JPNNsjyBpXaj/zoVyXn6d7cnSW+3eXojPqwUcaDfh2qf7zagzWNS 2mVvIL55k+fEg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovlkN-006pQE-LK; Thu, 17 Nov 2022 20:44:31 +0000 Date: Thu, 17 Nov 2022 20:44:30 +0000 Message-ID: <86v8ndnwep.wl-maz@kernel.org> From: Marc Zyngier To: Shivam Kumar Cc: pbonzini@redhat.com, seanjc@google.com, james.morse@arm.com, borntraeger@linux.ibm.com, david@redhat.com, kvm@vger.kernel.org, Shaju Abraham , Manish Mishra , Anurag Madnawat Subject: Re: [PATCH v7 3/4] KVM: arm64: Dirty quota-based throttling of vcpus In-Reply-To: <20221113170507.208810-4-shivam.kumar1@nutanix.com> References: <20221113170507.208810-1-shivam.kumar1@nutanix.com> <20221113170507.208810-4-shivam.kumar1@nutanix.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shivam.kumar1@nutanix.com, pbonzini@redhat.com, seanjc@google.com, james.morse@arm.com, borntraeger@linux.ibm.com, david@redhat.com, kvm@vger.kernel.org, shaju.abraham@nutanix.com, manish.mishra@nutanix.com, anurag.madnawat@nutanix.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sun, 13 Nov 2022 17:05:10 +0000, Shivam Kumar wrote: > > Exit to userspace whenever the dirty quota is exhausted (i.e. dirty count > equals/exceeds dirty quota) to request more dirty quota. > > Suggested-by: Shaju Abraham > Suggested-by: Manish Mishra > Co-developed-by: Anurag Madnawat > Signed-off-by: Anurag Madnawat > Signed-off-by: Shivam Kumar > --- > arch/arm64/kvm/arm.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 94d33e296e10..850024982dd9 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -746,6 +746,15 @@ static int check_vcpu_requests(struct kvm_vcpu *vcpu) > > if (kvm_check_request(KVM_REQ_SUSPEND, vcpu)) > return kvm_vcpu_suspend(vcpu); > + > + if (kvm_check_request(KVM_REQ_DIRTY_QUOTA_EXIT, vcpu)) { > + struct kvm_run *run = vcpu->run; > + > + run->exit_reason = KVM_EXIT_DIRTY_QUOTA_EXHAUSTED; > + run->dirty_quota_exit.count = vcpu->stat.generic.pages_dirtied; > + run->dirty_quota_exit.quota = vcpu->dirty_quota; > + return 0; > + } > } > > return 1; As pointed out by others, this should be common code. This would definitely avoid the difference in behaviour between architectures. M. -- Without deviation from the norm, progress is not possible.