From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: enable vdd when switching off the eDP panel Date: Mon, 21 May 2012 18:49:18 -0700 Message-ID: <86vcjphtnl.fsf@sumi.keithp.com> References: <1337526890-9685-1-git-send-email-daniel.vetter@ffwll.ch> <20120521164030.GB4970@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1059282936==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5859E950 for ; Mon, 21 May 2012 18:49:25 -0700 (PDT) In-Reply-To: <20120521164030.GB4970@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Intel Graphics Development , Chris Wilson Cc: Daniel Vetter , stable@kernel.org List-Id: intel-gfx@lists.freedesktop.org --===============1059282936== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -1154,11 +1154,10 @@ static void ironlake_edp_panel_off(struct intel_= dp *intel_dp) >>=20=20 >> DRM_DEBUG_KMS("Turn eDP power off\n"); >>=20=20 >> - WARN(intel_dp->want_panel_vdd, "Cannot turn power off while VDD is on\= n"); >> - ironlake_panel_vdd_off_sync(intel_dp); /* finish any pending work */ >> + WARN(!intel_dp->want_panel_vdd, "Need VDD to turn off panel\n"); >>=20=20 >> pp =3D ironlake_get_pp_control(dev_priv); >> - pp &=3D ~(POWER_TARGET_ON | EDP_FORCE_VDD | PANEL_POWER_RESET | EDP_BL= C_ENABLE); >> + pp &=3D ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_BLC_ENABLE); Can you explain where the panel is getting turned off here? =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIVAwUBT7rwnjYtFsjWk68qAQj2cBAAheNqrPJBZFV9o9hHZ3krDetgNU75+1yn E+5t7O9B3TbLAOsttu1+9/s2h7fJwNsJMtp7c/QyjugUybcxksQt35wagSnFDaI1 7CMv5zyRX7z1h+CQ/cj0qB4sZ9dIlC/ETDojUf8NtZcgTI4YnfXXQiHQq9hlkiHt oRD+P+59l8idHAXHTSAWUuxyegV1//2EWOIHW59isV8evgIsMgbDSV3FajwE4zhC ECC1FyyX64xENWK6Un04RFHwBn5S/x5fyAr2Cv+H8u8daeiTvPBeViGqcOHqYAzj gSpnwK1IRPCL9BWCsk/GW7bi6qIs9G94c05mlrdNKBWawvyWxB1Xg5V/ejk+eIqz jrQttRPccvSk9gGPuu+VRejl+NjSr4eYs3louF8vkhRJfiZ2hDvIXGfI9+F31gZc p+JBeBUU2Qf8kP2f3ZV8qGW0LZGjWmhwF1JZXjT0xB6DzOh9hCu/Vr4HIVTNEik1 o7tkAhAoNbl9bcDAdKYE1R/3/HZNoNOKI/WgLMFIkr2jBAd8LZF9fB4ad/aIgSlQ 4bgYwH/CDkfE3puO+uQn0hJkmPjhfq6Gvrz8R0MHN8EhydHdpvmpxsJcSFBpwKER P21AMO0a92G2f6YALRHEWGbzjel8e5q4kuuaf1htWkQH9SkgENt8pr/GkYcrKs8n JeEmXNNVK38= =4Tj1 -----END PGP SIGNATURE----- --=-=-=-- --===============1059282936== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1059282936==--