From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default Date: Tue, 14 Feb 2012 17:01:30 +1300 Message-ID: <86vcnaqd0l.fsf@sumi.keithp.com> References: <1328963655-12128-1-git-send-email-eugeni.dodonov@intel.com> <1328963655-12128-3-git-send-email-eugeni.dodonov@intel.com> <86y5s7rex7.fsf@sumi.keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 12D119E84E for ; Mon, 13 Feb 2012 20:01:45 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org <#part sign=pgpmime> On Sun, 12 Feb 2012 22:34:48 -0200, Eugeni Dodonov wrote: > what if we pick only the 1st patch in this series for -fixes? It won't > change the defaults in any way, but it will allow the ones willing to > enable it manually on SNB to prevent issues. That seems like too big a change at this point in the release cycle. We should be focused purely on fixing functionality bugs, not adding new features. So, instead of adding the ability to individually control RC6 levels, we should just change what RC6 does on SNB when it is enabled, then encourage people to test that and see if the shallowest RC6 states actually work. That will provide sufficient information to know whether it will be safe to turn that on by default in the next release, which is what we really want. The smallest change that gives us the data we need is what I'd like to have. -- keith.packard@intel.com